All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Sakai <msakai@redhat.com>
To: dm-devel@lists.linux.dev
Cc: Mike Snitzer <snitzer@kernel.org>, Matthew Sakai <msakai@redhat.com>
Subject: [PATCH 05/10] dm vdo thread-utils: return VDO_SUCCESS on vdo_create_thread success
Date: Thu, 29 Feb 2024 23:38:48 -0500	[thread overview]
Message-ID: <adaa76ffe3b651376239eda8e88139c68c1d2a35.1709267597.git.msakai@redhat.com> (raw)
In-Reply-To: <cover.1709267597.git.msakai@redhat.com>

From: Mike Snitzer <snitzer@kernel.org>

Update all callers to check for VDO_SUCCESS.

Signed-off-by: Mike Snitzer <snitzer@kernel.org>
Signed-off-by: Matthew Sakai <msakai@redhat.com>
---
 drivers/md/dm-vdo/indexer/funnel-requestqueue.c | 2 +-
 drivers/md/dm-vdo/indexer/index.c               | 2 +-
 drivers/md/dm-vdo/indexer/volume.c              | 2 +-
 drivers/md/dm-vdo/thread-utils.c                | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/md/dm-vdo/indexer/funnel-requestqueue.c b/drivers/md/dm-vdo/indexer/funnel-requestqueue.c
index eee7b980960f..84c7c1ae1333 100644
--- a/drivers/md/dm-vdo/indexer/funnel-requestqueue.c
+++ b/drivers/md/dm-vdo/indexer/funnel-requestqueue.c
@@ -221,7 +221,7 @@ int uds_make_request_queue(const char *queue_name,
 
 	result = vdo_create_thread(request_queue_worker, queue, queue_name,
 				   &queue->thread);
-	if (result != UDS_SUCCESS) {
+	if (result != VDO_SUCCESS) {
 		uds_request_queue_finish(queue);
 		return result;
 	}
diff --git a/drivers/md/dm-vdo/indexer/index.c b/drivers/md/dm-vdo/indexer/index.c
index 243a9deab4de..226713221105 100644
--- a/drivers/md/dm-vdo/indexer/index.c
+++ b/drivers/md/dm-vdo/indexer/index.c
@@ -798,7 +798,7 @@ static int make_chapter_writer(struct uds_index *index,
 			       writer->open_chapter_index->memory_size);
 
 	result = vdo_create_thread(close_chapters, writer, "writer", &writer->thread);
-	if (result != UDS_SUCCESS) {
+	if (result != VDO_SUCCESS) {
 		free_chapter_writer(writer);
 		return result;
 	}
diff --git a/drivers/md/dm-vdo/indexer/volume.c b/drivers/md/dm-vdo/indexer/volume.c
index 959dd82ef665..0a4beef8ac8d 100644
--- a/drivers/md/dm-vdo/indexer/volume.c
+++ b/drivers/md/dm-vdo/indexer/volume.c
@@ -1634,7 +1634,7 @@ int uds_make_volume(const struct uds_configuration *config, struct index_layout
 	for (i = 0; i < config->read_threads; i++) {
 		result = vdo_create_thread(read_thread_function, (void *) volume,
 					   "reader", &volume->reader_threads[i]);
-		if (result != UDS_SUCCESS) {
+		if (result != VDO_SUCCESS) {
 			uds_free_volume(volume);
 			return result;
 		}
diff --git a/drivers/md/dm-vdo/thread-utils.c b/drivers/md/dm-vdo/thread-utils.c
index b4aa71fffdbf..c822df86f731 100644
--- a/drivers/md/dm-vdo/thread-utils.c
+++ b/drivers/md/dm-vdo/thread-utils.c
@@ -119,7 +119,7 @@ int vdo_create_thread(void (*thread_function)(void *), void *thread_data,
 	}
 
 	*new_thread = thread;
-	return UDS_SUCCESS;
+	return VDO_SUCCESS;
 }
 
 void vdo_join_threads(struct thread *thread)
-- 
2.42.0


  parent reply	other threads:[~2024-03-01  4:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-01  4:38 [PATCH 00/10] dm vdo: standardize on VDO_SUCCESS Matthew Sakai
2024-03-01  4:38 ` [PATCH 01/10] dm vdo errors: remove unused error codes Matthew Sakai
2024-03-01  4:38 ` [PATCH 02/10] dm vdo memory-alloc: return VDO_SUCCESS on success Matthew Sakai
2024-03-01  4:38 ` [PATCH 03/10] dm vdo: check for VDO_SUCCESS return value from memory-alloc functions Matthew Sakai
2024-03-01  4:38 ` [PATCH 04/10] dm vdo int-map: return VDO_SUCCESS on success Matthew Sakai
2024-03-01  4:38 ` Matthew Sakai [this message]
2024-03-01  4:38 ` [PATCH 06/10] dm-vdo funnel-workqueue: return VDO_SUCCESS from make_simple_work_queue Matthew Sakai
2024-03-01  4:38 ` [PATCH 07/10] dm vdo permassert: audit all of ASSERT to test for VDO_SUCCESS Matthew Sakai
2024-03-01  4:38 ` [PATCH 08/10] dm vdo encodings: update some stale comments Matthew Sakai
2024-03-01  4:38 ` [PATCH 09/10] dm vdo indexer: update ASSERT and ASSERT_LOG_ONLY usage Matthew Sakai
2024-03-01  4:38 ` [PATCH 10/10] dm vdo target: eliminate inappropriate uses of UDS_SUCCESS Matthew Sakai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adaa76ffe3b651376239eda8e88139c68c1d2a35.1709267597.git.msakai@redhat.com \
    --to=msakai@redhat.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=snitzer@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.