All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com, shuang.he@linux.intel.com
Subject: [PATCH 05/18] drm/i915/audio: pass intel_encoder on to platform specific ELD functions
Date: Fri,  3 Oct 2014 15:43:48 +0300	[thread overview]
Message-ID: <ae07be70fcf809d9f06a90f51e5814b08731a29e.1412339886.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1412339886.git.jani.nikula@intel.com>
In-Reply-To: <cover.1412339886.git.jani.nikula@intel.com>

This will simplify things later on. No functional changes.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.h    |  4 ++--
 drivers/gpu/drm/i915/intel_audio.c | 14 +++++++-------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index bf4cb992869b..1cce66a02853 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -434,6 +434,7 @@ struct drm_i915_error_state {
 };
 
 struct intel_connector;
+struct intel_encoder;
 struct intel_crtc_config;
 struct intel_plane_config;
 struct intel_crtc;
@@ -483,7 +484,7 @@ struct drm_i915_display_funcs {
 	void (*crtc_disable)(struct drm_crtc *crtc);
 	void (*off)(struct drm_crtc *crtc);
 	void (*write_eld)(struct drm_connector *connector,
-			  struct drm_crtc *crtc,
+			  struct intel_encoder *encoder,
 			  struct drm_display_mode *mode);
 	void (*fdi_link_train)(struct drm_crtc *crtc);
 	void (*init_clock_gating)(struct drm_device *dev);
@@ -2784,7 +2785,6 @@ static inline bool intel_gmbus_is_forced_bit(struct i2c_adapter *adapter)
 extern void intel_i2c_reset(struct drm_device *dev);
 
 /* intel_opregion.c */
-struct intel_encoder;
 #ifdef CONFIG_ACPI
 extern int intel_opregion_setup(struct drm_device *dev);
 extern void intel_opregion_init(struct drm_device *dev);
diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
index af96b3992c21..763481d1c510 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++ b/drivers/gpu/drm/i915/intel_audio.c
@@ -97,7 +97,7 @@ static bool intel_eld_uptodate(struct drm_connector *connector,
 }
 
 static void g4x_write_eld(struct drm_connector *connector,
-			  struct drm_crtc *crtc,
+			  struct intel_encoder *encoder,
 			  struct drm_display_mode *mode)
 {
 	struct drm_i915_private *dev_priv = connector->dev->dev_private;
@@ -137,10 +137,11 @@ static void g4x_write_eld(struct drm_connector *connector,
 }
 
 static void haswell_write_eld(struct drm_connector *connector,
-			      struct drm_crtc *crtc,
+			      struct intel_encoder *encoder,
 			      struct drm_display_mode *mode)
 {
 	struct drm_i915_private *dev_priv = connector->dev->dev_private;
+	struct drm_crtc *crtc = encoder->base.crtc;
 	uint8_t *eld = connector->eld;
 	uint32_t eldv;
 	uint32_t tmp;
@@ -218,10 +219,11 @@ static void haswell_write_eld(struct drm_connector *connector,
 }
 
 static void ironlake_write_eld(struct drm_connector *connector,
-			       struct drm_crtc *crtc,
+			       struct intel_encoder *encoder,
 			       struct drm_display_mode *mode)
 {
 	struct drm_i915_private *dev_priv = connector->dev->dev_private;
+	struct drm_crtc *crtc = encoder->base.crtc;
 	uint8_t *eld = connector->eld;
 	uint32_t eldv;
 	uint32_t tmp;
@@ -253,11 +255,9 @@ static void ironlake_write_eld(struct drm_connector *connector,
 	DRM_DEBUG_DRIVER("ELD on pipe %c\n", pipe_name(pipe));
 
 	if (IS_VALLEYVIEW(connector->dev))  {
-		struct intel_encoder *intel_encoder;
 		struct intel_digital_port *intel_dig_port;
 
-		intel_encoder = intel_attached_encoder(connector);
-		intel_dig_port = enc_to_dig_port(&intel_encoder->base);
+		intel_dig_port = enc_to_dig_port(&encoder->base);
 		port = intel_dig_port->port;
 	} else {
 		tmp = I915_READ(aud_cntl_st);
@@ -333,7 +333,7 @@ void intel_write_eld(struct intel_encoder *intel_encoder)
 	connector->eld[6] = drm_av_sync_delay(connector, mode) / 2;
 
 	if (dev_priv->display.write_eld)
-		dev_priv->display.write_eld(connector, encoder->crtc, mode);
+		dev_priv->display.write_eld(connector, intel_encoder, mode);
 }
 
 /* Set up chip specific audio functions */
-- 
1.9.1

  parent reply	other threads:[~2014-10-03 12:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-03 12:43 [PATCH 00/18] drm/i915: hdmi/dp audio rework Jani Nikula
2014-10-03 12:43 ` [PATCH 01/18] drm/i915: add new intel audio file to group DP/HDMI audio Jani Nikula
2014-10-03 12:43 ` [PATCH 02/18] drm/i915/audio: constify hdmi audio clock struct Jani Nikula
2014-10-03 12:43 ` [PATCH 03/18] drm/i915/audio: beat some sense into the variable types and names Jani Nikula
2014-10-03 12:43 ` [PATCH 04/18] drm/i915: pass intel_encoder to intel_write_eld Jani Nikula
2014-10-03 12:43 ` Jani Nikula [this message]
2014-10-03 12:43 ` [PATCH 06/18] drm/i915/audio: set ELD Conn_Type at one place Jani Nikula
2014-10-03 12:43 ` [PATCH 07/18] drm/i915/ddi: write ELD where it's supposed to be done Jani Nikula
2014-10-03 12:43 ` [PATCH 08/18] drm/i915: introduce intel_audio_codec_{enable, disable} Jani Nikula
2014-10-03 12:43 ` [PATCH 09/18] drm/i915/audio: remove misleading checks for !eld[0] Jani Nikula
2014-10-03 12:43 ` [PATCH 10/18] drm/i915: clean up and clarify audio related register defines Jani Nikula
2014-10-03 12:43 ` [PATCH 11/18] drm/i915: rewrite hsw/bdw audio codec enable/disable sequences Jani Nikula
2014-10-03 12:43 ` [PATCH 12/18] drm/i915/audio: rewrite vlv/chv and gen 5-7 audio codec enable sequence Jani Nikula
2014-10-03 12:43 ` [PATCH 13/18] drm/i915/audio: add vlv/chv/gen5-7 audio codec disable sequence Jani Nikula
2014-10-03 12:43 ` [PATCH 14/18] drm/i915: enable audio codec after port Jani Nikula
2014-10-03 12:43 ` [PATCH 15/18] drm/i915/audio: add audio codec disable on g4x Jani Nikula
2014-10-03 12:43 ` [PATCH 16/18] drm/i915/audio: add audio codec enable debug log for g4x Jani Nikula
2014-10-03 12:44 ` [PATCH 17/18] drm/i915: make pipe/port based audio valid accessors easier to use Jani Nikula
2014-10-03 12:44 ` [PATCH 18/18] drm/i915/audio: add DOC comment describing HDA over HDMI/DP Jani Nikula
2014-10-03 16:22   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae07be70fcf809d9f06a90f51e5814b08731a29e.1412339886.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=shuang.he@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.