All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: kbuild-all@01.org, dri-devel@lists.freedesktop.org
Subject: [PATCH] drm: vc4: fix device_node_continue.cocci warnings
Date: Sat, 20 Jan 2018 19:09:15 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1801201907400.2635@hadrien> (raw)

From: Fengguang Wu <fengguang.wu@intel.com>

 Device node iterators put the previous value of the index variable, so an
 explicit put causes a double put.

Generated by: scripts/coccinelle/iterators/device_node_continue.cocci

Fixes: 88e6e13dd66c ("drm: vc4: Use drm_atomic_helper_shutdown() to disable planes on removal")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---

url:
https://github.com/0day-ci/linux/commits/Laurent-Pinchart/Cargo-cult-cleanup-in-atomic-drivers/20180120-183018
base:   git://people.freedesktop.org/~airlied/linux.git drm-next
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago

Please take the patch only if it's a positive warning. Thanks!

 zx_drm_drv.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/gpu/drm/zte/zx_drm_drv.c
+++ b/drivers/gpu/drm/zte/zx_drm_drv.c
@@ -163,7 +163,6 @@ static int zx_drm_probe(struct platform_

 	for_each_available_child_of_node(parent, child) {
 		component_match_add(dev, &match, compare_of, child);
-		of_node_put(child);
 	}

 	return component_master_add_with_match(dev, &zx_drm_master_ops, match);
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

                 reply	other threads:[~2018-01-20 18:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1801201907400.2635@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kbuild-all@01.org \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.