From: Julia Lawall <julia.lawall@inria.fr> To: Konrad Dybcio <konrad.dybcio@somainline.org> Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>, Andy Gross <agross@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Liam Girdwood <lgirdwood@gmail.com>, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] regulator: qcom_smd: fix for_each_child.cocci warnings Date: Sat, 15 Jan 2022 12:11:38 +0100 (CET) [thread overview] Message-ID: <alpine.DEB.2.22.394.2201151210170.3051@hadrien> (raw) From: kernel test robot <lkp@intel.com> drivers/regulator/qcom_smd-regulator.c:1318:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return around line 1321. Semantic patch information: False positives can be due to function calls within the for_each loop that may encapsulate an of_node_put. Generated by: scripts/coccinelle/iterators/for_each_child.cocci Fixes: 14e2976fbabd ("regulator: qcom_smd: Align probe function with rpmh-regulator") CC: Konrad Dybcio <konrad.dybcio@somainline.org> Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: kernel test robot <lkp@intel.com> Signed-off-by: Julia Lawall <julia.lawall@inria.fr> --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 112450df61b7373529b0fe4c122ad13b89d80a8a commit: 14e2976fbabdacb01335d7f91eeebbc89c67ddb1 regulator: qcom_smd: Align probe function with rpmh-regulator :::::: branch date: 13 hours ago :::::: commit date: 9 days ago qcom_smd-regulator.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/regulator/qcom_smd-regulator.c +++ b/drivers/regulator/qcom_smd-regulator.c @@ -1317,8 +1317,10 @@ static int rpm_reg_probe(struct platform for_each_available_child_of_node(dev->of_node, node) { vreg = devm_kzalloc(&pdev->dev, sizeof(*vreg), GFP_KERNEL); - if (!vreg) + if (!vreg) { + of_node_put(node); return -ENOMEM; + } ret = rpm_regulator_init_vreg(vreg, dev, node, rpm, vreg_data);
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@inria.fr> To: kbuild-all@lists.01.org Subject: [PATCH] regulator: qcom_smd: fix for_each_child.cocci warnings Date: Sat, 15 Jan 2022 12:11:38 +0100 [thread overview] Message-ID: <alpine.DEB.2.22.394.2201151210170.3051@hadrien> (raw) [-- Attachment #1: Type: text/plain, Size: 1546 bytes --] From: kernel test robot <lkp@intel.com> drivers/regulator/qcom_smd-regulator.c:1318:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return around line 1321. Semantic patch information: False positives can be due to function calls within the for_each loop that may encapsulate an of_node_put. Generated by: scripts/coccinelle/iterators/for_each_child.cocci Fixes: 14e2976fbabd ("regulator: qcom_smd: Align probe function with rpmh-regulator") CC: Konrad Dybcio <konrad.dybcio@somainline.org> Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: kernel test robot <lkp@intel.com> Signed-off-by: Julia Lawall <julia.lawall@inria.fr> --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 112450df61b7373529b0fe4c122ad13b89d80a8a commit: 14e2976fbabdacb01335d7f91eeebbc89c67ddb1 regulator: qcom_smd: Align probe function with rpmh-regulator :::::: branch date: 13 hours ago :::::: commit date: 9 days ago qcom_smd-regulator.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/regulator/qcom_smd-regulator.c +++ b/drivers/regulator/qcom_smd-regulator.c @@ -1317,8 +1317,10 @@ static int rpm_reg_probe(struct platform for_each_available_child_of_node(dev->of_node, node) { vreg = devm_kzalloc(&pdev->dev, sizeof(*vreg), GFP_KERNEL); - if (!vreg) + if (!vreg) { + of_node_put(node); return -ENOMEM; + } ret = rpm_regulator_init_vreg(vreg, dev, node, rpm, vreg_data);
next reply other threads:[~2022-01-15 11:11 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-15 11:11 Julia Lawall [this message] 2022-01-15 11:11 ` [PATCH] regulator: qcom_smd: fix for_each_child.cocci warnings Julia Lawall 2022-01-25 10:20 ` Mark Brown 2022-01-25 10:20 ` Mark Brown -- strict thread matches above, loose matches on Subject: below -- 2022-01-15 4:48 drivers/regulator/qcom_smd-regulator.c:1318:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return around line 1321 kernel test robot 2022-01-15 4:42 ` [PATCH] regulator: qcom_smd: fix for_each_child.cocci warnings kernel test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.DEB.2.22.394.2201151210170.3051@hadrien \ --to=julia.lawall@inria.fr \ --cc=agross@kernel.org \ --cc=bjorn.andersson@linaro.org \ --cc=broonie@kernel.org \ --cc=kbuild-all@lists.01.org \ --cc=konrad.dybcio@somainline.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.