From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Juergen Gross" <jgross@suse.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: [Xen-devel] [PATCH 1/2] x86emul: treat Hygon guests like AMD ones
Date: Mon, 16 Sep 2019 11:48:01 +0200 [thread overview]
Message-ID: <b05e5bf3-ed23-cb07-638e-05101210645c@suse.com> (raw)
In-Reply-To: <a44a8443-387d-fcb9-01b1-c8219f0e1e12@suse.com>
For some reason the Hygon enabling series left out the insn emulator.
Make appropriate adjustments wherever we've been special casing AMD.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/x86_emulate/x86_emulate.c
+++ b/xen/arch/x86/x86_emulate/x86_emulate.c
@@ -1995,7 +1995,8 @@ protmode_load_seg(
case x86_seg_tr:
goto raise_exn;
}
- if ( cp->x86_vendor != X86_VENDOR_AMD || !ops->read_segment ||
+ if ( !(cp->x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) ||
+ !ops->read_segment ||
ops->read_segment(seg, sreg, ctxt) != X86EMUL_OKAY )
memset(sreg, 0, sizeof(*sreg));
else
@@ -2122,7 +2123,8 @@ protmode_load_seg(
*/
bool wide = desc.b & 0x1000
? false : (desc.b & 0xf00) != 0xc00 &&
- cp->x86_vendor != X86_VENDOR_AMD
+ !(cp->x86_vendor &
+ (X86_VENDOR_AMD | X86_VENDOR_HYGON))
? mode_64bit() : ctxt->lma;
if ( wide )
@@ -2140,7 +2142,8 @@ protmode_load_seg(
default:
return rc;
}
- if ( !mode_64bit() && cp->x86_vendor == X86_VENDOR_AMD &&
+ if ( !mode_64bit() &&
+ (cp->x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) &&
(desc.b & 0xf00) != 0xc00 )
desc_hi.b = desc_hi.a = 0;
if ( (desc_hi.b & 0x00001f00) ||
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-09-16 9:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 9:44 [Xen-devel] [PATCH 0/2] x86emul: vendor specific treatment adjustments Jan Beulich
2019-09-16 9:48 ` Jan Beulich [this message]
2019-09-16 10:56 ` [Xen-devel] [PATCH 1/2] x86emul: treat Hygon guests like AMD ones Wei Liu
2019-09-17 16:33 ` Andrew Cooper
2019-09-16 9:48 ` [Xen-devel] [PATCH 2/2] x86emul: adjust MOVSXD source operand handling Jan Beulich
2019-09-17 17:17 ` Andrew Cooper
2019-09-18 6:34 ` Jan Beulich
2019-09-18 19:22 ` Andrew Cooper
2019-09-19 9:31 ` Jan Beulich
2019-10-01 19:44 ` Andrew Cooper
2019-10-02 7:07 ` Jan Beulich
2019-10-02 8:51 ` Andrew Cooper
2019-10-02 9:17 ` Jan Beulich
2019-10-04 12:32 ` Andrew Cooper
2019-09-18 5:31 ` [Xen-devel] [PATCH 0/2] x86emul: vendor specific treatment adjustments Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b05e5bf3-ed23-cb07-638e-05101210645c@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=jgross@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.