All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	jani.nikula@intel.com
Subject: [PATCH 6/7] drm/edid: make drm_edid_are_equal() static
Date: Mon,  8 Apr 2024 11:56:07 +0300	[thread overview]
Message-ID: <b07f2a7731c636dd34d02735c2601c3f2e65cd22.1712565984.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1712565984.git.jani.nikula@intel.com>

drm_edid_are_equal() is only used within drm_edid.c. Make it static. Do
not encourage more uses of struct edid.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/drm_edid.c | 3 +--
 include/drm/drm_edid.h     | 2 --
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 02f0a5fd819a..c11421d43b4b 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -1825,7 +1825,7 @@ static bool edid_block_is_zero(const void *edid)
  * This helper can be used during probing to determine if
  * edid had changed.
  */
-bool drm_edid_are_equal(const struct edid *edid1, const struct edid *edid2)
+static bool drm_edid_are_equal(const struct edid *edid1, const struct edid *edid2)
 {
 	int edid1_len, edid2_len;
 	bool edid1_present = edid1 != NULL;
@@ -1847,7 +1847,6 @@ bool drm_edid_are_equal(const struct edid *edid1, const struct edid *edid2)
 
 	return true;
 }
-EXPORT_SYMBOL(drm_edid_are_equal);
 
 enum edid_block_status {
 	EDID_BLOCK_OK = 0,
diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h
index 19814bb1103c..b5ee893001da 100644
--- a/include/drm/drm_edid.h
+++ b/include/drm/drm_edid.h
@@ -334,8 +334,6 @@ int drm_edid_to_speaker_allocation(const struct edid *edid, u8 **sadb);
 int drm_av_sync_delay(struct drm_connector *connector,
 		      const struct drm_display_mode *mode);
 
-bool drm_edid_are_equal(const struct edid *edid1, const struct edid *edid2);
-
 int
 drm_hdmi_avi_infoframe_from_display_mode(struct hdmi_avi_infoframe *frame,
 					 const struct drm_connector *connector,
-- 
2.39.2


  parent reply	other threads:[~2024-04-08  8:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-08  8:56 [PATCH 0/7] drm/edid: cleanups, resend Jani Nikula
2024-04-08  8:56 ` [PATCH 1/7] drm/displayid: move drm_displayid.h to drm_displayd_internal.h Jani Nikula
2024-04-08  8:56 ` [PATCH 2/7] drm/edid: move all internal declarations to drm_crtc_internal.h Jani Nikula
2024-04-08  8:56 ` [PATCH 3/7] drm/edid: group struct drm_edid based declarations together Jani Nikula
2024-04-08  8:56 ` [PATCH 4/7] drm/edid: rename drm_find_edid_extension() to drm_edid_find_extension() Jani Nikula
2024-04-08  8:56 ` [PATCH 5/7] drm/edid: avoid drm_edid_find_extension() internally Jani Nikula
2024-04-08  8:56 ` Jani Nikula [this message]
2024-04-08  8:56 ` [PATCH 7/7] drm/edid: make drm_edid_are_equal() more convenient for its single user Jani Nikula
2024-04-08 13:28 ` ✓ CI.Patch_applied: success for drm/edid: cleanups, resend Patchwork
2024-04-08 13:29 ` ✗ CI.checkpatch: warning " Patchwork
2024-04-08 13:30 ` ✓ CI.KUnit: success " Patchwork
2024-04-08 13:41 ` ✓ CI.Build: " Patchwork
2024-04-08 13:44 ` ✓ CI.Hooks: " Patchwork
2024-04-08 13:45 ` ✗ CI.checksparse: warning " Patchwork
2024-04-08 14:06 ` ✓ CI.BAT: success " Patchwork
2024-04-08 15:14 ` ✗ CI.FULL: failure " Patchwork
2024-04-08 18:12 ` ✗ Fi.CI.CHECKPATCH: warning " Patchwork
2024-04-08 18:12 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-04-08 18:17 ` ✓ Fi.CI.BAT: success " Patchwork
2024-04-10  2:11 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b07f2a7731c636dd34d02735c2601c3f2e65cd22.1712565984.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.