From: Joe Perches <joe@perches.com> To: Peter Jones <pjones@redhat.com> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 10/18] efifb: Remove pr_fmt duplicate logging prefixes Date: Thu, 10 May 2018 08:45:36 -0700 [thread overview] Message-ID: <b424c8d20ebdfe54adca5ceee86fd21e8a144f6e.1525964385.git.joe@perches.com> (raw) In-Reply-To: <cover.1525964381.git.joe@perches.com> Converting pr_fmt from a simple define to use KBUILD_MODNAME added some duplicate logging prefixes to existing uses. Remove them. Signed-off-by: Joe Perches <joe@perches.com> --- drivers/video/fbdev/efifb.c | 48 ++++++++++++++++++++++----------------------- 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c index 46a4484e3da7..3a11174f194b 100644 --- a/drivers/video/fbdev/efifb.c +++ b/drivers/video/fbdev/efifb.c @@ -250,13 +250,13 @@ static int efifb_probe(struct platform_device *dev) } else { /* We cannot make this fatal. Sometimes this comes from magic spaces our resource handlers simply don't know about */ - pr_warn("efifb: cannot reserve video memory at 0x%lx\n", + pr_warn("cannot reserve video memory at 0x%lx\n", efifb_fix.smem_start); } info = framebuffer_alloc(sizeof(u32) * 16, &dev->dev); if (!info) { - pr_err("efifb: cannot allocate framebuffer\n"); + pr_err("cannot allocate framebuffer\n"); err = -ENOMEM; goto err_release_mem; } @@ -277,23 +277,23 @@ static int efifb_probe(struct platform_device *dev) else info->screen_base = ioremap_wc(efifb_fix.smem_start, efifb_fix.smem_len); if (!info->screen_base) { - pr_err("efifb: abort, cannot ioremap video memory 0x%x @ 0x%lx\n", - efifb_fix.smem_len, efifb_fix.smem_start); + pr_err("abort, cannot ioremap video memory 0x%x @ 0x%lx\n", + efifb_fix.smem_len, efifb_fix.smem_start); err = -EIO; goto err_release_fb; } - pr_info("efifb: framebuffer at 0x%lx, using %dk, total %dk\n", - efifb_fix.smem_start, size_remap/1024, size_total/1024); - pr_info("efifb: mode is %dx%dx%d, linelength=%d, pages=%d\n", - efifb_defined.xres, efifb_defined.yres, - efifb_defined.bits_per_pixel, efifb_fix.line_length, - screen_info.pages); + pr_info("framebuffer at 0x%lx, using %dk, total %dk\n", + efifb_fix.smem_start, size_remap/1024, size_total/1024); + pr_info("mode is %dx%dx%d, linelength=%d, pages=%d\n", + efifb_defined.xres, efifb_defined.yres, + efifb_defined.bits_per_pixel, efifb_fix.line_length, + screen_info.pages); efifb_defined.xres_virtual = efifb_defined.xres; efifb_defined.yres_virtual = efifb_fix.smem_len / efifb_fix.line_length; - pr_info("efifb: scrolling: redraw\n"); + pr_info("scrolling: redraw\n"); efifb_defined.yres_virtual = efifb_defined.yres; /* some dummy values for timing to make fbset happy */ @@ -311,17 +311,15 @@ static int efifb_probe(struct platform_device *dev) efifb_defined.transp.offset = screen_info.rsvd_pos; efifb_defined.transp.length = screen_info.rsvd_size; - pr_info("efifb: %s: " - "size=%d:%d:%d:%d, shift=%d:%d:%d:%d\n", - "Truecolor", - screen_info.rsvd_size, - screen_info.red_size, - screen_info.green_size, - screen_info.blue_size, - screen_info.rsvd_pos, - screen_info.red_pos, - screen_info.green_pos, - screen_info.blue_pos); + pr_info("Truecolor: size=%d:%d:%d:%d, shift=%d:%d:%d:%d\n", + screen_info.rsvd_size, + screen_info.red_size, + screen_info.green_size, + screen_info.blue_size, + screen_info.rsvd_pos, + screen_info.red_pos, + screen_info.green_pos, + screen_info.blue_pos); efifb_fix.ypanstep = 0; efifb_fix.ywrapstep = 0; @@ -350,17 +348,17 @@ static int efifb_probe(struct platform_device *dev) err = sysfs_create_groups(&dev->dev.kobj, efifb_groups); if (err) { - pr_err("efifb: cannot add sysfs attrs\n"); + pr_err("cannot add sysfs attrs\n"); goto err_unmap; } err = fb_alloc_cmap(&info->cmap, 256, 0); if (err < 0) { - pr_err("efifb: cannot allocate colormap\n"); + pr_err("cannot allocate colormap\n"); goto err_groups; } err = register_framebuffer(info); if (err < 0) { - pr_err("efifb: cannot register framebuffer\n"); + pr_err("cannot register framebuffer\n"); goto err_fb_dealoc; } fb_info(info, "%s frame buffer device\n", info->fix.id); -- 2.15.0
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com> To: Peter Jones <pjones@redhat.com> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 10/18] efifb: Remove pr_fmt duplicate logging prefixes Date: Thu, 10 May 2018 15:45:36 +0000 [thread overview] Message-ID: <b424c8d20ebdfe54adca5ceee86fd21e8a144f6e.1525964385.git.joe@perches.com> (raw) In-Reply-To: <cover.1525964381.git.joe@perches.com> Converting pr_fmt from a simple define to use KBUILD_MODNAME added some duplicate logging prefixes to existing uses. Remove them. Signed-off-by: Joe Perches <joe@perches.com> --- drivers/video/fbdev/efifb.c | 48 ++++++++++++++++++++++----------------------- 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c index 46a4484e3da7..3a11174f194b 100644 --- a/drivers/video/fbdev/efifb.c +++ b/drivers/video/fbdev/efifb.c @@ -250,13 +250,13 @@ static int efifb_probe(struct platform_device *dev) } else { /* We cannot make this fatal. Sometimes this comes from magic spaces our resource handlers simply don't know about */ - pr_warn("efifb: cannot reserve video memory at 0x%lx\n", + pr_warn("cannot reserve video memory at 0x%lx\n", efifb_fix.smem_start); } info = framebuffer_alloc(sizeof(u32) * 16, &dev->dev); if (!info) { - pr_err("efifb: cannot allocate framebuffer\n"); + pr_err("cannot allocate framebuffer\n"); err = -ENOMEM; goto err_release_mem; } @@ -277,23 +277,23 @@ static int efifb_probe(struct platform_device *dev) else info->screen_base = ioremap_wc(efifb_fix.smem_start, efifb_fix.smem_len); if (!info->screen_base) { - pr_err("efifb: abort, cannot ioremap video memory 0x%x @ 0x%lx\n", - efifb_fix.smem_len, efifb_fix.smem_start); + pr_err("abort, cannot ioremap video memory 0x%x @ 0x%lx\n", + efifb_fix.smem_len, efifb_fix.smem_start); err = -EIO; goto err_release_fb; } - pr_info("efifb: framebuffer at 0x%lx, using %dk, total %dk\n", - efifb_fix.smem_start, size_remap/1024, size_total/1024); - pr_info("efifb: mode is %dx%dx%d, linelength=%d, pages=%d\n", - efifb_defined.xres, efifb_defined.yres, - efifb_defined.bits_per_pixel, efifb_fix.line_length, - screen_info.pages); + pr_info("framebuffer at 0x%lx, using %dk, total %dk\n", + efifb_fix.smem_start, size_remap/1024, size_total/1024); + pr_info("mode is %dx%dx%d, linelength=%d, pages=%d\n", + efifb_defined.xres, efifb_defined.yres, + efifb_defined.bits_per_pixel, efifb_fix.line_length, + screen_info.pages); efifb_defined.xres_virtual = efifb_defined.xres; efifb_defined.yres_virtual = efifb_fix.smem_len / efifb_fix.line_length; - pr_info("efifb: scrolling: redraw\n"); + pr_info("scrolling: redraw\n"); efifb_defined.yres_virtual = efifb_defined.yres; /* some dummy values for timing to make fbset happy */ @@ -311,17 +311,15 @@ static int efifb_probe(struct platform_device *dev) efifb_defined.transp.offset = screen_info.rsvd_pos; efifb_defined.transp.length = screen_info.rsvd_size; - pr_info("efifb: %s: " - "size=%d:%d:%d:%d, shift=%d:%d:%d:%d\n", - "Truecolor", - screen_info.rsvd_size, - screen_info.red_size, - screen_info.green_size, - screen_info.blue_size, - screen_info.rsvd_pos, - screen_info.red_pos, - screen_info.green_pos, - screen_info.blue_pos); + pr_info("Truecolor: size=%d:%d:%d:%d, shift=%d:%d:%d:%d\n", + screen_info.rsvd_size, + screen_info.red_size, + screen_info.green_size, + screen_info.blue_size, + screen_info.rsvd_pos, + screen_info.red_pos, + screen_info.green_pos, + screen_info.blue_pos); efifb_fix.ypanstep = 0; efifb_fix.ywrapstep = 0; @@ -350,17 +348,17 @@ static int efifb_probe(struct platform_device *dev) err = sysfs_create_groups(&dev->dev.kobj, efifb_groups); if (err) { - pr_err("efifb: cannot add sysfs attrs\n"); + pr_err("cannot add sysfs attrs\n"); goto err_unmap; } err = fb_alloc_cmap(&info->cmap, 256, 0); if (err < 0) { - pr_err("efifb: cannot allocate colormap\n"); + pr_err("cannot allocate colormap\n"); goto err_groups; } err = register_framebuffer(info); if (err < 0) { - pr_err("efifb: cannot register framebuffer\n"); + pr_err("cannot register framebuffer\n"); goto err_fb_dealoc; } fb_info(info, "%s frame buffer device\n", info->fix.id); -- 2.15.0
next prev parent reply other threads:[~2018-05-10 15:46 UTC|newest] Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-10 15:45 [PATCH 00/18] Convert default pr_fmt from empty to KBUILD_MODNAME Joe Perches 2018-05-10 15:45 ` Joe Perches 2018-05-10 15:45 ` Joe Perches 2018-05-10 15:45 ` [PATCH 01/18] kernel: Use pr_fmt Joe Perches 2018-05-10 16:14 ` Paul Moore 2018-05-10 19:05 ` Kees Cook 2018-05-13 19:17 ` Jessica Yu 2018-05-14 13:38 ` Masami Hiramatsu 2018-05-14 18:06 ` Paul E. McKenney 2018-05-14 18:59 ` Paul Moore 2018-05-10 15:45 ` [PATCH 02/18] lib: " Joe Perches 2018-05-10 15:45 ` [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME Joe Perches 2018-05-10 16:28 ` Steven Rostedt 2018-05-11 21:39 ` [PATCH] ring_buffer: Update logging to use single line output Joe Perches 2018-07-12 2:57 ` Steven Rostedt 2018-07-12 4:42 ` Joe Perches 2018-07-12 13:00 ` Steven Rostedt 2018-05-11 1:51 ` [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME Sergey Senozhatsky 2018-05-11 1:57 ` Joe Perches 2018-05-11 2:12 ` Joe Perches 2018-05-11 2:24 ` Sergey Senozhatsky 2018-05-11 2:23 ` Sergey Senozhatsky 2018-05-11 2:33 ` Joe Perches 2018-05-11 2:41 ` Sergey Senozhatsky 2018-05-11 2:57 ` Joe Perches 2018-05-18 8:42 ` Petr Mladek 2018-05-18 9:10 ` Joe Perches 2018-05-18 20:29 ` Andy Shevchenko 2018-05-19 2:05 ` Joe Perches 2018-05-19 18:27 ` Andy Shevchenko 2018-05-10 15:45 ` [PATCH 04/18] x86: Remove pr_fmt duplicate logging prefixes Joe Perches 2018-05-13 19:27 ` [tip:x86/cleanups] " tip-bot for Joe Perches 2018-05-17 18:27 ` Borislav Petkov 2018-05-17 18:43 ` Joe Perches 2018-05-17 19:14 ` Thomas Gleixner 2019-02-21 6:25 ` Bjorn Helgaas 2018-05-10 15:45 ` [PATCH 05/18] x86/mtrr: Rename main.c to mtrr.c and remove duplicate prefixes Joe Perches 2018-05-13 19:28 ` [tip:x86/cleanups] " tip-bot for Joe Perches 2018-05-10 15:45 ` [PATCH 06/18] net: Remove pr_fmt duplicate logging prefixes Joe Perches 2018-05-10 15:45 ` [PATCH 07/18] blk-mq: " Joe Perches 2018-05-10 15:45 ` [PATCH 08/18] random: " Joe Perches 2018-05-10 15:45 ` [PATCH 09/18] ptp: " Joe Perches 2018-05-10 19:35 ` Richard Cochran 2018-05-10 15:45 ` Joe Perches [this message] 2018-05-10 15:45 ` [PATCH 10/18] efifb: " Joe Perches 2018-05-10 15:45 ` [PATCH 11/18] proc: " Joe Perches 2018-05-10 15:45 ` [PATCH 12/18] uprobes: " Joe Perches 2018-05-10 15:45 ` [PATCH 13/18] printk: " Joe Perches 2018-05-11 1:54 ` Sergey Senozhatsky 2018-05-18 8:43 ` Petr Mladek 2018-05-10 15:45 ` [PATCH 14/18] lib/mpi: " Joe Perches 2018-05-10 15:45 ` [PATCH 15/18] security: " Joe Perches 2018-05-10 15:45 ` Joe Perches 2018-05-10 16:15 ` Paul Moore 2018-05-10 16:15 ` Paul Moore 2018-05-10 15:45 ` [PATCH 16/18] aoe: " Joe Perches 2018-05-10 15:45 ` [PATCH 17/18] security: encrypted-keys: " Joe Perches 2018-05-10 15:45 ` Joe Perches 2018-05-10 15:45 ` Joe Perches 2018-05-10 18:09 ` James Morris 2018-05-10 18:09 ` James Morris 2018-05-10 18:09 ` James Morris 2018-05-10 15:45 ` [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output Joe Perches 2018-05-14 20:29 ` Paul E. McKenney 2018-05-14 20:37 ` Andy Shevchenko 2018-05-14 21:08 ` Paul E. McKenney 2018-05-14 20:52 ` Randy Dunlap 2018-05-14 21:05 ` Paul E. McKenney 2018-05-14 21:41 ` Joe Perches 2018-05-14 22:24 ` Paul E. McKenney 2018-05-14 22:54 ` Joe Perches 2018-05-14 23:58 ` Paul E. McKenney 2018-05-15 0:23 ` Joe Perches 2018-05-15 0:32 ` Paul E. McKenney 2018-05-15 1:22 ` Joe Perches 2018-05-15 3:41 ` Paul E. McKenney 2018-05-15 19:28 ` Paul E. McKenney 2018-05-15 21:11 ` Joe Perches 2018-05-15 21:23 ` Paul E. McKenney
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b424c8d20ebdfe54adca5ceee86fd21e8a144f6e.1525964385.git.joe@perches.com \ --to=joe@perches.com \ --cc=b.zolnierkie@samsung.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pjones@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.