From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> To: Michal Simek <michal.simek@amd.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jay Buddhabhatti <jay.buddhabhatti@amd.com>, Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>, Linus Walleij <linus.walleij@linaro.org>, Nava kishore Manne <nava.kishore.manne@amd.com>, Rajan Vaja <rajan.vaja@xilinx.com>, Rob Herring <robh@kernel.org>, Dhaval Shah <dhaval.r.shah@amd.com>, Marek Vasut <marex@denx.de> Cc: kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 11/11] firmware: zynqmp: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 17:26:35 +0100 [thread overview] Message-ID: <b5a82472a6d61608c2cd7728ca364f6c88a821c3.1703693980.git.u.kleine-koenig@pengutronix.de> (raw) In-Reply-To: <cover.1703693980.git.u.kleine-koenig@pengutronix.de> The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/firmware/xilinx/zynqmp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c index a55dfd9bae6b..73cae6ef83ec 100644 --- a/drivers/firmware/xilinx/zynqmp.c +++ b/drivers/firmware/xilinx/zynqmp.c @@ -1929,7 +1929,7 @@ static int zynqmp_firmware_probe(struct platform_device *pdev) return of_platform_populate(dev->of_node, NULL, NULL, dev); } -static int zynqmp_firmware_remove(struct platform_device *pdev) +static void zynqmp_firmware_remove(struct platform_device *pdev) { struct pm_api_feature_data *feature_data; struct hlist_node *tmp; @@ -1944,8 +1944,6 @@ static int zynqmp_firmware_remove(struct platform_device *pdev) } platform_device_unregister(em_dev); - - return 0; } static const struct of_device_id zynqmp_firmware_of_match[] = { @@ -1962,6 +1960,6 @@ static struct platform_driver zynqmp_firmware_driver = { .dev_groups = zynqmp_firmware_groups, }, .probe = zynqmp_firmware_probe, - .remove = zynqmp_firmware_remove, + .remove_new = zynqmp_firmware_remove, }; module_platform_driver(zynqmp_firmware_driver); -- 2.43.0
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> To: Michal Simek <michal.simek@amd.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jay Buddhabhatti <jay.buddhabhatti@amd.com>, Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>, Linus Walleij <linus.walleij@linaro.org>, Nava kishore Manne <nava.kishore.manne@amd.com>, Rajan Vaja <rajan.vaja@xilinx.com>, Rob Herring <robh@kernel.org>, Dhaval Shah <dhaval.r.shah@amd.com>, Marek Vasut <marex@denx.de> Cc: kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 11/11] firmware: zynqmp: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 17:26:35 +0100 [thread overview] Message-ID: <b5a82472a6d61608c2cd7728ca364f6c88a821c3.1703693980.git.u.kleine-koenig@pengutronix.de> (raw) In-Reply-To: <cover.1703693980.git.u.kleine-koenig@pengutronix.de> The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/firmware/xilinx/zynqmp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c index a55dfd9bae6b..73cae6ef83ec 100644 --- a/drivers/firmware/xilinx/zynqmp.c +++ b/drivers/firmware/xilinx/zynqmp.c @@ -1929,7 +1929,7 @@ static int zynqmp_firmware_probe(struct platform_device *pdev) return of_platform_populate(dev->of_node, NULL, NULL, dev); } -static int zynqmp_firmware_remove(struct platform_device *pdev) +static void zynqmp_firmware_remove(struct platform_device *pdev) { struct pm_api_feature_data *feature_data; struct hlist_node *tmp; @@ -1944,8 +1944,6 @@ static int zynqmp_firmware_remove(struct platform_device *pdev) } platform_device_unregister(em_dev); - - return 0; } static const struct of_device_id zynqmp_firmware_of_match[] = { @@ -1962,6 +1960,6 @@ static struct platform_driver zynqmp_firmware_driver = { .dev_groups = zynqmp_firmware_groups, }, .probe = zynqmp_firmware_probe, - .remove = zynqmp_firmware_remove, + .remove_new = zynqmp_firmware_remove, }; module_platform_driver(zynqmp_firmware_driver); -- 2.43.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-27 16:27 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-12-27 16:26 [PATCH 00/11] firmware: Convert to platform remove callback returning void Uwe Kleine-König 2023-12-27 16:26 ` Uwe Kleine-König 2023-12-27 16:26 ` [PATCH 01/11] firmware: arm_scmi: " Uwe Kleine-König 2023-12-27 16:26 ` Uwe Kleine-König 2023-12-27 16:26 ` [PATCH 02/11] firmware: arm_scpi: " Uwe Kleine-König 2023-12-27 16:26 ` Uwe Kleine-König 2023-12-27 16:26 ` [PATCH 03/11] firmware: coreboot_table: " Uwe Kleine-König 2023-12-28 3:12 ` Tzung-Bi Shih 2023-12-27 16:26 ` [PATCH 04/11] firmware: imx-dsp: " Uwe Kleine-König 2023-12-27 16:26 ` Uwe Kleine-König 2023-12-27 16:26 ` [PATCH 05/11] firmware: mtk-adsp-ipc: " Uwe Kleine-König 2023-12-27 16:26 ` Uwe Kleine-König 2023-12-27 16:26 ` [PATCH 06/11] firmware: qemu_fw_cfg: " Uwe Kleine-König 2023-12-27 17:07 ` Philippe Mathieu-Daudé 2023-12-27 20:46 ` Michael S. Tsirkin 2023-12-27 16:26 ` [PATCH 07/11] firmware: raspberrypi: " Uwe Kleine-König 2023-12-27 16:26 ` Uwe Kleine-König 2023-12-27 16:43 ` Florian Fainelli 2023-12-27 16:43 ` Florian Fainelli 2023-12-27 16:26 ` [PATCH 08/11] firmware: stratix10-rsu: " Uwe Kleine-König 2024-01-04 12:22 ` Dinh Nguyen 2023-12-27 16:26 ` [PATCH 09/11] firmware: stratix10-svc: " Uwe Kleine-König 2024-01-04 12:22 ` Dinh Nguyen 2023-12-27 16:26 ` [PATCH 10/11] firmware: turris-mox-rwtm: " Uwe Kleine-König 2023-12-28 15:32 ` Marek Behún 2023-12-27 16:26 ` Uwe Kleine-König [this message] 2023-12-27 16:26 ` [PATCH 11/11] firmware: zynqmp: " Uwe Kleine-König 2024-01-02 10:00 ` Michal Simek 2024-01-02 10:00 ` Michal Simek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b5a82472a6d61608c2cd7728ca364f6c88a821c3.1703693980.git.u.kleine-koenig@pengutronix.de \ --to=u.kleine-koenig@pengutronix.de \ --cc=dhaval.r.shah@amd.com \ --cc=gregkh@linuxfoundation.org \ --cc=jay.buddhabhatti@amd.com \ --cc=kernel@pengutronix.de \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marex@denx.de \ --cc=michal.simek@amd.com \ --cc=nava.kishore.manne@amd.com \ --cc=rajan.vaja@xilinx.com \ --cc=robh@kernel.org \ --cc=sai.krishna.potthuri@amd.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.