All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Cc: Qu Wenruo <wqu@suse.com>
Subject: [PATCH v2 03/13] btrfs-progs: check: don't walk down non fs-trees for qgroup check
Date: Wed, 10 Nov 2021 15:07:54 -0500	[thread overview]
Message-ID: <b8339a9e3e5bd4c20ab51df2dd32a3d550351e12.1636574767.git.josef@toxicpanda.com> (raw)
In-Reply-To: <cover.1636574767.git.josef@toxicpanda.com>

We will lookup implied refs for every root id for every block that we
find when verifying qgroups, but we don't need to worry about non
fstrees, so skip them here.

Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
---
 check/qgroup-verify.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/check/qgroup-verify.c b/check/qgroup-verify.c
index 14645c85..a514fee1 100644
--- a/check/qgroup-verify.c
+++ b/check/qgroup-verify.c
@@ -765,6 +765,10 @@ static int add_refs_for_implied(struct btrfs_fs_info *info, u64 bytenr,
 	struct btrfs_root *root;
 	struct btrfs_key key;
 
+	/* If this is a global tree skip it. */
+	if (!is_fstree(root_id))
+		return 0;
+
 	/* Tree reloc tree doesn't contribute qgroup, skip it */
 	if (root_id == BTRFS_TREE_RELOC_OBJECTID)
 		return 0;
-- 
2.26.3


  parent reply	other threads:[~2021-11-10 20:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-10 20:07 [PATCH v2 00/13] btrfs-progs: extent tree v2 global root support prep work Josef Bacik
2021-11-10 20:07 ` [PATCH v2 01/13] btrfs-progs: check: fix set_extent_dirty range Josef Bacik
2021-11-10 20:07 ` [PATCH v2 02/13] btrfs-progs: simplify btrfs_make_block_group Josef Bacik
2021-11-10 20:07 ` Josef Bacik [this message]
2021-11-10 20:07 ` [PATCH v2 04/13] btrfs-progs: filesystem-show: close ctree once we're done Josef Bacik
2021-11-10 20:07 ` [PATCH v2 05/13] btrfs-progs: add a helper for setting up a root node Josef Bacik
2021-11-10 20:07 ` [PATCH v2 06/13] btrfs-progs: btrfs-shared: stop passing root to csum related functions Josef Bacik
2021-11-15 18:54   ` David Sterba
2021-11-10 20:07 ` [PATCH v2 07/13] btrfs-progs: check: stop passing csum root around Josef Bacik
2021-11-10 20:07 ` [PATCH v2 08/13] btrfs-progs: stop accessing ->csum_root directly Josef Bacik
2021-11-10 20:08 ` [PATCH v2 09/13] btrfs-progs: image: keep track of seen blocks when walking trees Josef Bacik
2021-11-10 20:08 ` [PATCH v2 10/13] btrfs-progs: common: move btrfs_fix_block_accounting to repair.c Josef Bacik
2021-11-10 20:08 ` [PATCH v2 11/13] btrfs-progs: check: abstract out the used marking helpers Josef Bacik
2021-11-10 20:08 ` [PATCH v2 12/13] btrfs-progs: check: move btrfs_mark_used_tree_blocks to common Josef Bacik
2021-11-10 20:08 ` [PATCH v2 13/13] btrfs-progs: mark reloc roots as used Josef Bacik
2021-11-10 20:11 ` [PATCH v2 00/13] btrfs-progs: extent tree v2 global root support prep work Josef Bacik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8339a9e3e5bd4c20ab51df2dd32a3d550351e12.1636574767.git.josef@toxicpanda.com \
    --to=josef@toxicpanda.com \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.