From: наб <nabijaczleweli@nabijaczleweli.xyz>
To: Harald van Dijk <harald@gigawatt.nl>, dash@vger.kernel.org
Subject: [PATCH 4/6] fc: don't require an argument
Date: Tue, 7 Feb 2023 20:33:38 +0100 [thread overview]
Message-ID: <ba7012f7f2cf644c79160b6f1361486d46d9cf9d.1675798292.git.nabijaczleweli@nabijaczleweli.xyz> (raw)
In-Reply-To: <ab3fbcc2-1a9a-136b-0b02-a5ea31fe02c5@gigawatt.nl>
[-- Attachment #1: Type: text/plain, Size: 1312 bytes --]
This is already handled correctly (per POSIX) below:
When the synopsis form with -s is used:
If first is omitted, the previous command shall be used.
For the synopsis forms without -s:
If first and last are both omitted, the previous 16 commands
shall be listed or the previous single command shall be edited
(based on the -l option).
Test log:
$ ls
autogen.sh ChangeLog ...
$ id
uid=1000(nabijaczleweli) gid=100(users) groups=100(users)
$ who
nabijaczleweli pts/2 2023-02-07 18:36 (192.168.1.109)
$ fc
4
,
who
q
nabijaczleweli pts/2 2023-02-07 18:36 (192.168.1.109)
$ fc -l
1 ls
2 id
3 who
4 fc
$ fc -s
fc -l
1 ls
2 id
3 who
4 fc
5 fc -l
Reported-by: Harald van Dijk <harald@gigawatt.nl>
Reported-in: https://marc.info/?l=dash&m=154707728009743&w=2
---
src/histedit.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/histedit.c b/src/histedit.c
index 24631ca..f10e5ab 100644
--- a/src/histedit.c
+++ b/src/histedit.c
@@ -212,9 +212,6 @@ histcmd(int argc, char **argv)
if (hist == NULL)
sh_error("history not active");
- if (argc == 1)
- sh_error("missing history argument");
-
#ifdef __GLIBC__
optind = 0;
#else
--
2.30.2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-02-07 19:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-08 16:10 dash repeats first line in history entry forever with fc -s наб
2023-01-08 16:31 ` Harald van Dijk
2023-01-08 17:01 ` Christoph Anton Mitterer
2023-02-07 19:33 ` [PATCH 1/6] fc -s: refuse multiple events instead of ignoring наб
2024-04-06 8:55 ` Herbert Xu
2023-02-07 19:33 ` [PATCH 2/6] fc -s: don't loop forever when executing the latest entry наб
2023-02-07 19:33 ` [PATCH 3/6] fc: only parse old=new if -s, per POSIX наб
2023-02-07 19:33 ` наб [this message]
2023-02-07 19:33 ` [PATCH 5/6] fc: fix "fc -3" extension on glibc наб
2023-02-07 19:33 ` [PATCH 6/6] fc: don't include the current fc in out-of-range last наб
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba7012f7f2cf644c79160b6f1361486d46d9cf9d.1675798292.git.nabijaczleweli@nabijaczleweli.xyz \
--to=nabijaczleweli@nabijaczleweli.xyz \
--cc=dash@vger.kernel.org \
--cc=harald@gigawatt.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.