All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Cc: kernel-team@fb.com, Pavel Begunkov <asml.silence@gmail.com>
Subject: [PATCH for-next v4 5/6] bio: shrink max number of pcpu cached bios
Date: Wed,  2 Nov 2022 15:18:23 +0000	[thread overview]
Message-ID: <bc198e8efb27d8c740d80c8ce477432729075096.1667384020.git.asml.silence@gmail.com> (raw)
In-Reply-To: <cover.1667384020.git.asml.silence@gmail.com>

The downside of the bio pcpu cache is that bios of a cpu will be never
freed unless there is new I/O issued from that cpu. We currently keep
max 512 bios, which feels too much, half it.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
 block/bio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/bio.c b/block/bio.c
index d989e45583ac..6277a2f68ab8 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -27,7 +27,7 @@
 
 #define ALLOC_CACHE_THRESHOLD	16
 #define ALLOC_CACHE_SLACK	64
-#define ALLOC_CACHE_MAX		512
+#define ALLOC_CACHE_MAX		256
 
 struct bio_alloc_cache {
 	struct bio		*free_list;
-- 
2.38.0


  parent reply	other threads:[~2022-11-02 15:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02 15:18 [PATCH for-next v4 0/6] implement pcpu bio caching for IRQ I/O Pavel Begunkov
2022-11-02 15:18 ` [PATCH for-next v4 1/6] mempool: introduce mempool_is_saturated Pavel Begunkov
2022-11-02 15:18 ` [PATCH for-next v4 2/6] bio: don't rob starving biosets of bios Pavel Begunkov
2022-11-02 15:18 ` [PATCH for-next v4 3/6] bio: split pcpu cache part of bio_put into a helper Pavel Begunkov
2022-11-02 15:18 ` [PATCH for-next v4 4/6] bio: add pcpu caching for non-polling bio_put Pavel Begunkov
2022-11-02 15:18 ` Pavel Begunkov [this message]
2022-11-02 15:18 ` [PATCH for-next v4 6/6] io_uring/rw: enable bio caches for IRQ rw Pavel Begunkov
2022-11-16 18:49 ` [PATCH for-next v4 0/6] implement pcpu bio caching for IRQ I/O Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc198e8efb27d8c740d80c8ce477432729075096.1667384020.git.asml.silence@gmail.com \
    --to=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=kernel-team@fb.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.