All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Elijah Newren <newren@gmail.com>, Elijah Newren <newren@gmail.com>
Subject: [PATCH 08/12] pkt-line.h: remove unnecessary include
Date: Sun, 03 Dec 2023 06:41:17 +0000	[thread overview]
Message-ID: <bc1fe09e996374868e8381a62ee5882df6b91223.1701585683.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1617.git.1701585682.gitgitgadget@gmail.com>

From: Elijah Newren <newren@gmail.com>

The unnecessary include in the header transitively pulled in some
other headers actually needed by source files, though.  Have those
source files explicitly include the headers they need.

Signed-off-by: Elijah Newren <newren@gmail.com>
---
 pkt-line.c               | 1 +
 pkt-line.h               | 1 -
 t/helper/test-pkt-line.c | 1 +
 3 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/pkt-line.c b/pkt-line.c
index af83a19f4df..236dd3a3ee1 100644
--- a/pkt-line.c
+++ b/pkt-line.c
@@ -4,6 +4,7 @@
 #include "gettext.h"
 #include "hex.h"
 #include "run-command.h"
+#include "sideband.h"
 #include "trace.h"
 #include "write-or-die.h"
 
diff --git a/pkt-line.h b/pkt-line.h
index 954eec87197..aedef56286f 100644
--- a/pkt-line.h
+++ b/pkt-line.h
@@ -2,7 +2,6 @@
 #define PKTLINE_H
 
 #include "strbuf.h"
-#include "sideband.h"
 
 /*
  * Write a packetized stream, where each line is preceded by
diff --git a/t/helper/test-pkt-line.c b/t/helper/test-pkt-line.c
index f4d134a1452..77e99c37df0 100644
--- a/t/helper/test-pkt-line.c
+++ b/t/helper/test-pkt-line.c
@@ -1,6 +1,7 @@
 #include "git-compat-util.h"
 #include "test-tool.h"
 #include "pkt-line.h"
+#include "sideband.h"
 #include "write-or-die.h"
 
 static void pack_line(const char *line)
-- 
gitgitgadget


  parent reply	other threads:[~2023-12-03  6:41 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-03  6:41 [PATCH 00/12] Additional header cleanups (removing unnecessary includes) Elijah Newren via GitGitGadget
2023-12-03  6:41 ` [PATCH 01/12] treewide: remove unnecessary includes from header files Elijah Newren via GitGitGadget
2023-12-03  6:41 ` [PATCH 02/12] treewide: remove unnecessary includes in source files Elijah Newren via GitGitGadget
2023-12-03 13:15   ` Junio C Hamano
2023-12-20 19:34     ` Junio C Hamano
2023-12-20 20:42       ` Elijah Newren
2023-12-03  6:41 ` [PATCH 03/12] archive.h: remove unnecessary include Elijah Newren via GitGitGadget
2023-12-03  6:41 ` [PATCH 04/12] blame.h: remove unnecessary includes Elijah Newren via GitGitGadget
2023-12-03  6:41 ` [PATCH 05/12] fsmonitor--daemon.h: " Elijah Newren via GitGitGadget
2023-12-03  6:41 ` [PATCH 06/12] http.h: remove unnecessary include Elijah Newren via GitGitGadget
2023-12-03  6:41 ` [PATCH 07/12] line-log.h: " Elijah Newren via GitGitGadget
2023-12-03  6:41 ` Elijah Newren via GitGitGadget [this message]
2023-12-03  6:41 ` [PATCH 09/12] submodule-config.h: " Elijah Newren via GitGitGadget
2023-12-03  6:41 ` [PATCH 10/12] trace2/tr2_tls.h: " Elijah Newren via GitGitGadget
2023-12-03  6:41 ` [PATCH 11/12] treewide: add direct includes currently only pulled in transitively Elijah Newren via GitGitGadget
2023-12-03  6:41 ` [PATCH 12/12] treewide: remove unnecessary includes in source files Elijah Newren via GitGitGadget
2023-12-23 17:14 ` [PATCH v2 00/12] Additional header cleanups (removing unnecessary includes) Elijah Newren via GitGitGadget
2023-12-23 17:14   ` [PATCH v2 01/12] treewide: remove unnecessary includes from header files Elijah Newren via GitGitGadget
2023-12-23 17:14   ` [PATCH v2 02/12] treewide: remove unnecessary includes in source files Elijah Newren via GitGitGadget
2023-12-23 17:14   ` [PATCH v2 03/12] archive.h: remove unnecessary include Elijah Newren via GitGitGadget
2023-12-23 17:14   ` [PATCH v2 04/12] blame.h: remove unnecessary includes Elijah Newren via GitGitGadget
2023-12-23 17:14   ` [PATCH v2 05/12] fsmonitor--daemon.h: " Elijah Newren via GitGitGadget
2023-12-23 17:14   ` [PATCH v2 06/12] http.h: remove unnecessary include Elijah Newren via GitGitGadget
2023-12-23 17:14   ` [PATCH v2 07/12] line-log.h: " Elijah Newren via GitGitGadget
2023-12-23 17:14   ` [PATCH v2 08/12] pkt-line.h: " Elijah Newren via GitGitGadget
2023-12-23 17:14   ` [PATCH v2 09/12] submodule-config.h: " Elijah Newren via GitGitGadget
2023-12-23 17:14   ` [PATCH v2 10/12] trace2/tr2_tls.h: " Elijah Newren via GitGitGadget
2023-12-23 17:14   ` [PATCH v2 11/12] treewide: add direct includes currently only pulled in transitively Elijah Newren via GitGitGadget
2023-12-23 17:15   ` [PATCH v2 12/12] treewide: remove unnecessary includes in source files Elijah Newren via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc1fe09e996374868e8381a62ee5882df6b91223.1701585683.git.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.