From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>,
LKML <linux-kernel@vger.kernel.org>,
Matthias Kaehlcke <mka@chromium.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH 1/1] arm64: dts: qcom: sc7280: Add device tree for herobrine evoker
Date: Tue, 30 Aug 2022 19:50:25 +0300 [thread overview]
Message-ID: <bc707091-3417-bc89-70bf-3a2496a11196@linaro.org> (raw)
In-Reply-To: <CAD=FV=VorVNKHgybGAH=dD5ob+1RYoguczycjOYu-5VPu=9Jkw@mail.gmail.com>
On 30/08/2022 19:10, Doug Anderson wrote:
> Hi,
>
> On Tue, Aug 30, 2022 at 2:33 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>>> +};
>>> +
>>> +/*
>>> + * ADDITIONS TO FIXED REGULATORS DEFINED IN PARENT DEVICE TREE FILES
>>
>> What does it mean and why it's SCREAMING?
>>> + *
>>> + * Sort order matches the order in the parent files (parents before children).
>>
>> Why? Sorting should be rather alphabetical.
>
> We've had this discussion on the lists in the past. See, for instance:
>
> https://lore.kernel.org/r/CAD=FV=U2C1W+JHWyGRfyRB=WiPKLYvtjO90UDoJ9p+Xwe09+ow@mail.gmail.com/
Good explanation, such sorting rule is quite nice. The part about
regulators is still a bit confusing, I guess it is about some other
pieces in some other place? But isn't this kind of obvious from
including other DTSI?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-30 16:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 5:33 [PATCH 0/1] Add a new board device tree named 'evoker' for herobrine variant Sheng-Liang Pan
2022-08-30 5:33 ` [PATCH 1/1] arm64: dts: qcom: sc7280: Add device tree for herobrine evoker Sheng-Liang Pan
2022-08-30 9:32 ` Krzysztof Kozlowski
2022-08-30 16:10 ` Doug Anderson
2022-08-30 16:50 ` Krzysztof Kozlowski [this message]
2022-08-30 17:13 ` Doug Anderson
2022-08-30 9:33 ` Krzysztof Kozlowski
2022-08-30 17:23 ` [PATCH 0/1] Add a new board device tree named 'evoker' for herobrine variant Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc707091-3417-bc89-70bf-3a2496a11196@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=sheng-liang.pan@quanta.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.