All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robin Meijboom <robin@meijboom.info>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
	Michal Marek <michal.lkml@markovi.net>
Cc: linux-kbuild@vger.kernel.org,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH] objtool: remove generated files with make clean
Date: Thu, 14 Feb 2019 22:08:38 +0100	[thread overview]
Message-ID: <bca6deb0-ba70-12af-9381-72ae7d94c0c5@meijboom.info> (raw)

Make clean currently does not remove the generated files for objtool:
tools/objtool/objtool, tools/objtool/fixdep, and
tools/objtool/arch/x86/lib/inat-tables.c.

Clean these files up as part of make clean.

Fixes: b9ab5ebb14ec ("objtool: Add CONFIG_STACK_VALIDATION option") and
bug report 199485 (https://bugzilla.kernel.org/show_bug.cgi?id=199485).

Signed-off-by: Robin Meijboom <robin@meijboom.info>
---
In the discussions I didn't find a reason for keeping the files, so I
assume it is an oversight. Otherwise I would have expected them to be
removed at least by make distconfig (which they are not).

Tested by compiling, cleaning, compiling again, and booting on x86_64.

diff --git a/Makefile b/Makefile
index 141653226f3c..81a8149a805f 100644
--- a/Makefile
+++ b/Makefile
@@ -1328,6 +1328,8 @@ endif # CONFIG_MODULES

  # Directories & files removed with 'make clean'
  CLEAN_DIRS  += $(MODVERDIR) include/ksym
+CLEAN_FILES += tools/objtool/objtool tools/objtool/fixdep \
+           tools/objtool/arch/$(ARCH)/lib/inat-tables.c

  # Directories & files removed with 'make mrproper'
  MRPROPER_DIRS  += include/config usr/include include/generated          \

             reply	other threads:[~2019-02-14 21:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-14 21:08 Robin Meijboom [this message]
2019-02-28 13:36 ` [PATCH] objtool: remove generated files with make clean Masahiro Yamada
2019-02-28 20:12   ` Robin Meijboom
2019-02-28 22:29     ` Josh Poimboeuf
2019-03-04 22:43       ` Robin Meijboom
2019-03-05  2:05         ` Josh Poimboeuf
2019-03-05  5:56         ` Masahiro Yamada
2019-03-05  5:52       ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bca6deb0-ba70-12af-9381-72ae7d94c0c5@meijboom.info \
    --to=robin@meijboom.info \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=peterz@infradead.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.