All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yoshitaka Ikeda <ikeda@nskint.co.jp>
To: Mark Brown <broonie@kernel.org>
Cc: Yoshitaka Ikeda <ikeda@nskint.co.jp>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Pratyush Yadav <p.yadav@ti.com>,
	"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
	Masahiro Mizutani <m.mizutani@nskint.co.jp>,
	Ken Kurematsu <k.kurematsu@nskint.co.jp>
Subject: [PATCH v5 1/2] spi: spi-cadence-quadspi: Revert "Fix division by zero warning"
Date: Fri, 16 Jul 2021 14:33:12 +0000	[thread overview]
Message-ID: <bd30bdb4-07c4-f713-5648-01c898d51f1b@nskint.co.jp> (raw)
In-Reply-To: <bd921311-5896-b228-ea6c-20e11dfe62e3@nskint.co.jp>

Revert to change to a better code.

This reverts commit 55cef88bbf12f3bfbe5c2379a8868a034707e755.

Signed-off-by: Yoshitaka Ikeda <ikeda@nskint.co.jp>
---
 drivers/spi/spi-cadence-quadspi.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c
index 13d1f0ce618e..7a00346ff9b9 100644
--- a/drivers/spi/spi-cadence-quadspi.c
+++ b/drivers/spi/spi-cadence-quadspi.c
@@ -307,13 +307,11 @@ static unsigned int cqspi_calc_rdreg(struct cqspi_flash_pdata *f_pdata)
 
 static unsigned int cqspi_calc_dummy(const struct spi_mem_op *op, bool dtr)
 {
-	unsigned int dummy_clk = 0;
+	unsigned int dummy_clk;
 
-	if (op->dummy.buswidth && op->dummy.nbytes) {
-		dummy_clk = op->dummy.nbytes * (8 / op->dummy.buswidth);
-		if (dtr)
-			dummy_clk /= 2;
-	}
+	dummy_clk = op->dummy.nbytes * (8 / op->dummy.buswidth);
+	if (dtr)
+		dummy_clk /= 2;
 
 	return dummy_clk;
 }
-- 
2.32.0

  reply	other threads:[~2021-07-16 14:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-16 14:31 [PATCH v5 0/2] spi: spi-cadence-quadspi: Fix division by zero warning Yoshitaka Ikeda
2021-07-16 14:33 ` Yoshitaka Ikeda [this message]
2021-07-16 14:35 ` [PATCH v5 2/2] " Yoshitaka Ikeda
2021-07-16 17:32 ` [PATCH v5 0/2] " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd30bdb4-07c4-f713-5648-01c898d51f1b@nskint.co.jp \
    --to=ikeda@nskint.co.jp \
    --cc=broonie@kernel.org \
    --cc=k.kurematsu@nskint.co.jp \
    --cc=linux-spi@vger.kernel.org \
    --cc=m.mizutani@nskint.co.jp \
    --cc=p.yadav@ti.com \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.