All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: [PATCH] fstests: add some missing _require_loop's
Date: Thu, 28 Apr 2022 11:05:00 -0400	[thread overview]
Message-ID: <bd80e5861da3f901428ea66f271f8c4f267c4c23.1651158291.git.josef@toxicpanda.com> (raw)

Got a new box running overnight fstests and noticed a couple of failures
because I forgot to enable loop device support.  Fix these two tests to
have _require_loop so they don't fail if there's no loop device support.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
---
 tests/btrfs/012   | 1 +
 tests/generic/648 | 1 +
 2 files changed, 2 insertions(+)

diff --git a/tests/btrfs/012 b/tests/btrfs/012
index 29552b14..60461a34 100755
--- a/tests/btrfs/012
+++ b/tests/btrfs/012
@@ -30,6 +30,7 @@ _require_command "$MKFS_EXT4_PROG" mkfs.ext4
 _require_command "$E2FSCK_PROG" e2fsck
 # ext4 does not support zoned block device
 _require_non_zoned_device "${SCRATCH_DEV}"
+_require_loop
 
 BLOCK_SIZE=`_get_block_size $TEST_DIR`
 
diff --git a/tests/generic/648 b/tests/generic/648
index e5c743c5..d7bf5697 100755
--- a/tests/generic/648
+++ b/tests/generic/648
@@ -39,6 +39,7 @@ _require_scratch_reflink
 _require_cp_reflink
 _require_dm_target error
 _require_command "$KILLALL_PROG" "killall"
+_require_loop
 
 echo "Silence is golden."
 
-- 
2.26.3


             reply	other threads:[~2022-04-28 15:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-28 15:05 Josef Bacik [this message]
2022-04-28 15:13 ` [PATCH] fstests: add some missing _require_loop's Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd80e5861da3f901428ea66f271f8c4f267c4c23.1651158291.git.josef@toxicpanda.com \
    --to=josef@toxicpanda.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.