All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com, ville.syrjala@linux.intel.com,
	imre.deak@intel.com
Subject: [RFC 2/7] drm/i915/ddi: pass encoder to intel_wait_ddi_buf_active()
Date: Tue, 12 Mar 2024 16:28:57 +0200	[thread overview]
Message-ID: <be0b0cc222f015f5d43c8cf2318fa0d8322e85fc.1710253533.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1710253533.git.jani.nikula@intel.com>

Pass encoder to intel_wait_ddi_buf_active().

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_ddi.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index c587a8efeafc..fe00c34b5127 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -200,9 +200,10 @@ void intel_wait_ddi_buf_idle(struct drm_i915_private *dev_priv,
 			port_name(port));
 }
 
-static void intel_wait_ddi_buf_active(struct drm_i915_private *dev_priv,
-				      enum port port)
+static void intel_wait_ddi_buf_active(struct intel_encoder *encoder)
 {
+	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
+	enum port port = encoder->port;
 	enum phy phy = intel_port_to_phy(dev_priv, port);
 	int timeout_us;
 	int ret;
@@ -3354,7 +3355,7 @@ static void intel_enable_ddi_hdmi(struct intel_atomic_state *state,
 
 	intel_de_write(dev_priv, DDI_BUF_CTL(port), buf_ctl);
 
-	intel_wait_ddi_buf_active(dev_priv, port);
+	intel_wait_ddi_buf_active(encoder);
 }
 
 static void intel_enable_ddi(struct intel_atomic_state *state,
@@ -3574,7 +3575,7 @@ static void mtl_ddi_prepare_link_retrain(struct intel_dp *intel_dp,
 	intel_de_posting_read(dev_priv, DDI_BUF_CTL(port));
 
 	/* 6.j Poll for PORT_BUF_CTL Idle Status == 0, timeout after 100 us */
-	intel_wait_ddi_buf_active(dev_priv, port);
+	intel_wait_ddi_buf_active(encoder);
 }
 
 static void intel_ddi_prepare_link_retrain(struct intel_dp *intel_dp,
@@ -3624,7 +3625,7 @@ static void intel_ddi_prepare_link_retrain(struct intel_dp *intel_dp,
 	intel_de_write(dev_priv, DDI_BUF_CTL(port), intel_dp->DP);
 	intel_de_posting_read(dev_priv, DDI_BUF_CTL(port));
 
-	intel_wait_ddi_buf_active(dev_priv, port);
+	intel_wait_ddi_buf_active(encoder);
 }
 
 static void intel_ddi_set_link_train(struct intel_dp *intel_dp,
-- 
2.39.2


  parent reply	other threads:[~2024-03-12 14:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-12 14:28 [RFC 0/7] drm/i915: pass encoder around more for port/phy checks Jani Nikula
2024-03-12 14:28 ` [RFC 1/7] drm/hdmi: convert *_port_to_ddc_pin() to *_encoder_to_ddc_pin() Jani Nikula
2024-03-12 14:28 ` Jani Nikula [this message]
2024-03-12 14:28 ` [RFC 3/7] drm/i915/snps: pass encoder to intel_snps_phy_update_psr_power_state() Jani Nikula
2024-03-12 14:28 ` [RFC 4/7] drm/i915/display: add intel_encoder_is_*() and _to_*() functions Jani Nikula
2024-03-12 14:29 ` [RFC 5/7] drm/i915/display: use intel_encoder_is/to_* functions Jani Nikula
2024-03-12 14:29 ` [RFC 6/7] drm/i915/cx0: remove intel_is_c10phy() Jani Nikula
2024-03-12 14:29 ` [RFC 7/7] drm/i915/cx0: pass encoder instead of i915 and port around Jani Nikula
2024-03-12 17:35 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: pass encoder around more for port/phy checks Patchwork
2024-03-12 17:35 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-03-12 17:54 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-03-20 15:16 ` [RFC 0/7] " Ville Syrjälä
2024-03-20 15:49   ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be0b0cc222f015f5d43c8cf2318fa0d8322e85fc.1710253533.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.