From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> To: linux-pm@vger.kernel.org Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Daniel Lezcano <daniel.lezcano@linaro.org>, Ulf Hansson <ulf.hansson@linaro.org>, Sudeep Holla <sudeep.holla@arm.com>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Shawn Guo <shawnguo@kernel.org>, LKML <linux-kernel@vger.kernel.org>, LAKML <linux-arm-kernel@lists.infradead.org> Subject: [PATCH v2 2/8] ARM: cpuidle: Remove overzealous error logging Date: Fri, 9 Aug 2019 12:03:08 +0100 [thread overview] Message-ID: <bfaea706699cd51341ef1870bc485c8554ebb0be.1565348376.git.lorenzo.pieralisi@arm.com> (raw) In-Reply-To: <cover.1565348376.git.lorenzo.pieralisi@arm.com> CPUidle back-end operations are not implemented in some platforms but this should not be considered an error serious enough to be logged. Check the arm_cpuidle_init() return value to detect whether the failure must be reported or not in the kernel log and do not log it if the platform does not support CPUidle operations. Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com> Cc: Ulf Hansson <ulf.hansson@linaro.org> Cc: Sudeep Holla <sudeep.holla@arm.com> Cc: Daniel Lezcano <daniel.lezcano@linaro.org> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> --- drivers/cpuidle/cpuidle-arm.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/cpuidle/cpuidle-arm.c b/drivers/cpuidle/cpuidle-arm.c index dc33b3d2954f..9e5156d39627 100644 --- a/drivers/cpuidle/cpuidle-arm.c +++ b/drivers/cpuidle/cpuidle-arm.c @@ -105,11 +105,17 @@ static int __init arm_idle_init_cpu(int cpu) ret = arm_cpuidle_init(cpu); /* - * Allow the initialization to continue for other CPUs, if the reported - * failure is a HW misconfiguration/breakage (-ENXIO). + * Allow the initialization to continue for other CPUs, if the + * reported failure is a HW misconfiguration/breakage (-ENXIO). + * + * Some platforms do not support idle operations + * (arm_cpuidle_init() returning -EOPNOTSUPP), we should + * not flag this case as an error, it is a valid + * configuration. */ if (ret) { - pr_err("CPU %d failed to init idle CPU ops\n", cpu); + if (ret != -EOPNOTSUPP) + pr_err("CPU %d failed to init idle CPU ops\n", cpu); ret = ret == -ENXIO ? 0 : ret; goto out_kfree_drv; } -- 2.21.0
WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> To: linux-pm@vger.kernel.org Cc: Mark Rutland <mark.rutland@arm.com>, Ulf Hansson <ulf.hansson@linaro.org>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Daniel Lezcano <daniel.lezcano@linaro.org>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, LKML <linux-kernel@vger.kernel.org>, Sudeep Holla <sudeep.holla@arm.com>, Shawn Guo <shawnguo@kernel.org>, Will Deacon <will@kernel.org>, LAKML <linux-arm-kernel@lists.infradead.org> Subject: [PATCH v2 2/8] ARM: cpuidle: Remove overzealous error logging Date: Fri, 9 Aug 2019 12:03:08 +0100 [thread overview] Message-ID: <bfaea706699cd51341ef1870bc485c8554ebb0be.1565348376.git.lorenzo.pieralisi@arm.com> (raw) In-Reply-To: <cover.1565348376.git.lorenzo.pieralisi@arm.com> CPUidle back-end operations are not implemented in some platforms but this should not be considered an error serious enough to be logged. Check the arm_cpuidle_init() return value to detect whether the failure must be reported or not in the kernel log and do not log it if the platform does not support CPUidle operations. Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com> Cc: Ulf Hansson <ulf.hansson@linaro.org> Cc: Sudeep Holla <sudeep.holla@arm.com> Cc: Daniel Lezcano <daniel.lezcano@linaro.org> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> --- drivers/cpuidle/cpuidle-arm.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/cpuidle/cpuidle-arm.c b/drivers/cpuidle/cpuidle-arm.c index dc33b3d2954f..9e5156d39627 100644 --- a/drivers/cpuidle/cpuidle-arm.c +++ b/drivers/cpuidle/cpuidle-arm.c @@ -105,11 +105,17 @@ static int __init arm_idle_init_cpu(int cpu) ret = arm_cpuidle_init(cpu); /* - * Allow the initialization to continue for other CPUs, if the reported - * failure is a HW misconfiguration/breakage (-ENXIO). + * Allow the initialization to continue for other CPUs, if the + * reported failure is a HW misconfiguration/breakage (-ENXIO). + * + * Some platforms do not support idle operations + * (arm_cpuidle_init() returning -EOPNOTSUPP), we should + * not flag this case as an error, it is a valid + * configuration. */ if (ret) { - pr_err("CPU %d failed to init idle CPU ops\n", cpu); + if (ret != -EOPNOTSUPP) + pr_err("CPU %d failed to init idle CPU ops\n", cpu); ret = ret == -ENXIO ? 0 : ret; goto out_kfree_drv; } -- 2.21.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-09 11:03 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-22 15:37 [PATCH 0/6] ARM: psci: cpuidle: PSCI CPUidle rework Lorenzo Pieralisi 2019-07-22 15:37 ` Lorenzo Pieralisi 2019-07-22 15:37 ` [PATCH 1/6] ARM: cpuidle: Remove useless header include Lorenzo Pieralisi 2019-07-22 15:37 ` Lorenzo Pieralisi 2019-08-06 15:51 ` Sudeep Holla 2019-08-06 15:51 ` Sudeep Holla 2019-08-07 8:19 ` Daniel Lezcano 2019-08-07 8:19 ` Daniel Lezcano 2019-07-22 15:37 ` [PATCH 2/6] ARM: cpuidle: Remove overzealous error logging Lorenzo Pieralisi 2019-07-22 15:37 ` Lorenzo Pieralisi 2019-08-06 15:51 ` Sudeep Holla 2019-08-06 15:51 ` Sudeep Holla 2019-08-07 8:20 ` Daniel Lezcano 2019-08-07 8:20 ` Daniel Lezcano 2019-07-22 15:37 ` [PATCH 3/6] drivers: firmware: psci: Decouple checker from generic ARM CPUidle Lorenzo Pieralisi 2019-07-22 15:37 ` Lorenzo Pieralisi 2019-08-06 15:54 ` Sudeep Holla 2019-08-06 15:54 ` Sudeep Holla 2019-08-07 14:09 ` Daniel Lezcano 2019-08-07 14:09 ` Daniel Lezcano 2019-07-22 15:37 ` [PATCH 4/6] ARM: psci: cpuidle: Introduce PSCI CPUidle driver Lorenzo Pieralisi 2019-07-22 15:37 ` Lorenzo Pieralisi 2019-07-23 11:46 ` Ulf Hansson 2019-07-23 11:46 ` Ulf Hansson 2019-07-23 14:15 ` Lorenzo Pieralisi 2019-07-23 14:15 ` Lorenzo Pieralisi 2019-08-06 16:10 ` Sudeep Holla 2019-08-06 16:10 ` Sudeep Holla 2019-08-06 16:34 ` Lorenzo Pieralisi 2019-08-06 16:34 ` Lorenzo Pieralisi 2019-08-07 16:30 ` Daniel Lezcano 2019-08-07 16:30 ` Daniel Lezcano 2019-07-22 15:37 ` [PATCH 5/6] ARM: psci: cpuidle: Enable " Lorenzo Pieralisi 2019-07-22 15:37 ` Lorenzo Pieralisi 2019-08-06 16:16 ` Sudeep Holla 2019-08-06 16:16 ` Sudeep Holla 2019-08-06 16:40 ` Lorenzo Pieralisi 2019-08-06 16:40 ` Lorenzo Pieralisi 2019-07-22 15:37 ` [PATCH 6/6] PSCI: cpuidle: Refactor CPU suspend power_state parameter handling Lorenzo Pieralisi 2019-07-22 15:37 ` Lorenzo Pieralisi 2019-07-23 11:47 ` Ulf Hansson 2019-07-23 11:47 ` Ulf Hansson 2019-08-07 18:09 ` Daniel Lezcano 2019-08-07 18:09 ` Daniel Lezcano 2019-08-08 12:55 ` Sudeep Holla 2019-08-08 12:55 ` Sudeep Holla 2019-08-08 15:29 ` Ulf Hansson 2019-08-08 15:29 ` Ulf Hansson 2019-08-08 16:04 ` Sudeep Holla 2019-08-08 16:04 ` Sudeep Holla 2019-07-23 11:49 ` [PATCH 0/6] ARM: psci: cpuidle: PSCI CPUidle rework Ulf Hansson 2019-07-23 11:49 ` Ulf Hansson 2019-07-23 14:19 ` Lorenzo Pieralisi 2019-07-23 14:19 ` Lorenzo Pieralisi 2019-08-09 11:03 ` [PATCH v2 0/8] " Lorenzo Pieralisi 2019-08-09 11:03 ` Lorenzo Pieralisi 2019-08-09 11:03 ` [PATCH v2 1/8] ARM: cpuidle: Remove useless header include Lorenzo Pieralisi 2019-08-09 11:03 ` Lorenzo Pieralisi 2019-08-09 11:03 ` Lorenzo Pieralisi [this message] 2019-08-09 11:03 ` [PATCH v2 2/8] ARM: cpuidle: Remove overzealous error logging Lorenzo Pieralisi 2019-08-09 11:03 ` [PATCH v2 3/8] drivers: firmware: psci: Decouple checker from generic ARM CPUidle Lorenzo Pieralisi 2019-08-09 11:03 ` Lorenzo Pieralisi 2019-08-09 11:03 ` [PATCH v2 4/8] ARM: psci: cpuidle: Introduce PSCI CPUidle driver Lorenzo Pieralisi 2019-08-09 11:03 ` Lorenzo Pieralisi 2019-08-09 11:03 ` [PATCH v2 5/8] ARM: psci: cpuidle: Enable " Lorenzo Pieralisi 2019-08-09 11:03 ` Lorenzo Pieralisi 2019-08-09 11:03 ` [PATCH v2 6/8] PSCI: cpuidle: Refactor CPU suspend power_state parameter handling Lorenzo Pieralisi 2019-08-09 11:03 ` Lorenzo Pieralisi 2019-08-09 11:03 ` [PATCH v2 7/8] arm64: defconfig: Enable the PSCI CPUidle driver Lorenzo Pieralisi 2019-08-09 11:03 ` Lorenzo Pieralisi 2019-08-09 16:53 ` Will Deacon 2019-08-09 16:53 ` Will Deacon 2019-08-09 11:03 ` [PATCH v2 8/8] ARM: imx_v6_v7_defconfig: " Lorenzo Pieralisi 2019-08-09 11:03 ` Lorenzo Pieralisi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bfaea706699cd51341ef1870bc485c8554ebb0be.1565348376.git.lorenzo.pieralisi@arm.com \ --to=lorenzo.pieralisi@arm.com \ --cc=catalin.marinas@arm.com \ --cc=daniel.lezcano@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=rjw@rjwysocki.net \ --cc=shawnguo@kernel.org \ --cc=sudeep.holla@arm.com \ --cc=ulf.hansson@linaro.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.