From: William Breathitt Gray <vilhelm.gray@gmail.com> To: jic23@kernel.org Cc: kernel@pengutronix.de, linux-stm32@st-md-mailman.stormreply.com, a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com, gwendal@chromium.org, alexandre.belloni@bootlin.com, david@lechnology.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com, patrick.havelange@essensium.com, fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, o.rempel@pengutronix.de, William Breathitt Gray <vilhelm.gray@gmail.com> Subject: [PATCH v8 11/22] counter: Rename counter_signal_value to counter_signal_level Date: Fri, 12 Feb 2021 21:13:35 +0900 [thread overview] Message-ID: <c07454c388991d7e2432c1ef838405c9df9dd02f.1613131238.git.vilhelm.gray@gmail.com> (raw) In-Reply-To: <cover.1613131238.git.vilhelm.gray@gmail.com> Signal values will always be levels so let's be explicit it about it to make the intent of the code clear. Cc: Syed Nayyar Waris <syednwaris@gmail.com> Cc: Kamel Bouhara <kamel.bouhara@bootlin.com> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> --- drivers/counter/104-quad-8.c | 5 +++-- drivers/counter/counter.c | 12 ++++++------ drivers/counter/microchip-tcb-capture.c | 4 ++-- include/linux/counter.h | 12 ++++++------ 4 files changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c index a2cabb028db0..ead0eeb6c846 100644 --- a/drivers/counter/104-quad-8.c +++ b/drivers/counter/104-quad-8.c @@ -97,7 +97,8 @@ struct quad8 { #define QUAD8_CMR_QUADRATURE_X4 0x18 static int quad8_signal_read(struct counter_device *counter, - struct counter_signal *signal, enum counter_signal_value *val) + struct counter_signal *signal, + enum counter_signal_level *level) { const struct quad8 *const priv = counter->priv; unsigned int state; @@ -109,7 +110,7 @@ static int quad8_signal_read(struct counter_device *counter, state = inb(priv->base + QUAD8_REG_INDEX_INPUT_LEVELS) & BIT(signal->id - 16); - *val = (state) ? COUNTER_SIGNAL_HIGH : COUNTER_SIGNAL_LOW; + *level = (state) ? COUNTER_SIGNAL_LEVEL_HIGH : COUNTER_SIGNAL_LEVEL_LOW; return 0; } diff --git a/drivers/counter/counter.c b/drivers/counter/counter.c index 6a683d086008..cb92673552b5 100644 --- a/drivers/counter/counter.c +++ b/drivers/counter/counter.c @@ -289,9 +289,9 @@ struct counter_signal_unit { struct counter_signal *signal; }; -static const char *const counter_signal_value_str[] = { - [COUNTER_SIGNAL_LOW] = "low", - [COUNTER_SIGNAL_HIGH] = "high" +static const char *const counter_signal_level_str[] = { + [COUNTER_SIGNAL_LEVEL_LOW] = "low", + [COUNTER_SIGNAL_LEVEL_HIGH] = "high" }; static ssize_t counter_signal_show(struct device *dev, @@ -302,13 +302,13 @@ static ssize_t counter_signal_show(struct device *dev, const struct counter_signal_unit *const component = devattr->component; struct counter_signal *const signal = component->signal; int err; - enum counter_signal_value val; + enum counter_signal_level level; - err = counter->ops->signal_read(counter, signal, &val); + err = counter->ops->signal_read(counter, signal, &level); if (err) return err; - return sprintf(buf, "%s\n", counter_signal_value_str[val]); + return sprintf(buf, "%s\n", counter_signal_level_str[level]); } struct counter_name_unit { diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c index ee979b011012..f56c4e328018 100644 --- a/drivers/counter/microchip-tcb-capture.c +++ b/drivers/counter/microchip-tcb-capture.c @@ -158,7 +158,7 @@ static int mchp_tc_count_function_set(struct counter_device *counter, static int mchp_tc_count_signal_read(struct counter_device *counter, struct counter_signal *signal, - enum counter_signal_value *val) + enum counter_signal_level *lvl) { struct mchp_tc_data *const priv = counter->priv; bool sigstatus; @@ -171,7 +171,7 @@ static int mchp_tc_count_signal_read(struct counter_device *counter, else sigstatus = (sr & ATMEL_TC_MTIOA); - *val = sigstatus ? COUNTER_SIGNAL_HIGH : COUNTER_SIGNAL_LOW; + *lvl = sigstatus ? COUNTER_SIGNAL_LEVEL_HIGH : COUNTER_SIGNAL_LEVEL_LOW; return 0; } diff --git a/include/linux/counter.h b/include/linux/counter.h index 9dbd5df4cd34..79f5dcaf6ba0 100644 --- a/include/linux/counter.h +++ b/include/linux/counter.h @@ -290,16 +290,16 @@ struct counter_device_state { const struct attribute_group **groups; }; -enum counter_signal_value { - COUNTER_SIGNAL_LOW = 0, - COUNTER_SIGNAL_HIGH +enum counter_signal_level { + COUNTER_SIGNAL_LEVEL_LOW, + COUNTER_SIGNAL_LEVEL_HIGH, }; /** * struct counter_ops - Callbacks from driver * @signal_read: optional read callback for Signal attribute. The read - * value of the respective Signal should be passed back via - * the val parameter. + * level of the respective Signal should be passed back via + * the level parameter. * @count_read: optional read callback for Count attribute. The read * value of the respective Count should be passed back via * the val parameter. @@ -324,7 +324,7 @@ enum counter_signal_value { struct counter_ops { int (*signal_read)(struct counter_device *counter, struct counter_signal *signal, - enum counter_signal_value *val); + enum counter_signal_level *level); int (*count_read)(struct counter_device *counter, struct counter_count *count, unsigned long *val); int (*count_write)(struct counter_device *counter, -- 2.30.0
WARNING: multiple messages have this Message-ID (diff)
From: William Breathitt Gray <vilhelm.gray@gmail.com> To: jic23@kernel.org Cc: kamel.bouhara@bootlin.com, gwendal@chromium.org, a.fatoum@pengutronix.de, david@lechnology.com, linux-iio@vger.kernel.org, patrick.havelange@essensium.com, alexandre.belloni@bootlin.com, mcoquelin.stm32@gmail.com, linux-kernel@vger.kernel.org, o.rempel@pengutronix.de, kernel@pengutronix.de, William Breathitt Gray <vilhelm.gray@gmail.com>, fabrice.gasnier@st.com, syednwaris@gmail.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, alexandre.torgue@st.com Subject: [PATCH v8 11/22] counter: Rename counter_signal_value to counter_signal_level Date: Fri, 12 Feb 2021 21:13:35 +0900 [thread overview] Message-ID: <c07454c388991d7e2432c1ef838405c9df9dd02f.1613131238.git.vilhelm.gray@gmail.com> (raw) In-Reply-To: <cover.1613131238.git.vilhelm.gray@gmail.com> Signal values will always be levels so let's be explicit it about it to make the intent of the code clear. Cc: Syed Nayyar Waris <syednwaris@gmail.com> Cc: Kamel Bouhara <kamel.bouhara@bootlin.com> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> --- drivers/counter/104-quad-8.c | 5 +++-- drivers/counter/counter.c | 12 ++++++------ drivers/counter/microchip-tcb-capture.c | 4 ++-- include/linux/counter.h | 12 ++++++------ 4 files changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c index a2cabb028db0..ead0eeb6c846 100644 --- a/drivers/counter/104-quad-8.c +++ b/drivers/counter/104-quad-8.c @@ -97,7 +97,8 @@ struct quad8 { #define QUAD8_CMR_QUADRATURE_X4 0x18 static int quad8_signal_read(struct counter_device *counter, - struct counter_signal *signal, enum counter_signal_value *val) + struct counter_signal *signal, + enum counter_signal_level *level) { const struct quad8 *const priv = counter->priv; unsigned int state; @@ -109,7 +110,7 @@ static int quad8_signal_read(struct counter_device *counter, state = inb(priv->base + QUAD8_REG_INDEX_INPUT_LEVELS) & BIT(signal->id - 16); - *val = (state) ? COUNTER_SIGNAL_HIGH : COUNTER_SIGNAL_LOW; + *level = (state) ? COUNTER_SIGNAL_LEVEL_HIGH : COUNTER_SIGNAL_LEVEL_LOW; return 0; } diff --git a/drivers/counter/counter.c b/drivers/counter/counter.c index 6a683d086008..cb92673552b5 100644 --- a/drivers/counter/counter.c +++ b/drivers/counter/counter.c @@ -289,9 +289,9 @@ struct counter_signal_unit { struct counter_signal *signal; }; -static const char *const counter_signal_value_str[] = { - [COUNTER_SIGNAL_LOW] = "low", - [COUNTER_SIGNAL_HIGH] = "high" +static const char *const counter_signal_level_str[] = { + [COUNTER_SIGNAL_LEVEL_LOW] = "low", + [COUNTER_SIGNAL_LEVEL_HIGH] = "high" }; static ssize_t counter_signal_show(struct device *dev, @@ -302,13 +302,13 @@ static ssize_t counter_signal_show(struct device *dev, const struct counter_signal_unit *const component = devattr->component; struct counter_signal *const signal = component->signal; int err; - enum counter_signal_value val; + enum counter_signal_level level; - err = counter->ops->signal_read(counter, signal, &val); + err = counter->ops->signal_read(counter, signal, &level); if (err) return err; - return sprintf(buf, "%s\n", counter_signal_value_str[val]); + return sprintf(buf, "%s\n", counter_signal_level_str[level]); } struct counter_name_unit { diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c index ee979b011012..f56c4e328018 100644 --- a/drivers/counter/microchip-tcb-capture.c +++ b/drivers/counter/microchip-tcb-capture.c @@ -158,7 +158,7 @@ static int mchp_tc_count_function_set(struct counter_device *counter, static int mchp_tc_count_signal_read(struct counter_device *counter, struct counter_signal *signal, - enum counter_signal_value *val) + enum counter_signal_level *lvl) { struct mchp_tc_data *const priv = counter->priv; bool sigstatus; @@ -171,7 +171,7 @@ static int mchp_tc_count_signal_read(struct counter_device *counter, else sigstatus = (sr & ATMEL_TC_MTIOA); - *val = sigstatus ? COUNTER_SIGNAL_HIGH : COUNTER_SIGNAL_LOW; + *lvl = sigstatus ? COUNTER_SIGNAL_LEVEL_HIGH : COUNTER_SIGNAL_LEVEL_LOW; return 0; } diff --git a/include/linux/counter.h b/include/linux/counter.h index 9dbd5df4cd34..79f5dcaf6ba0 100644 --- a/include/linux/counter.h +++ b/include/linux/counter.h @@ -290,16 +290,16 @@ struct counter_device_state { const struct attribute_group **groups; }; -enum counter_signal_value { - COUNTER_SIGNAL_LOW = 0, - COUNTER_SIGNAL_HIGH +enum counter_signal_level { + COUNTER_SIGNAL_LEVEL_LOW, + COUNTER_SIGNAL_LEVEL_HIGH, }; /** * struct counter_ops - Callbacks from driver * @signal_read: optional read callback for Signal attribute. The read - * value of the respective Signal should be passed back via - * the val parameter. + * level of the respective Signal should be passed back via + * the level parameter. * @count_read: optional read callback for Count attribute. The read * value of the respective Count should be passed back via * the val parameter. @@ -324,7 +324,7 @@ enum counter_signal_value { struct counter_ops { int (*signal_read)(struct counter_device *counter, struct counter_signal *signal, - enum counter_signal_value *val); + enum counter_signal_level *level); int (*count_read)(struct counter_device *counter, struct counter_count *count, unsigned long *val); int (*count_write)(struct counter_device *counter, -- 2.30.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-12 12:18 UTC|newest] Thread overview: 139+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-12 12:13 [PATCH v8 00/22] Introduce the Counter character device interface William Breathitt Gray 2021-02-12 12:13 ` William Breathitt Gray 2021-02-12 12:13 ` [PATCH v8 01/22] docs: counter: Consolidate Counter sysfs attributes documentation William Breathitt Gray 2021-02-12 12:13 ` William Breathitt Gray 2021-02-14 16:57 ` Jonathan Cameron 2021-02-14 16:57 ` Jonathan Cameron 2021-02-15 11:05 ` William Breathitt Gray 2021-02-15 11:05 ` William Breathitt Gray 2021-02-20 16:25 ` David Lechner 2021-02-20 16:25 ` David Lechner 2021-02-12 12:13 ` [PATCH v8 02/22] docs: counter: Fix spelling William Breathitt Gray 2021-02-12 12:13 ` William Breathitt Gray 2021-02-20 16:26 ` David Lechner 2021-02-20 16:26 ` David Lechner 2021-02-12 12:13 ` [PATCH v8 03/22] counter: 104-quad-8: Return error when invalid mode during ceiling_write William Breathitt Gray 2021-02-12 12:13 ` William Breathitt Gray 2021-02-20 16:30 ` David Lechner 2021-02-20 16:30 ` David Lechner 2021-02-22 2:06 ` William Breathitt Gray 2021-02-22 2:06 ` William Breathitt Gray 2021-02-12 12:13 ` [PATCH v8 04/22] counter: 104-quad-8: Annotate hardware config module parameter William Breathitt Gray 2021-02-12 12:13 ` William Breathitt Gray 2021-02-12 12:13 ` [PATCH v8 05/22] counter: 104-quad-8: Add const qualifiers for quad8_preset_register_set William Breathitt Gray 2021-02-12 12:13 ` William Breathitt Gray 2021-02-12 12:13 ` [PATCH v8 06/22] counter: 104-quad-8: Add const qualifier for functions_list array William Breathitt Gray 2021-02-12 12:13 ` William Breathitt Gray 2021-02-12 12:13 ` [PATCH v8 07/22] counter: 104-quad-8: Add const qualifier for actions_list array William Breathitt Gray 2021-02-12 12:13 ` William Breathitt Gray 2021-02-12 12:13 ` [PATCH v8 08/22] counter: ftm-quaddec: " William Breathitt Gray 2021-02-12 12:13 ` William Breathitt Gray 2021-02-12 12:13 ` [PATCH v8 09/22] counter: Return error code on invalid modes William Breathitt Gray 2021-02-12 12:13 ` William Breathitt Gray 2021-02-14 17:07 ` Jonathan Cameron 2021-02-14 17:07 ` Jonathan Cameron 2021-02-20 16:43 ` David Lechner 2021-02-20 16:43 ` David Lechner 2021-02-22 4:42 ` William Breathitt Gray 2021-02-22 4:42 ` William Breathitt Gray 2021-02-12 12:13 ` [PATCH v8 10/22] counter: Standardize to ERANGE for limit exceeded errors William Breathitt Gray 2021-02-12 12:13 ` William Breathitt Gray 2021-02-14 17:10 ` Jonathan Cameron 2021-02-14 17:10 ` Jonathan Cameron 2021-02-16 1:26 ` William Breathitt Gray 2021-02-16 1:26 ` William Breathitt Gray 2021-02-21 14:03 ` Jonathan Cameron 2021-02-21 14:03 ` Jonathan Cameron 2021-02-20 16:48 ` David Lechner 2021-02-20 16:48 ` David Lechner 2021-02-12 12:13 ` William Breathitt Gray [this message] 2021-02-12 12:13 ` [PATCH v8 11/22] counter: Rename counter_signal_value to counter_signal_level William Breathitt Gray 2021-02-20 16:52 ` David Lechner 2021-02-20 16:52 ` David Lechner 2021-02-12 12:13 ` [PATCH v8 12/22] counter: Rename counter_count_function to counter_function William Breathitt Gray 2021-02-12 12:13 ` William Breathitt Gray 2021-02-14 17:13 ` Jonathan Cameron 2021-02-14 17:13 ` Jonathan Cameron 2021-02-20 16:56 ` David Lechner 2021-02-20 16:56 ` David Lechner 2021-02-23 5:14 ` William Breathitt Gray 2021-02-23 5:14 ` William Breathitt Gray 2021-02-12 12:13 ` [PATCH v8 13/22] counter: Internalize sysfs interface code William Breathitt Gray 2021-02-14 17:32 ` Jonathan Cameron 2021-02-14 17:32 ` Jonathan Cameron 2021-02-20 17:50 ` David Lechner 2021-02-20 17:50 ` David Lechner 2021-02-12 12:13 ` [PATCH v8 14/22] counter: Update counter.h comments to reflect sysfs internalization William Breathitt Gray 2021-02-12 12:13 ` William Breathitt Gray 2021-02-12 12:13 ` [PATCH v8 15/22] docs: counter: Update " William Breathitt Gray 2021-02-12 12:13 ` William Breathitt Gray 2021-02-12 12:13 ` [PATCH v8 16/22] counter: Move counter enums to uapi header William Breathitt Gray 2021-02-12 12:13 ` William Breathitt Gray 2021-02-20 23:55 ` David Lechner 2021-02-20 23:55 ` David Lechner 2021-02-12 12:13 ` [PATCH v8 17/22] counter: Add character device interface William Breathitt Gray 2021-02-12 12:13 ` William Breathitt Gray 2021-02-14 18:06 ` Jonathan Cameron 2021-02-14 18:06 ` Jonathan Cameron 2021-02-24 5:34 ` William Breathitt Gray 2021-02-24 5:34 ` William Breathitt Gray 2021-02-15 9:24 ` Oleksij Rempel 2021-02-15 9:24 ` Oleksij Rempel 2021-02-16 1:53 ` William Breathitt Gray 2021-02-16 1:53 ` William Breathitt Gray 2021-02-12 12:13 ` [PATCH v8 18/22] docs: counter: Document " William Breathitt Gray 2021-02-12 12:13 ` William Breathitt Gray 2021-02-14 17:48 ` Jonathan Cameron 2021-02-14 17:48 ` Jonathan Cameron 2021-02-22 10:11 ` Pavel Machek 2021-02-22 10:11 ` Pavel Machek 2021-02-26 0:27 ` William Breathitt Gray 2021-02-26 0:27 ` William Breathitt Gray 2021-02-26 0:22 ` William Breathitt Gray 2021-02-26 0:22 ` William Breathitt Gray 2021-02-12 12:13 ` [PATCH v8 19/22] counter: Implement extension*_name sysfs attributes William Breathitt Gray 2021-02-12 12:13 ` William Breathitt Gray 2021-02-14 18:09 ` Jonathan Cameron 2021-02-14 18:09 ` Jonathan Cameron 2021-02-19 8:51 ` William Breathitt Gray 2021-02-19 8:51 ` William Breathitt Gray 2021-02-21 14:05 ` Jonathan Cameron 2021-02-21 14:05 ` Jonathan Cameron 2021-02-25 23:32 ` William Breathitt Gray 2021-02-25 23:32 ` William Breathitt Gray 2021-02-27 15:14 ` Jonathan Cameron 2021-02-27 15:14 ` Jonathan Cameron 2021-02-12 12:13 ` [PATCH v8 20/22] counter: Implement events_queue_size sysfs attribute William Breathitt Gray 2021-02-12 12:13 ` William Breathitt Gray 2021-02-14 18:11 ` Jonathan Cameron 2021-02-14 18:11 ` Jonathan Cameron 2021-02-18 10:32 ` William Breathitt Gray 2021-02-18 10:32 ` William Breathitt Gray 2021-02-21 15:51 ` Jonathan Cameron 2021-02-21 15:51 ` Jonathan Cameron 2021-02-26 0:03 ` William Breathitt Gray 2021-02-26 0:03 ` William Breathitt Gray 2021-02-27 0:14 ` David Lechner 2021-02-27 0:14 ` David Lechner 2021-02-27 0:20 ` William Breathitt Gray 2021-02-27 0:20 ` William Breathitt Gray 2021-02-27 15:18 ` Jonathan Cameron 2021-02-27 15:18 ` Jonathan Cameron 2021-02-28 2:46 ` William Breathitt Gray 2021-02-28 2:46 ` William Breathitt Gray 2021-02-12 12:13 ` [PATCH v8 21/22] counter: 104-quad-8: Replace mutex with spinlock William Breathitt Gray 2021-02-12 12:13 ` William Breathitt Gray 2021-02-14 18:19 ` Jonathan Cameron 2021-02-14 18:19 ` Jonathan Cameron 2021-02-16 2:16 ` William Breathitt Gray 2021-02-16 2:16 ` William Breathitt Gray 2021-02-16 19:27 ` Jonathan Cameron 2021-02-16 19:27 ` Jonathan Cameron 2021-02-18 10:16 ` William Breathitt Gray 2021-02-18 10:16 ` William Breathitt Gray 2021-02-12 12:13 ` [PATCH v8 22/22] counter: 104-quad-8: Add IRQ support for the ACCES 104-QUAD-8 William Breathitt Gray 2021-02-12 12:13 ` William Breathitt Gray 2021-02-14 18:24 ` Jonathan Cameron 2021-02-14 18:24 ` Jonathan Cameron 2021-02-19 9:21 ` William Breathitt Gray 2021-02-19 9:21 ` William Breathitt Gray
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c07454c388991d7e2432c1ef838405c9df9dd02f.1613131238.git.vilhelm.gray@gmail.com \ --to=vilhelm.gray@gmail.com \ --cc=a.fatoum@pengutronix.de \ --cc=alexandre.belloni@bootlin.com \ --cc=alexandre.torgue@st.com \ --cc=david@lechnology.com \ --cc=fabrice.gasnier@st.com \ --cc=gwendal@chromium.org \ --cc=jic23@kernel.org \ --cc=kamel.bouhara@bootlin.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=o.rempel@pengutronix.de \ --cc=patrick.havelange@essensium.com \ --cc=syednwaris@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.