All of lore.kernel.org
 help / color / mirror / Atom feed
From: Asutosh Das <quic_asutoshd@quicinc.com>
To: <quic_cang@quicinc.com>, <martin.petersen@oracle.com>,
	<linux-scsi@vger.kernel.org>
Cc: <quic_nguyenb@quicinc.com>, <quic_xiaosenh@quicinc.com>,
	<stanley.chu@mediatek.com>, <eddie.huang@mediatek.com>,
	<daejun7.park@samsung.com>, <bvanassche@acm.org>,
	<avri.altman@wdc.com>, <mani@kernel.org>, <beanhuo@micron.com>,
	Asutosh Das <quic_asutoshd@quicinc.com>,
	<linux-arm-msm@vger.kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	Jinyoung Choi <j-young.choi@samsung.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: [PATCH v7 10/16] ufs: core: mcq: Use shared tags for MCQ mode
Date: Tue, 29 Nov 2022 10:53:16 -0800	[thread overview]
Message-ID: <c0d23bb31ae307b66a169e90ef4cc0d877aa6074.1669747235.git.quic_asutoshd@quicinc.com> (raw)
In-Reply-To: <cover.1669747235.git.quic_asutoshd@quicinc.com>

Enable shared tags for MCQ. For UFS, this should
not have a huge performance impact. It however
simplifies the MCQ implementation and reuses most of
the existing code in the issue and completion path.
Also add multiple queue mapping to map_queue().

Co-developed-by: Can Guo <quic_cang@quicinc.com>
Signed-off-by: Can Guo <quic_cang@quicinc.com>
Signed-off-by: Asutosh Das <quic_asutoshd@quicinc.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
---
 drivers/ufs/core/ufs-mcq.c |  2 ++
 drivers/ufs/core/ufshcd.c  | 28 ++++++++++++++++------------
 2 files changed, 18 insertions(+), 12 deletions(-)

diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c
index a783dcd..cffec4c 100644
--- a/drivers/ufs/core/ufs-mcq.c
+++ b/drivers/ufs/core/ufs-mcq.c
@@ -280,6 +280,7 @@ void ufshcd_mcq_make_queues_operational(struct ufs_hba *hba)
 
 int ufshcd_mcq_init(struct ufs_hba *hba)
 {
+	struct Scsi_Host *host = hba->host;
 	struct ufs_hw_queue *hwq;
 	int ret, i;
 
@@ -315,6 +316,7 @@ int ufshcd_mcq_init(struct ufs_hba *hba)
 	/* Give dev_cmd_queue the minimal number of entries */
 	hba->dev_cmd_queue->max_entries = MAX_DEV_CMD_ENTRIES;
 
+	host->host_tagset = 1;
 	return 0;
 }
 
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 3210f6e..965e844 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -2763,24 +2763,28 @@ static inline bool is_device_wlun(struct scsi_device *sdev)
  */
 static void ufshcd_map_queues(struct Scsi_Host *shost)
 {
-	int i;
+	struct ufs_hba *hba = shost_priv(shost);
+	int i, queue_offset = 0;
+
+	if (!is_mcq_supported(hba)) {
+		hba->nr_queues[HCTX_TYPE_DEFAULT] = 1;
+		hba->nr_queues[HCTX_TYPE_READ] = 0;
+		hba->nr_queues[HCTX_TYPE_POLL] = 1;
+		hba->nr_hw_queues = 1;
+	}
 
 	for (i = 0; i < shost->nr_maps; i++) {
 		struct blk_mq_queue_map *map = &shost->tag_set.map[i];
 
-		switch (i) {
-		case HCTX_TYPE_DEFAULT:
-		case HCTX_TYPE_POLL:
-			map->nr_queues = 1;
-			break;
-		case HCTX_TYPE_READ:
-			map->nr_queues = 0;
+		map->nr_queues = hba->nr_queues[i];
+		if (!map->nr_queues)
 			continue;
-		default:
-			WARN_ON_ONCE(true);
-		}
-		map->queue_offset = 0;
+		map->queue_offset = queue_offset;
+		if (i == HCTX_TYPE_POLL && !is_mcq_supported(hba))
+			map->queue_offset = 0;
+
 		blk_mq_map_queues(map);
+		queue_offset += map->nr_queues;
 	}
 }
 
-- 
2.7.4


  parent reply	other threads:[~2022-11-29 18:57 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-29 18:53 [PATCH v7 00/16] Add Multi Circular Queue Support Asutosh Das
2022-11-29 18:53 ` [PATCH v7 01/16] ufs: core: Optimize duplicate code to read extended feature Asutosh Das
2022-11-29 18:53 ` [PATCH v7 02/16] ufs: core: Probe for ext_iid support Asutosh Das
2022-11-29 18:53 ` [PATCH v7 03/16] ufs: core: Introduce Multi-circular queue capability Asutosh Das
2022-11-29 18:53 ` [PATCH v7 04/16] ufs: core: Defer adding host to scsi if mcq is supported Asutosh Das
2022-11-29 18:53 ` [PATCH v7 05/16] ufs: core: mcq: Add support to allocate multiple queues Asutosh Das
2022-11-29 18:53 ` [PATCH v7 06/16] ufs: core: mcq: Configure resource regions Asutosh Das
2022-11-29 19:22   ` Bart Van Assche
2022-11-30  9:15   ` Eddie Huang (黃智傑)
2022-11-30 18:44     ` Asutosh Das
2022-11-29 18:53 ` [PATCH v7 07/16] ufs: core: mcq: Calculate queue depth Asutosh Das
2022-11-29 19:23   ` Bart Van Assche
2022-11-29 18:53 ` [PATCH v7 08/16] ufs: core: mcq: Allocate memory for mcq mode Asutosh Das
2022-11-29 19:23   ` Bart Van Assche
2022-11-29 18:53 ` [PATCH v7 09/16] ufs: core: mcq: Configure operation and runtime interface Asutosh Das
2022-11-29 19:23   ` Bart Van Assche
2022-11-29 18:53 ` Asutosh Das [this message]
2022-11-29 18:53 ` [PATCH v7 11/16] ufs: core: Prepare ufshcd_send_command for mcq Asutosh Das
2022-11-29 18:53 ` [PATCH v7 12/16] ufs: core: mcq: Find hardware queue to queue request Asutosh Das
2022-11-29 18:53 ` [PATCH v7 13/16] ufs: core: Prepare for completion in mcq Asutosh Das
2022-11-29 18:53 ` [PATCH v7 14/16] ufs: mcq: Add completion support of a cqe Asutosh Das
2022-11-29 18:53 ` [PATCH v7 15/16] ufs: core: mcq: Add completion support in poll Asutosh Das
2022-11-29 18:53 ` [PATCH v7 16/16] ufs: core: mcq: Enable Multi Circular Queue Asutosh Das
2022-11-30 17:51 ` [PATCH v7 00/16] Add Multi Circular Queue Support Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0d23bb31ae307b66a169e90ef4cc0d877aa6074.1669747235.git.quic_asutoshd@quicinc.com \
    --to=quic_asutoshd@quicinc.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=daejun7.park@samsung.com \
    --cc=eddie.huang@mediatek.com \
    --cc=j-young.choi@samsung.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=quic_cang@quicinc.com \
    --cc=quic_nguyenb@quicinc.com \
    --cc=quic_xiaosenh@quicinc.com \
    --cc=stanley.chu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.