All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
To: Parav Pandit <parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	"Gruher,
	Joseph R"
	<joseph.r.gruher-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: Working NVMeoF Config From 4.12.5 Fails With 4.15.0
Date: Sun, 4 Feb 2018 16:59:36 +0200	[thread overview]
Message-ID: <c0e91150-72be-44f3-6cb4-f95f85444915@grimberg.me> (raw)
In-Reply-To: <HE1PR0502MB3004A319E5CBF9FC43806136D1F80-692Kmc8YnlL9PhveBwpv4cDSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>


> I didn't read much email details.
> However there was a mention and git bisect done by Logan Gunthorpe in recent email in [1].
> Where he mentioned possible commit that introduced the regression.
> 05e0cc84e00c net/mlx5: Fix get vector affinity helper function
> 
> [1] https://www.spinics.net/lists/linux-rdma/msg60298.html
> 
> You might want to try to revert that commit and attempt.
> Might be same issue. Might be different, not sure.

Indeed,

Does this fix your issue?
--
diff --git a/include/linux/mlx5/driver.h b/include/linux/mlx5/driver.h
index a0610427e168..b82c4ae92411 100644
--- a/include/linux/mlx5/driver.h
+++ b/include/linux/mlx5/driver.h
@@ -1238,7 +1238,7 @@ mlx5_get_vector_affinity(struct mlx5_core_dev 
*dev, int vector)
         int eqn;
         int err;

-       err = mlx5_vector2eqn(dev, vector, &eqn, &irq);
+       err = mlx5_vector2eqn(dev, MLX5_EQ_VEC_COMP_BASE + vector, &eqn, 
&irq);
         if (err)
                 return NULL;

--
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: sagi@grimberg.me (Sagi Grimberg)
Subject: Working NVMeoF Config From 4.12.5 Fails With 4.15.0
Date: Sun, 4 Feb 2018 16:59:36 +0200	[thread overview]
Message-ID: <c0e91150-72be-44f3-6cb4-f95f85444915@grimberg.me> (raw)
In-Reply-To: <HE1PR0502MB3004A319E5CBF9FC43806136D1F80@HE1PR0502MB3004.eurprd05.prod.outlook.com>


> I didn't read much email details.
> However there was a mention and git bisect done by Logan Gunthorpe in recent email in [1].
> Where he mentioned possible commit that introduced the regression.
> 05e0cc84e00c net/mlx5: Fix get vector affinity helper function
> 
> [1] https://www.spinics.net/lists/linux-rdma/msg60298.html
> 
> You might want to try to revert that commit and attempt.
> Might be same issue. Might be different, not sure.

Indeed,

Does this fix your issue?
--
diff --git a/include/linux/mlx5/driver.h b/include/linux/mlx5/driver.h
index a0610427e168..b82c4ae92411 100644
--- a/include/linux/mlx5/driver.h
+++ b/include/linux/mlx5/driver.h
@@ -1238,7 +1238,7 @@ mlx5_get_vector_affinity(struct mlx5_core_dev 
*dev, int vector)
         int eqn;
         int err;

-       err = mlx5_vector2eqn(dev, vector, &eqn, &irq);
+       err = mlx5_vector2eqn(dev, MLX5_EQ_VEC_COMP_BASE + vector, &eqn, 
&irq);
         if (err)
                 return NULL;

--

  parent reply	other threads:[~2018-02-04 14:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-02 23:36 Working NVMeoF Config From 4.12.5 Fails With 4.15.0 Gruher, Joseph R
2018-02-02 23:36 ` Gruher, Joseph R
     [not found] ` <DE927C68B458BE418D582EC97927A9287FE2088B-8oqHQFITsIFQxe9IK+vIArfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2018-02-03  0:55   ` Parav Pandit
2018-02-03  0:55     ` Parav Pandit
     [not found]     ` <HE1PR0502MB3004A319E5CBF9FC43806136D1F80-692Kmc8YnlL9PhveBwpv4cDSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2018-02-04 14:59       ` Sagi Grimberg [this message]
2018-02-04 14:59         ` Sagi Grimberg
  -- strict thread matches above, loose matches on Subject: below --
2018-02-02 23:23 Gruher, Joseph R

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0e91150-72be-44f3-6cb4-f95f85444915@grimberg.me \
    --to=sagi-nqwnxtmzq1alnmji0ikvqw@public.gmane.org \
    --cc=joseph.r.gruher-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.