From: Amit Kucheria <amit.kucheria@linaro.org> To: linux-kernel@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, viresh.kumar@linaro.org, edubezval@gmail.com, swboyd@chromium.org, dianders@chromium.org, mka@chromium.org, Sudeep Holla <sudeep.holla@arm.com>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Wei Yongjun <weiyongjun1@huawei.com>, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Subject: [PATCH v2 8/9] cpufreq: scmi: Use auto-registration of thermal cooling device Date: Mon, 21 Jan 2019 21:10:33 +0530 [thread overview] Message-ID: <c2fe27f06a87d80e4909610a37441e90076434b3.1548084260.git.amit.kucheria@linaro.org> (raw) In-Reply-To: <cover.1548084260.git.amit.kucheria@linaro.org> In-Reply-To: <cover.1548084260.git.amit.kucheria@linaro.org> Use the CPUFREQ_AUTO_REGISTER_COOLING_DEV flag to allow cpufreq core to automatically register as a thermal cooling device. This allows removal of boiler plate code from the driver. Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> Acked-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/cpufreq/scmi-cpufreq.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c index 242c3370544e..b19e9d129f8f 100644 --- a/drivers/cpufreq/scmi-cpufreq.c +++ b/drivers/cpufreq/scmi-cpufreq.c @@ -11,7 +11,6 @@ #include <linux/cpu.h> #include <linux/cpufreq.h> #include <linux/cpumask.h> -#include <linux/cpu_cooling.h> #include <linux/export.h> #include <linux/module.h> #include <linux/pm_opp.h> @@ -22,7 +21,6 @@ struct scmi_data { int domain_id; struct device *cpu_dev; - struct thermal_cooling_device *cdev; }; static const struct scmi_handle *handle; @@ -185,7 +183,6 @@ static int scmi_cpufreq_exit(struct cpufreq_policy *policy) { struct scmi_data *priv = policy->driver_data; - cpufreq_cooling_unregister(priv->cdev); dev_pm_opp_free_cpufreq_table(priv->cpu_dev, &policy->freq_table); kfree(priv); dev_pm_opp_remove_all_dynamic(priv->cpu_dev); @@ -193,17 +190,11 @@ static int scmi_cpufreq_exit(struct cpufreq_policy *policy) return 0; } -static void scmi_cpufreq_ready(struct cpufreq_policy *policy) -{ - struct scmi_data *priv = policy->driver_data; - - priv->cdev = of_cpufreq_cooling_register(policy); -} - static struct cpufreq_driver scmi_cpufreq_driver = { .name = "scmi", .flags = CPUFREQ_STICKY | CPUFREQ_HAVE_GOVERNOR_PER_POLICY | - CPUFREQ_NEED_INITIAL_FREQ_CHECK, + CPUFREQ_NEED_INITIAL_FREQ_CHECK | + CPUFREQ_AUTO_REGISTER_COOLING_DEV, .verify = cpufreq_generic_frequency_table_verify, .attr = cpufreq_generic_attr, .target_index = scmi_cpufreq_set_target, @@ -211,7 +202,6 @@ static struct cpufreq_driver scmi_cpufreq_driver = { .get = scmi_cpufreq_get_rate, .init = scmi_cpufreq_init, .exit = scmi_cpufreq_exit, - .ready = scmi_cpufreq_ready, }; static int scmi_cpufreq_probe(struct scmi_device *sdev) -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Amit Kucheria <amit.kucheria@linaro.org> To: linux-kernel@vger.kernel.org Cc: linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, Sudeep Holla <sudeep.holla@arm.com>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, dianders@chromium.org, swboyd@chromium.org, edubezval@gmail.com, mka@chromium.org, Wei Yongjun <weiyongjun1@huawei.com>, viresh.kumar@linaro.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 8/9] cpufreq: scmi: Use auto-registration of thermal cooling device Date: Mon, 21 Jan 2019 21:10:33 +0530 [thread overview] Message-ID: <c2fe27f06a87d80e4909610a37441e90076434b3.1548084260.git.amit.kucheria@linaro.org> (raw) In-Reply-To: <cover.1548084260.git.amit.kucheria@linaro.org> In-Reply-To: <cover.1548084260.git.amit.kucheria@linaro.org> Use the CPUFREQ_AUTO_REGISTER_COOLING_DEV flag to allow cpufreq core to automatically register as a thermal cooling device. This allows removal of boiler plate code from the driver. Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> Acked-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/cpufreq/scmi-cpufreq.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c index 242c3370544e..b19e9d129f8f 100644 --- a/drivers/cpufreq/scmi-cpufreq.c +++ b/drivers/cpufreq/scmi-cpufreq.c @@ -11,7 +11,6 @@ #include <linux/cpu.h> #include <linux/cpufreq.h> #include <linux/cpumask.h> -#include <linux/cpu_cooling.h> #include <linux/export.h> #include <linux/module.h> #include <linux/pm_opp.h> @@ -22,7 +21,6 @@ struct scmi_data { int domain_id; struct device *cpu_dev; - struct thermal_cooling_device *cdev; }; static const struct scmi_handle *handle; @@ -185,7 +183,6 @@ static int scmi_cpufreq_exit(struct cpufreq_policy *policy) { struct scmi_data *priv = policy->driver_data; - cpufreq_cooling_unregister(priv->cdev); dev_pm_opp_free_cpufreq_table(priv->cpu_dev, &policy->freq_table); kfree(priv); dev_pm_opp_remove_all_dynamic(priv->cpu_dev); @@ -193,17 +190,11 @@ static int scmi_cpufreq_exit(struct cpufreq_policy *policy) return 0; } -static void scmi_cpufreq_ready(struct cpufreq_policy *policy) -{ - struct scmi_data *priv = policy->driver_data; - - priv->cdev = of_cpufreq_cooling_register(policy); -} - static struct cpufreq_driver scmi_cpufreq_driver = { .name = "scmi", .flags = CPUFREQ_STICKY | CPUFREQ_HAVE_GOVERNOR_PER_POLICY | - CPUFREQ_NEED_INITIAL_FREQ_CHECK, + CPUFREQ_NEED_INITIAL_FREQ_CHECK | + CPUFREQ_AUTO_REGISTER_COOLING_DEV, .verify = cpufreq_generic_frequency_table_verify, .attr = cpufreq_generic_attr, .target_index = scmi_cpufreq_set_target, @@ -211,7 +202,6 @@ static struct cpufreq_driver scmi_cpufreq_driver = { .get = scmi_cpufreq_get_rate, .init = scmi_cpufreq_init, .exit = scmi_cpufreq_exit, - .ready = scmi_cpufreq_ready, }; static int scmi_cpufreq_probe(struct scmi_device *sdev) -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-21 15:40 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-21 15:40 [PATCH v2 0/9] cpufreq: Add flag to auto-register as cooling Amit Kucheria 2019-01-21 15:40 ` Amit Kucheria 2019-01-21 15:40 ` Amit Kucheria 2019-01-21 15:40 ` [PATCH v2 1/9] thermal: cpu_cooling: Require thermal core to be compiled in Amit Kucheria 2019-01-23 10:34 ` Viresh Kumar 2019-01-23 10:52 ` Amit Kucheria 2019-01-23 10:54 ` Rafael J. Wysocki 2019-01-21 15:40 ` [PATCH v2 2/9] cpufreq: Auto-register the driver as a thermal cooling device if asked Amit Kucheria 2019-01-23 10:36 ` Viresh Kumar 2019-01-23 10:39 ` Rafael J. Wysocki 2019-01-23 10:43 ` Viresh Kumar 2019-01-23 10:44 ` Viresh Kumar 2019-01-23 10:53 ` Rafael J. Wysocki 2019-01-21 15:40 ` [PATCH v2 3/9] cpufreq: qcom-hw: Register as a cpufreq cooling device Amit Kucheria 2019-01-21 15:40 ` [PATCH v2 4/9] cpufreq: imx6q: Use auto-registration of thermal " Amit Kucheria 2019-01-21 15:40 ` [PATCH v2 5/9] cpufreq: cpufreq-dt: " Amit Kucheria 2019-01-21 15:40 ` [PATCH v2 6/9] cpufreq: mediatek: " Amit Kucheria 2019-01-21 15:40 ` Amit Kucheria 2019-01-21 15:40 ` [PATCH v2 7/9] cpufreq: qoriq: " Amit Kucheria 2019-01-21 15:40 ` Amit Kucheria [this message] 2019-01-21 15:40 ` [PATCH v2 8/9] cpufreq: scmi: " Amit Kucheria 2019-01-21 15:40 ` [PATCH v2 9/9] cpufreq: scpi: " Amit Kucheria 2019-01-21 15:40 ` Amit Kucheria
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c2fe27f06a87d80e4909610a37441e90076434b3.1548084260.git.amit.kucheria@linaro.org \ --to=amit.kucheria@linaro.org \ --cc=dianders@chromium.org \ --cc=edubezval@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=mka@chromium.org \ --cc=rjw@rjwysocki.net \ --cc=sudeep.holla@arm.com \ --cc=swboyd@chromium.org \ --cc=viresh.kumar@linaro.org \ --cc=weiyongjun1@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.