From: BALATON Zoltan <balaton@eik.bme.hu>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Richard Henderson <richard.henderson@linaro.org>,
Magnus Damm <magnus.damm@gmail.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: [PATCH v3 13/18] hw/intc/sh_intc: Remove excessive parenthesis
Date: Wed, 27 Oct 2021 23:54:31 +0200 [thread overview]
Message-ID: <c348abc5e52babc9f5f323184761b54888421208.1635371671.git.balaton@eik.bme.hu> (raw)
In-Reply-To: <cover.1635371671.git.balaton@eik.bme.hu>
Drop unneded parenthesis and split up one complex expression to write
it with less brackets so it's easier to follow.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
hw/intc/sh_intc.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/hw/intc/sh_intc.c b/hw/intc/sh_intc.c
index 54803bc2ca..537fc503d4 100644
--- a/hw/intc/sh_intc.c
+++ b/hw/intc/sh_intc.c
@@ -23,7 +23,7 @@ void sh_intc_toggle_source(struct intc_source *source,
int pending_changed = 0;
int old_pending;
- if ((source->enable_count == source->enable_max) && (enable_adj == -1)) {
+ if (source->enable_count == source->enable_max && enable_adj == -1) {
enable_changed = -1;
}
source->enable_count += enable_adj;
@@ -68,7 +68,7 @@ void sh_intc_toggle_source(struct intc_source *source,
static void sh_intc_set_irq(void *opaque, int n, int level)
{
struct intc_desc *desc = opaque;
- struct intc_source *source = &(desc->sources[n]);
+ struct intc_source *source = &desc->sources[n];
if (level && !source->asserted) {
sh_intc_toggle_source(source, 0, 1);
@@ -164,7 +164,7 @@ static void sh_intc_locate(struct intc_desc *desc,
*modep = mode | INTC_MODE_IS_PRIO;
*datap = &pr->value;
*enums = pr->enum_ids;
- *first = (pr->reg_width / pr->field_width) - 1;
+ *first = pr->reg_width / pr->field_width - 1;
*width = pr->field_width;
return;
}
@@ -245,7 +245,8 @@ static void sh_intc_write(void *opaque, hwaddr offset,
}
for (k = 0; k <= first; k++) {
- mask = ((1 << width) - 1) << ((first - k) * width);
+ mask = (1 << width) - 1;
+ mask <<= (first - k) * width;
if ((*valuep & mask) == (value & mask)) {
continue;
--
2.21.4
next prev parent reply other threads:[~2021-10-27 22:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 21:54 [PATCH v3 00/18] More SH4 clean ups BALATON Zoltan
2021-10-27 21:54 ` [PATCH v3 18/18] hw/intc/sh_intc: Simplify allocating sources array BALATON Zoltan
2021-10-27 21:54 ` [PATCH v3 03/18] hw/sh4: Change debug printfs to traces BALATON Zoltan
2021-10-28 0:31 ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 16/18] hw/intc/sh_intc: Replace abort() with g_assert_not_reached() BALATON Zoltan
2021-10-28 0:57 ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 01/18] hw/sh4: Fix typos in a comment BALATON Zoltan
2021-10-27 21:54 ` [PATCH v3 14/18] hw/intc/sh_intc: Use array index instead of pointer arithmetics BALATON Zoltan
2021-10-28 0:55 ` Richard Henderson
2021-10-27 21:54 ` BALATON Zoltan [this message]
2021-10-28 0:54 ` [PATCH v3 13/18] hw/intc/sh_intc: Remove excessive parenthesis Richard Henderson
2021-10-27 21:54 ` [PATCH v3 06/18] hw/char/sh_serial: QOM-ify BALATON Zoltan
2021-10-27 21:54 ` [PATCH v3 11/18] hw/intc/sh_intc: Drop another useless macro BALATON Zoltan
2021-10-28 0:52 ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 10/18] hw/intc/sh_intc: Rename iomem region BALATON Zoltan
2021-10-28 0:39 ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 17/18] hw/intc/sh_intc: Avoid using continue in loops BALATON Zoltan
2021-10-28 0:58 ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 05/18] hw/char/sh_serial: Rename type sh_serial_state to SHSerialState BALATON Zoltan
2021-10-28 0:31 ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 08/18] hw/intc/sh_intc: Use existing macro instead of local one BALATON Zoltan
2021-10-28 0:37 ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 02/18] hw//sh4: Use qemu_log instead of fprintf to stderr BALATON Zoltan
2021-10-27 21:54 ` [PATCH v3 15/18] hw/sh4/sh_intc: Inline and drop sh_intc_source() function BALATON Zoltan
2021-10-27 21:54 ` [PATCH v3 04/18] hw/sh4/r2d: Use error_report instead of fprintf to stderr BALATON Zoltan
2021-10-27 21:54 ` [PATCH v3 09/18] hw/intc/sh_intc: Turn some defines into an enum BALATON Zoltan
2021-10-27 21:54 ` [PATCH v3 07/18] hw/char/sh_serial: Add device id to trace output BALATON Zoltan
2021-10-28 0:36 ` Richard Henderson
2021-10-27 21:54 ` [PATCH v3 12/18] hw/intc/sh_intc: Move sh_intc_register() closer to its only user BALATON Zoltan
2021-10-28 0:52 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c348abc5e52babc9f5f323184761b54888421208.1635371671.git.balaton@eik.bme.hu \
--to=balaton@eik.bme.hu \
--cc=magnus.damm@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.