All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthias Brugger <matthias.bgg@gmail.com>
To: qii.wang@mediatek.com, wsa@the-dreams.de, yingjoe.chen@mediatek.com
Cc: linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	Matthias Brugger <mbrugger@suse.com>
Subject: [PATCH] i2c: mediatek: Fix i2c_spec_values description
Date: Thu, 6 Aug 2020 11:48:37 +0200	[thread overview]
Message-ID: <c410f784-7b51-0d65-7a41-3845214dd273@gmail.com> (raw)

The struct i2c_spec_values have it's members documented but is missing the 
starting '@', which leads to warings like:

drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member 
'min_low_ns' not described in 'i2c_spec_values'

Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
---
  drivers/i2c/busses/i2c-mt65xx.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index e889f74703e4..f51b35fc400f 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -253,10 +253,10 @@ struct mtk_i2c {

  /**
   * struct i2c_spec_values:
- * min_low_ns: min LOW period of the SCL clock
- * min_su_sta_ns: min set-up time for a repeated START condition
- * max_hd_dat_ns: max data hold time
- * min_su_dat_ns: min data set-up time
+ * @min_low_ns: min LOW period of the SCL clock
+ * @min_su_sta_ns: min set-up time for a repeated START condition
+ * @max_hd_dat_ns: max data hold time
+ * @min_su_dat_ns: min data set-up time
   */
  struct i2c_spec_values {
  	unsigned int min_low_ns;
-- 
2.27.0

WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: qii.wang@mediatek.com, wsa@the-dreams.de, yingjoe.chen@mediatek.com
Cc: Matthias Brugger <mbrugger@suse.com>,
	linux-mediatek@lists.infradead.org, linux-i2c@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] i2c: mediatek: Fix i2c_spec_values description
Date: Thu, 6 Aug 2020 11:48:37 +0200	[thread overview]
Message-ID: <c410f784-7b51-0d65-7a41-3845214dd273@gmail.com> (raw)

The struct i2c_spec_values have it's members documented but is missing the 
starting '@', which leads to warings like:

drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member 
'min_low_ns' not described in 'i2c_spec_values'

Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
---
  drivers/i2c/busses/i2c-mt65xx.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index e889f74703e4..f51b35fc400f 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -253,10 +253,10 @@ struct mtk_i2c {

  /**
   * struct i2c_spec_values:
- * min_low_ns: min LOW period of the SCL clock
- * min_su_sta_ns: min set-up time for a repeated START condition
- * max_hd_dat_ns: max data hold time
- * min_su_dat_ns: min data set-up time
+ * @min_low_ns: min LOW period of the SCL clock
+ * @min_su_sta_ns: min set-up time for a repeated START condition
+ * @max_hd_dat_ns: max data hold time
+ * @min_su_dat_ns: min data set-up time
   */
  struct i2c_spec_values {
  	unsigned int min_low_ns;
-- 
2.27.0

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: qii.wang@mediatek.com, wsa@the-dreams.de, yingjoe.chen@mediatek.com
Cc: Matthias Brugger <mbrugger@suse.com>,
	linux-mediatek@lists.infradead.org, linux-i2c@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] i2c: mediatek: Fix i2c_spec_values description
Date: Thu, 6 Aug 2020 11:48:37 +0200	[thread overview]
Message-ID: <c410f784-7b51-0d65-7a41-3845214dd273@gmail.com> (raw)

The struct i2c_spec_values have it's members documented but is missing the 
starting '@', which leads to warings like:

drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member 
'min_low_ns' not described in 'i2c_spec_values'

Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
---
  drivers/i2c/busses/i2c-mt65xx.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index e889f74703e4..f51b35fc400f 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -253,10 +253,10 @@ struct mtk_i2c {

  /**
   * struct i2c_spec_values:
- * min_low_ns: min LOW period of the SCL clock
- * min_su_sta_ns: min set-up time for a repeated START condition
- * max_hd_dat_ns: max data hold time
- * min_su_dat_ns: min data set-up time
+ * @min_low_ns: min LOW period of the SCL clock
+ * @min_su_sta_ns: min set-up time for a repeated START condition
+ * @max_hd_dat_ns: max data hold time
+ * @min_su_dat_ns: min data set-up time
   */
  struct i2c_spec_values {
  	unsigned int min_low_ns;
-- 
2.27.0

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2020-08-06 11:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-06  9:48 Matthias Brugger [this message]
2020-08-06  9:48 ` [PATCH] i2c: mediatek: Fix i2c_spec_values description Matthias Brugger
2020-08-06  9:48 ` Matthias Brugger
2020-08-06 11:06 ` Qii Wang
2020-08-06 11:06   ` Qii Wang
2020-08-06 11:06   ` Qii Wang
2020-08-06 13:35   ` Matthias Brugger
2020-08-06 13:35     ` Matthias Brugger
2020-08-06 13:35     ` Matthias Brugger
2020-08-07  1:05     ` Qii Wang
2020-08-07  1:05       ` Qii Wang
2020-08-07  1:05       ` Qii Wang
2020-08-10  9:40 ` wsa
2020-08-10  9:40   ` wsa
2020-08-10  9:40   ` wsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c410f784-7b51-0d65-7a41-3845214dd273@gmail.com \
    --to=matthias.bgg@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mbrugger@suse.com \
    --cc=qii.wang@mediatek.com \
    --cc=wsa@the-dreams.de \
    --cc=yingjoe.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.