All of lore.kernel.org
 help / color / mirror / Atom feed
From: Silvio Fricke <silvio.fricke@gmail.com>
To: linux-btrfs@vger.kernel.org
Cc: Silvio Fricke <silvio.fricke@gmail.com>
Subject: [PATCH 03/11] btrfs-progs: use calloc instead of malloc+memset for chunk-recover.c
Date: Tue, 29 Sep 2015 19:10:38 +0200	[thread overview]
Message-ID: <c5aaa76ff11a328e0f07d76052b067d341aa097b.1443546001.git.silvio.fricke@gmail.com> (raw)
In-Reply-To: <cover.1443546000.git.silvio.fricke@gmail.com>
In-Reply-To: <cover.1443546000.git.silvio.fricke@gmail.com>

This patch is generated from a coccinelle semantic patch:

	identifier t;
	expression e;
	statement s;
	@@
	-t = malloc(e);
	+t = calloc(1, e);
	(
	if (!t) s
	|
	if (t == NULL) s
	|
	)
	-memset(t, 0, e);

Signed-off-by: Silvio Fricke <silvio.fricke@gmail.com>
---
 chunk-recover.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/chunk-recover.c b/chunk-recover.c
index 1fb04f7..d0ca920 100644
--- a/chunk-recover.c
+++ b/chunk-recover.c
@@ -85,13 +85,12 @@ static struct extent_record *btrfs_new_extent_record(struct extent_buffer *eb)
 {
 	struct extent_record *rec;
 
-	rec = malloc(sizeof(*rec));
+	rec = calloc(1, sizeof(*rec));
 	if (!rec) {
 		fprintf(stderr, "Fail to allocate memory for extent record.\n");
 		exit(1);
 	}
 
-	memset(rec, 0, sizeof(*rec));
 	rec->cache.start = btrfs_header_bytenr(eb);
 	rec->cache.size = eb->len;
 	rec->generation = btrfs_header_generation(eb);
@@ -2228,10 +2227,9 @@ static int btrfs_recover_chunks(struct recover_control *rc)
 		nstripes = btrfs_get_device_extents(bg->objectid,
 						    &rc->devext.no_chunk_orphans,
 						    &devexts);
-		chunk = malloc(btrfs_chunk_record_size(nstripes));
+		chunk = calloc(1, btrfs_chunk_record_size(nstripes));
 		if (!chunk)
 			return -ENOMEM;
-		memset(chunk, 0, btrfs_chunk_record_size(nstripes));
 		INIT_LIST_HEAD(&chunk->dextents);
 		chunk->bg_rec = bg;
 		chunk->cache.start = bg->objectid;
-- 
2.5.3


  parent reply	other threads:[~2015-09-29 17:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1443459879.git.silvio.fricke@gmail.com>
2015-09-29 17:10 ` [PATCH 00/11] using of calloc instead of malloc+memset Silvio Fricke
2015-09-30 16:48   ` David Sterba
2015-09-30 16:54   ` David Sterba
2015-09-29 17:10 ` [PATCH 01/11] btrfs-progs: use calloc instead of malloc+memset for btrfs-image.c Silvio Fricke
2015-09-29 17:10 ` [PATCH 02/11] btrfs-progs: use calloc instead of malloc+memset for btrfs-list.c Silvio Fricke
2015-09-29 17:10 ` Silvio Fricke [this message]
2015-09-29 17:10 ` [PATCH 04/11] btrfs-progs: use calloc instead of malloc+memset for cmds-check.c Silvio Fricke
2015-09-29 17:10 ` [PATCH 05/11] btrfs-progs: use calloc instead of malloc+memset for disk-io.c Silvio Fricke
2015-09-29 17:10 ` [PATCH 06/11] btrfs-progs: use calloc instead of malloc+memset for extent_io.c Silvio Fricke
2015-09-29 17:10 ` [PATCH 07/11] btrfs-progs: use calloc instead of malloc+memset for mkfs.c Silvio Fricke
2015-09-29 17:10 ` [PATCH 08/11] btrfs-progs: use calloc instead of malloc+memset for qgroup.c Silvio Fricke
2015-09-29 17:10 ` [PATCH 09/11] btrfs-progs: use calloc instead of malloc+memset for quick-test.c Silvio Fricke
2015-09-29 17:10 ` [PATCH 10/11] btrfs-progs: use calloc instead of malloc+memset for volumes.c Silvio Fricke
2015-09-29 17:10 ` [PATCH 11/11] btrfs-progs: check: fix memset range Silvio Fricke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5aaa76ff11a328e0f07d76052b067d341aa097b.1443546001.git.silvio.fricke@gmail.com \
    --to=silvio.fricke@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.