From: Viresh Kumar <viresh.kumar@linaro.org> To: Mark Rutland <mark.rutland@arm.com>, Rob Herring <robh+dt@kernel.org>, arm@kernel.org, Masahiro Yamada <yamada.masahiro@socionext.com> Cc: Viresh Kumar <viresh.kumar@linaro.org>, devicetree@vger.kernel.org, Vincent Guittot <vincent.guittot@linaro.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 10/10] ARM64: dts: uniphier: Add all CPUs in cooling maps Date: Fri, 16 Nov 2018 15:34:33 +0530 [thread overview] Message-ID: <c759699a44189aed078186fd19089d2f44d988e3.1542362530.git.viresh.kumar@linaro.org> (raw) In-Reply-To: <cover.1542362530.git.viresh.kumar@linaro.org> Each CPU can (and does) participate in cooling down the system but the DT only captures a handful of them, normally CPU0, in the cooling maps. Things work by chance currently as under normal circumstances its the first CPU of each cluster which is used by the operating systems to probe the cooling devices. But as soon as this CPU ordering changes and any other CPU is used to bring up the cooling device, we will start seeing failures. Also the DT is rather incomplete when we list only one CPU in the cooling maps, as the hardware doesn't have any such limitations. Update cooling maps to include all devices affected by individual trip points. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi index d7e2d8969601..4a0c46cb11cd 100644 --- a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi +++ b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi @@ -206,13 +206,10 @@ cooling-maps { map0 { trip = <&cpu_alert>; - cooling-device = <&cpu0 - THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; - }; - map1 { - trip = <&cpu_alert>; - cooling-device = <&cpu2 - THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; }; }; -- 2.19.1.568.g152ad8e3369a
WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@linaro.org (Viresh Kumar) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 10/10] ARM64: dts: uniphier: Add all CPUs in cooling maps Date: Fri, 16 Nov 2018 15:34:33 +0530 [thread overview] Message-ID: <c759699a44189aed078186fd19089d2f44d988e3.1542362530.git.viresh.kumar@linaro.org> (raw) In-Reply-To: <cover.1542362530.git.viresh.kumar@linaro.org> Each CPU can (and does) participate in cooling down the system but the DT only captures a handful of them, normally CPU0, in the cooling maps. Things work by chance currently as under normal circumstances its the first CPU of each cluster which is used by the operating systems to probe the cooling devices. But as soon as this CPU ordering changes and any other CPU is used to bring up the cooling device, we will start seeing failures. Also the DT is rather incomplete when we list only one CPU in the cooling maps, as the hardware doesn't have any such limitations. Update cooling maps to include all devices affected by individual trip points. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi index d7e2d8969601..4a0c46cb11cd 100644 --- a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi +++ b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi @@ -206,13 +206,10 @@ cooling-maps { map0 { trip = <&cpu_alert>; - cooling-device = <&cpu0 - THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; - }; - map1 { - trip = <&cpu_alert>; - cooling-device = <&cpu2 - THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; }; }; -- 2.19.1.568.g152ad8e3369a
next prev parent reply other threads:[~2018-11-16 10:05 UTC|newest] Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-16 10:04 [PATCH 00/10] ARM64: dts: Fix incomplete cooling-maps Viresh Kumar 2018-11-16 10:04 ` Viresh Kumar 2018-11-16 10:04 ` Viresh Kumar 2018-11-16 10:04 ` [PATCH 01/10] ARM64: dts: amlogic: Add all CPUs in cooling maps Viresh Kumar 2018-11-16 10:04 ` Viresh Kumar 2018-11-16 10:04 ` Viresh Kumar 2018-11-16 10:07 ` Neil Armstrong 2018-11-16 10:07 ` Neil Armstrong 2018-11-16 10:07 ` Neil Armstrong 2018-11-29 0:35 ` Kevin Hilman 2018-11-29 0:35 ` Kevin Hilman 2018-11-29 0:35 ` Kevin Hilman 2018-11-29 0:35 ` Kevin Hilman 2018-11-16 10:04 ` [PATCH 02/10] ARM64: dts: exynos: " Viresh Kumar 2018-11-16 10:04 ` Viresh Kumar 2018-11-18 14:20 ` Krzysztof Kozlowski 2018-11-18 14:20 ` Krzysztof Kozlowski 2018-11-16 10:04 ` [PATCH 03/10] ARM64: dts: fsl: " Viresh Kumar 2018-11-16 10:04 ` Viresh Kumar 2018-11-28 2:46 ` Shawn Guo 2018-11-28 2:46 ` Shawn Guo 2018-11-16 10:04 ` [PATCH 04/10] arm64: dts: hi3660: Add missing cooling device properties for CPUs Viresh Kumar 2018-11-16 10:04 ` Viresh Kumar 2018-11-29 15:44 ` Wei Xu 2018-11-29 15:44 ` Wei Xu 2018-11-29 15:44 ` Wei Xu 2018-11-16 10:04 ` [PATCH 05/10] ARM64: dts: hisilicon: Add all CPUs in cooling maps Viresh Kumar 2018-11-16 10:04 ` Viresh Kumar 2018-11-29 15:45 ` Wei Xu 2018-11-29 15:45 ` Wei Xu 2018-11-29 15:45 ` Wei Xu 2018-11-16 10:04 ` [PATCH 06/10] ARM64: dts: mediatek: " Viresh Kumar 2018-11-16 10:04 ` Viresh Kumar 2018-11-16 10:04 ` [PATCH 07/10] ARM64: dts: msm8916: " Viresh Kumar 2018-11-16 10:04 ` Viresh Kumar 2018-11-16 10:04 ` [PATCH 08/10] ARM64: dts: renesas: " Viresh Kumar 2018-11-16 10:04 ` Viresh Kumar 2018-11-23 12:51 ` Simon Horman 2018-11-23 12:51 ` Simon Horman 2018-11-16 10:04 ` [PATCH 09/10] ARM64: dts: rockchip: " Viresh Kumar 2018-11-16 10:04 ` Viresh Kumar 2018-11-26 13:16 ` Heiko Stuebner 2018-11-26 13:16 ` Heiko Stuebner 2018-11-16 10:04 ` Viresh Kumar [this message] 2018-11-16 10:04 ` [PATCH 10/10] ARM64: dts: uniphier: " Viresh Kumar 2018-11-26 15:49 ` Masahiro Yamada 2018-11-26 15:49 ` Masahiro Yamada
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c759699a44189aed078186fd19089d2f44d988e3.1542362530.git.viresh.kumar@linaro.org \ --to=viresh.kumar@linaro.org \ --cc=arm@kernel.org \ --cc=daniel.lezcano@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=vincent.guittot@linaro.org \ --cc=yamada.masahiro@socionext.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.