From: Heiner Kallweit <hkallweit1@gmail.com> To: Wolfram Sang <wsa@the-dreams.de> Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>, linux-amlogic@lists.infradead.org Subject: [PATCH 07/12] i2c: meson: improve interrupt handler and detect spurious interrupts Date: Wed, 8 Mar 2017 07:47:16 +0100 [thread overview] Message-ID: <c772d1d8-eaae-43c2-c206-7c349c134db8@gmail.com> (raw) In-Reply-To: <d5f0545a-fb4c-b436-20f5-7df9d10605b1@gmail.com> If state is STATE_IDLE no interrupt should occur. Detect this case and warn. In addition move resetting REG_CTRL_START bit to the start of the interrupt handler and remove a unneeded REG_CTRL_START bit reset in meson_i2c_xfer_msg. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/i2c/busses/i2c-meson.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/i2c/busses/i2c-meson.c b/drivers/i2c/busses/i2c-meson.c index 81304840..b3b881f9 100644 --- a/drivers/i2c/busses/i2c-meson.c +++ b/drivers/i2c/busses/i2c-meson.c @@ -233,7 +233,15 @@ static irqreturn_t meson_i2c_irq(int irqno, void *dev_id) dev_dbg(i2c->dev, "irq: state %d, pos %d, count %d, ctrl %08x\n", i2c->state, i2c->pos, i2c->count, ctrl); - if (ctrl & REG_CTRL_ERROR && i2c->state != STATE_IDLE) { + meson_i2c_set_mask(i2c, REG_CTRL, REG_CTRL_START, 0); + + if (i2c->state == STATE_IDLE) { + dev_notice(i2c->dev, "spurious interrupt detected\n"); + spin_unlock(&i2c->lock); + return IRQ_NONE; + } + + if (ctrl & REG_CTRL_ERROR) { /* * The bit is set when the IGNORE_NAK bit is cleared * and the device didn't respond. In this case, the @@ -276,15 +284,12 @@ static irqreturn_t meson_i2c_irq(int irqno, void *dev_id) i2c->state = STATE_IDLE; complete(&i2c->done); break; - case STATE_IDLE: - break; } out: if (i2c->state != STATE_IDLE) { /* Restart the processing */ meson_i2c_write_tokens(i2c); - meson_i2c_set_mask(i2c, REG_CTRL, REG_CTRL_START, 0); meson_i2c_set_mask(i2c, REG_CTRL, REG_CTRL_START, REG_CTRL_START); } @@ -344,9 +349,6 @@ static int meson_i2c_xfer_msg(struct meson_i2c *i2c, struct i2c_msg *msg, */ spin_lock_irqsave(&i2c->lock, flags); - /* Abort any active operation */ - meson_i2c_set_mask(i2c, REG_CTRL, REG_CTRL_START, 0); - if (!time_left) { i2c->state = STATE_IDLE; ret = -ETIMEDOUT; -- 2.12.0
WARNING: multiple messages have this Message-ID (diff)
From: hkallweit1@gmail.com (Heiner Kallweit) To: linus-amlogic@lists.infradead.org Subject: [PATCH 07/12] i2c: meson: improve interrupt handler and detect spurious interrupts Date: Wed, 8 Mar 2017 07:47:16 +0100 [thread overview] Message-ID: <c772d1d8-eaae-43c2-c206-7c349c134db8@gmail.com> (raw) In-Reply-To: <d5f0545a-fb4c-b436-20f5-7df9d10605b1@gmail.com> If state is STATE_IDLE no interrupt should occur. Detect this case and warn. In addition move resetting REG_CTRL_START bit to the start of the interrupt handler and remove a unneeded REG_CTRL_START bit reset in meson_i2c_xfer_msg. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/i2c/busses/i2c-meson.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/i2c/busses/i2c-meson.c b/drivers/i2c/busses/i2c-meson.c index 81304840..b3b881f9 100644 --- a/drivers/i2c/busses/i2c-meson.c +++ b/drivers/i2c/busses/i2c-meson.c @@ -233,7 +233,15 @@ static irqreturn_t meson_i2c_irq(int irqno, void *dev_id) dev_dbg(i2c->dev, "irq: state %d, pos %d, count %d, ctrl %08x\n", i2c->state, i2c->pos, i2c->count, ctrl); - if (ctrl & REG_CTRL_ERROR && i2c->state != STATE_IDLE) { + meson_i2c_set_mask(i2c, REG_CTRL, REG_CTRL_START, 0); + + if (i2c->state == STATE_IDLE) { + dev_notice(i2c->dev, "spurious interrupt detected\n"); + spin_unlock(&i2c->lock); + return IRQ_NONE; + } + + if (ctrl & REG_CTRL_ERROR) { /* * The bit is set when the IGNORE_NAK bit is cleared * and the device didn't respond. In this case, the @@ -276,15 +284,12 @@ static irqreturn_t meson_i2c_irq(int irqno, void *dev_id) i2c->state = STATE_IDLE; complete(&i2c->done); break; - case STATE_IDLE: - break; } out: if (i2c->state != STATE_IDLE) { /* Restart the processing */ meson_i2c_write_tokens(i2c); - meson_i2c_set_mask(i2c, REG_CTRL, REG_CTRL_START, 0); meson_i2c_set_mask(i2c, REG_CTRL, REG_CTRL_START, REG_CTRL_START); } @@ -344,9 +349,6 @@ static int meson_i2c_xfer_msg(struct meson_i2c *i2c, struct i2c_msg *msg, */ spin_lock_irqsave(&i2c->lock, flags); - /* Abort any active operation */ - meson_i2c_set_mask(i2c, REG_CTRL, REG_CTRL_START, 0); - if (!time_left) { i2c->state = STATE_IDLE; ret = -ETIMEDOUT; -- 2.12.0
next prev parent reply other threads:[~2017-03-08 6:50 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-08 6:41 [PATCH 00/12] i2c: meson: series with improvements Heiner Kallweit 2017-03-08 6:41 ` Heiner Kallweit 2017-03-08 6:42 ` [PATCH 01/12] i2c: meson: use min instead of min_t where min_t isn't needed Heiner Kallweit 2017-03-08 6:42 ` Heiner Kallweit 2017-03-08 9:25 ` Jerome Brunet 2017-03-08 9:25 ` Jerome Brunet 2017-03-08 6:43 ` [PATCH 02/12] i2c: meson: remove member irq from struct meson_i2c Heiner Kallweit 2017-03-08 6:43 ` Heiner Kallweit 2017-03-08 9:07 ` Jerome Brunet 2017-03-08 9:07 ` Jerome Brunet 2017-03-08 6:44 ` [PATCH 03/12] i2c: meson: use i2c core for DT clock-frequency parsing Heiner Kallweit 2017-03-08 6:44 ` Heiner Kallweit 2017-03-08 9:10 ` Jerome Brunet 2017-03-08 9:10 ` Jerome Brunet 2017-03-08 6:44 ` [PATCH 04/12] i2c: meson: use full 12 bits for clock divider Heiner Kallweit 2017-03-08 6:44 ` Heiner Kallweit 2017-03-08 9:19 ` Jerome Brunet 2017-03-08 9:19 ` Jerome Brunet 2017-03-08 6:45 ` [PATCH 05/12] i2c: meson: set clock divider in probe instead of setting it for each transfer Heiner Kallweit 2017-03-08 6:45 ` Heiner Kallweit 2017-03-08 6:46 ` [PATCH 06/12] i2c: meson: remove variable count from meson_i2c_xfer Heiner Kallweit 2017-03-08 6:46 ` Heiner Kallweit 2017-03-08 9:28 ` Jerome Brunet 2017-03-08 9:28 ` Jerome Brunet 2017-03-08 6:47 ` Heiner Kallweit [this message] 2017-03-08 6:47 ` [PATCH 07/12] i2c: meson: improve interrupt handler and detect spurious interrupts Heiner Kallweit 2017-03-08 9:50 ` Jerome Brunet 2017-03-08 9:50 ` Jerome Brunet 2017-03-08 21:02 ` Heiner Kallweit 2017-03-08 21:02 ` Heiner Kallweit 2017-03-09 20:16 ` Heiner Kallweit 2017-03-09 20:16 ` Heiner Kallweit 2017-03-08 6:47 ` [PATCH 08/12] i2c: meson: explicitly ignore messages with length zero Heiner Kallweit 2017-03-08 6:47 ` Heiner Kallweit [not found] ` <CANe6Qb9nKdLnOcwEwuk8NXEB+fxW2S_kkzP+U+qygYhNqz0Y0w@mail.gmail.com> 2017-03-08 22:03 ` Heiner Kallweit 2017-03-08 22:03 ` Heiner Kallweit 2017-03-08 6:48 ` [PATCH 09/12] i2c: meson: don't create separate token chain just for the stop command Heiner Kallweit 2017-03-08 6:48 ` Heiner Kallweit 2017-03-08 6:49 ` [PATCH 10/12] i2c: meson: remove meson_i2c_write_tokens Heiner Kallweit 2017-03-08 6:49 ` Heiner Kallweit 2017-03-08 6:49 ` [PATCH 11/12] i2c: meson: improve and simplify interrupt handler Heiner Kallweit 2017-03-08 6:49 ` Heiner Kallweit 2017-03-08 6:50 ` [PATCH 12/12] i2c: meson: use state in meson_i2c_prepare_xfer Heiner Kallweit 2017-03-08 6:50 ` Heiner Kallweit 2017-03-08 9:34 ` [PATCH 00/12] i2c: meson: series with improvements Jerome Brunet 2017-03-08 9:34 ` Jerome Brunet 2017-03-08 20:49 ` Heiner Kallweit 2017-03-08 20:49 ` Heiner Kallweit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c772d1d8-eaae-43c2-c206-7c349c134db8@gmail.com \ --to=hkallweit1@gmail.com \ --cc=linux-amlogic@lists.infradead.org \ --cc=linux-i2c@vger.kernel.org \ --cc=wsa@the-dreams.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.