All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kyle Mahlkuch <kmahlkuc@linux.vnet.ibm.com>
To: dm-devel@redhat.com
Cc: kylemahl@linux.vnet.ibm.com
Subject: [PATCH] libmultipath: Increase SERIAL_SIZE to 128 bytes
Date: Thu, 13 Dec 2018 10:10:33 -0600	[thread overview]
Message-ID: <cad99184-26da-c914-84cc-1a49e5e8300a@linux.vnet.ibm.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 1159 bytes --]

Certain IBM FlashSystem LUNs can return up to 85 bytes of serial
number in the Unit Serial Number VPD page, which is larger than
the current SERIAL_SIZE definition of 65 bytes. Since the max
size of this field does not appear to be defined in SPC, increasing
to 128 bytes should hopefully prevent us from hitting this
in future.

This is an example of a serial number from a FlashSystem:
Unit serial number VPD page:
Unit serial number: 3321360050764008101AB300000000000012204214503IBMfcp

Before this patch multipath returns the error:
Jul 17 11:24:58 | vpd pg80 overflow, 85/65 bytes required

After the patch is applied the error no longer occur.

Signed-off-by: Kyle Mahlkuch<kmahlkuc@linux.vnet.ibm.com>
---
  libmultipath/structs.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libmultipath/structs.h b/libmultipath/structs.h
index bfa660a..00a1b1a 100644
--- a/libmultipath/structs.h
+++ b/libmultipath/structs.h
@@ -8,7 +8,7 @@
  #include "byteorder.h"

  #define WWID_SIZE		128
-#define SERIAL_SIZE		65
+#define SERIAL_SIZE		128
  #define NODE_NAME_SIZE		224
  #define PATH_STR_SIZE		16
  #define PARAMS_SIZE		4096
-- 1.8.3.1


[-- Attachment #1.2: Type: text/html, Size: 1453 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



             reply	other threads:[~2018-12-13 16:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-13 16:10 Kyle Mahlkuch [this message]
2018-12-14  9:59 ` [PATCH] libmultipath: Increase SERIAL_SIZE to 128 bytes Martin Wilck
2018-12-14 10:10   ` Martin Wilck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cad99184-26da-c914-84cc-1a49e5e8300a@linux.vnet.ibm.com \
    --to=kmahlkuc@linux.vnet.ibm.com \
    --cc=dm-devel@redhat.com \
    --cc=kylemahl@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.