From: Claus Hansen Ries <chr@terma.com> To: "netdev@vger.kernel.org" <netdev@vger.kernel.org> Cc: "davem@davemloft.net" <davem@davemloft.net>, "edumazet@google.com" <edumazet@google.com>, "kuba@kernel.org" <kuba@kernel.org>, "pabeni@redhat.com" <pabeni@redhat.com>, "michal.simek@amd.com" <michal.simek@amd.com>, "wei.fang@nxp.com" <wei.fang@nxp.com>, "yangyingliang@huawei.com" <yangyingliang@huawei.com>, "robh@kernel.org" <robh@kernel.org>, "harini.katakam@amd.com" <harini.katakam@amd.com>, "dan.carpenter@linaro.org" <dan.carpenter@linaro.org>, "u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>, "wanghai38@huawei.com" <wanghai38@huawei.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Simon Horman <horms@kernel.org> Subject: [PATCH net v3] net: ll_temac: platform_get_resource replaced by wrong function Date: Thu, 21 Mar 2024 13:08:59 +0000 [thread overview] Message-ID: <cca18f9c630a41c18487729770b492bb@terma.com> (raw) In-Reply-To: <f512ff25a2cd484791757c18facb526c@terma.com> The function platform_get_resource was replaced with devm_platform_ioremap_resource_byname and is called using 0 as name. This eventually ends up in platform_get_resource_byname in the call stack, where it causes a null pointer in strcmp. if (type == resource_type(r) && !strcmp(r->name, name)) It should have been replaced with devm_platform_ioremap_resource. Fixes: bd69058f50d5 ("net: ll_temac: Use devm_platform_ioremap_resource_byname()") Signed-off-by: Claus Hansen Ries <chr@terma.com> Cc: stable@vger.kernel.org Reviewed-by: Simon Horman <horms@kernel.org> --- v3: - Cleanup of patch message v2: https://marc.info/?l=linux-netdev&m=171094427802626&w=2 - fix accidently converting tabs to spaces and wording in commit message v1: https://marc.info/?l=linux-netdev&m=171087828129633&w=2 drivers/net/ethernet/xilinx/ll_temac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c index 9df39cf8b097..1072e2210aed 100644 --- a/drivers/net/ethernet/xilinx/ll_temac_main.c +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c @@ -1443,7 +1443,7 @@ static int temac_probe(struct platform_device *pdev) } /* map device registers */ - lp->regs = devm_platform_ioremap_resource_byname(pdev, 0); + lp->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(lp->regs)) { dev_err(&pdev->dev, "could not map TEMAC registers\n"); return -ENOMEM; base-commit: d95fcdf4961d27a3d17e5c7728367197adc89b8d -- 2.39.3 (Apple Git-146)
WARNING: multiple messages have this Message-ID (diff)
From: Claus Hansen Ries <chr@terma.com> To: "netdev@vger.kernel.org" <netdev@vger.kernel.org> Cc: "davem@davemloft.net" <davem@davemloft.net>, "edumazet@google.com" <edumazet@google.com>, "kuba@kernel.org" <kuba@kernel.org>, "pabeni@redhat.com" <pabeni@redhat.com>, "michal.simek@amd.com" <michal.simek@amd.com>, "wei.fang@nxp.com" <wei.fang@nxp.com>, "yangyingliang@huawei.com" <yangyingliang@huawei.com>, "robh@kernel.org" <robh@kernel.org>, "harini.katakam@amd.com" <harini.katakam@amd.com>, "dan.carpenter@linaro.org" <dan.carpenter@linaro.org>, "u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>, "wanghai38@huawei.com" <wanghai38@huawei.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Simon Horman <horms@kernel.org> Subject: [PATCH net v3] net: ll_temac: platform_get_resource replaced by wrong function Date: Thu, 21 Mar 2024 13:08:59 +0000 [thread overview] Message-ID: <cca18f9c630a41c18487729770b492bb@terma.com> (raw) In-Reply-To: <f512ff25a2cd484791757c18facb526c@terma.com> The function platform_get_resource was replaced with devm_platform_ioremap_resource_byname and is called using 0 as name. This eventually ends up in platform_get_resource_byname in the call stack, where it causes a null pointer in strcmp. if (type == resource_type(r) && !strcmp(r->name, name)) It should have been replaced with devm_platform_ioremap_resource. Fixes: bd69058f50d5 ("net: ll_temac: Use devm_platform_ioremap_resource_byname()") Signed-off-by: Claus Hansen Ries <chr@terma.com> Cc: stable@vger.kernel.org Reviewed-by: Simon Horman <horms@kernel.org> --- v3: - Cleanup of patch message v2: https://marc.info/?l=linux-netdev&m=171094427802626&w=2 - fix accidently converting tabs to spaces and wording in commit message v1: https://marc.info/?l=linux-netdev&m=171087828129633&w=2 drivers/net/ethernet/xilinx/ll_temac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c index 9df39cf8b097..1072e2210aed 100644 --- a/drivers/net/ethernet/xilinx/ll_temac_main.c +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c @@ -1443,7 +1443,7 @@ static int temac_probe(struct platform_device *pdev) } /* map device registers */ - lp->regs = devm_platform_ioremap_resource_byname(pdev, 0); + lp->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(lp->regs)) { dev_err(&pdev->dev, "could not map TEMAC registers\n"); return -ENOMEM; base-commit: d95fcdf4961d27a3d17e5c7728367197adc89b8d -- 2.39.3 (Apple Git-146) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-21 13:09 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-20 14:19 [PATCH net v2] net: ll_temac: platform_get_resource replaced by wrong function Claus Hansen Ries 2024-03-20 14:19 ` Claus Hansen Ries 2024-03-20 15:22 ` Simon Horman 2024-03-20 15:22 ` Simon Horman 2024-03-20 16:06 ` Jiri Pirko 2024-03-20 16:06 ` Jiri Pirko 2024-03-21 12:51 ` Paolo Abeni 2024-03-21 12:51 ` Paolo Abeni 2024-03-21 13:08 ` Claus Hansen Ries [this message] 2024-03-21 13:08 ` [PATCH net v3] " Claus Hansen Ries 2024-03-26 3:10 ` patchwork-bot+netdevbpf 2024-03-26 3:10 ` patchwork-bot+netdevbpf
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cca18f9c630a41c18487729770b492bb@terma.com \ --to=chr@terma.com \ --cc=dan.carpenter@linaro.org \ --cc=davem@davemloft.net \ --cc=edumazet@google.com \ --cc=harini.katakam@amd.com \ --cc=horms@kernel.org \ --cc=kuba@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=michal.simek@amd.com \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ --cc=robh@kernel.org \ --cc=u.kleine-koenig@pengutronix.de \ --cc=wanghai38@huawei.com \ --cc=wei.fang@nxp.com \ --cc=yangyingliang@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.