All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Machata <petrm@nvidia.com>
To: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	<netdev@vger.kernel.org>
Cc: Petr Machata <petrm@nvidia.com>, Ido Schimmel <idosch@nvidia.com>,
	Danielle Ratson <danieller@nvidia.com>,
	Amit Cohen <amcohen@nvidia.com>, Shuah Khan <shuah@kernel.org>,
	<linux-kselftest@vger.kernel.org>, <mlxsw@nvidia.com>
Subject: [PATCH net-next 03/16] selftests: forwarding: skbedit_priority: Disable IPv6 autogen on a bridge
Date: Tue, 20 Jun 2023 15:55:49 +0200	[thread overview]
Message-ID: <cdca66f7671fd876d197161ee69e13303c416969.1687265905.git.petrm@nvidia.com> (raw)
In-Reply-To: <cover.1687265905.git.petrm@nvidia.com>

In a future patch, mlxsw will start adding RIFs to uppers of front panel
port netdevices, if they have an IP address.

At the time that the front panel port is enslaved to the bridge, the bridge
MAC address does not have the same prefix as other interfaces in the
system. On Nvidia Spectrum-1 machines all the RIFs have to have the same
38-bit MAC address prefix. Since the bridge does not obey this limitation,
the RIF cannot be created, and the enslavement attempt is vetoed on the
grounds of the configuration not being offloadable.

The selftest itself however checks operation of pedit on IPv4 and IPv6
dsfield and its parts. The bridge thus does not need to participate in
routing traffic and the IP address or the RIF are irrelevant.

Fix by disabling automatic IPv6 address generation for the HW-offloaded
bridge in this selftest, thus exempting it from mlxsw router attention.
Since the bridge is only used for L2 forwarding, this change should not
hinder usefulness of this selftest for testing SW datapath or HW datapaths
in other devices.

Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Danielle Ratson <danieller@nvidia.com>
---
 tools/testing/selftests/net/forwarding/pedit_dsfield.sh | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/forwarding/pedit_dsfield.sh b/tools/testing/selftests/net/forwarding/pedit_dsfield.sh
index 64fbd211d907..af008fbf2725 100755
--- a/tools/testing/selftests/net/forwarding/pedit_dsfield.sh
+++ b/tools/testing/selftests/net/forwarding/pedit_dsfield.sh
@@ -60,7 +60,9 @@ h2_destroy()
 
 switch_create()
 {
-	ip link add name br1 up type bridge vlan_filtering 1
+	ip link add name br1 type bridge vlan_filtering 1
+	ip link set dev br1 addrgenmode none
+	ip link set dev br1 up
 	ip link set dev $swp1 master br1
 	ip link set dev $swp1 up
 	ip link set dev $swp2 master br1
-- 
2.40.1


  parent reply	other threads:[~2023-06-20 13:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-20 13:55 [PATCH net-next 00/16] selftests: Preparations for out-of-order-operations patches in mlxsw Petr Machata
2023-06-20 13:55 ` [PATCH net-next 01/16] selftests: forwarding: q_in_vni: Disable IPv6 autogen on bridges Petr Machata
2023-06-20 13:55 ` [PATCH net-next 02/16] selftests: forwarding: dual_vxlan_bridge: " Petr Machata
2023-06-20 13:55 ` Petr Machata [this message]
2023-06-20 13:55 ` [PATCH net-next 04/16] selftests: forwarding: pedit_dsfield: Disable IPv6 autogen on a bridge Petr Machata
2023-06-20 13:55 ` [PATCH net-next 05/16] selftests: forwarding: mirror_gre_*: Disable IPv6 autogen on bridges Petr Machata
2023-06-20 13:55 ` [PATCH net-next 06/16] selftests: forwarding: mirror_gre_*: Use port MAC for bridge address Petr Machata
2023-06-20 13:55 ` [PATCH net-next 07/16] selftests: forwarding: router_bridge: " Petr Machata
2023-06-20 13:55 ` [PATCH net-next 08/16] selftests: mlxsw: q_in_q_veto: Disable IPv6 autogen on bridges Petr Machata
2023-06-20 13:55 ` [PATCH net-next 09/16] selftests: mlxsw: extack: " Petr Machata
2023-06-20 13:55 ` [PATCH net-next 10/16] selftests: mlxsw: mirror_gre_scale: Disable IPv6 autogen on a bridge Petr Machata
2023-06-20 13:55 ` [PATCH net-next 11/16] selftests: mlxsw: qos_dscp_bridge: " Petr Machata
2023-06-20 13:55 ` [PATCH net-next 12/16] selftests: mlxsw: qos_ets_strict: Disable IPv6 autogen on bridges Petr Machata
2023-06-20 13:55 ` [PATCH net-next 13/16] selftests: mlxsw: qos_mc_aware: " Petr Machata
2023-06-20 13:56 ` [PATCH net-next 14/16] selftests: mlxsw: spectrum: q_in_vni_veto: Disable IPv6 autogen on a bridge Petr Machata
2023-06-20 13:56 ` [PATCH net-next 15/16] selftests: mlxsw: vxlan: Disable IPv6 autogen on bridges Petr Machata
2023-06-20 13:56 ` [PATCH net-next 16/16] selftests: mlxsw: one_armed_router: Use port MAC for bridge address Petr Machata
2023-06-21 21:10 ` [PATCH net-next 00/16] selftests: Preparations for out-of-order-operations patches in mlxsw patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cdca66f7671fd876d197161ee69e13303c416969.1687265905.git.petrm@nvidia.com \
    --to=petrm@nvidia.com \
    --cc=amcohen@nvidia.com \
    --cc=danieller@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mlxsw@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.