All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jose Abreu <Jose.Abreu@synopsys.com>
To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: Jose Abreu <Jose.Abreu@synopsys.com>,
	Carlos Palminha <CARLOS.PALMINHA@synopsys.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Liviu Dudau <liviu.dudau@arm.com>,
	Brian Starkey <brian.starkey@arm.com>,
	David Airlie <airlied@linux.ie>
Subject: [PATCH v5 08/10] drm/arm: malidp: Use crtc->mode_valid() callback
Date: Thu, 25 May 2017 15:19:20 +0100	[thread overview]
Message-ID: <ced0d5f5f5b2660e28eed6cf22e8120a0959af90.1495720737.git.joabreu@synopsys.com> (raw)
In-Reply-To: <cover.1495720737.git.joabreu@synopsys.com>
In-Reply-To: <cover.1495720737.git.joabreu@synopsys.com>

Now that we have a callback to check if crtc supports a given mode
we can use it in malidp so that we restrict the number of probbed
modes to the ones we can actually display.

Also, remove the mode_fixup() callback as this is no longer needed
because mode_valid() will be called before.

NOTE: Not even compiled tested

Signed-off-by: Jose Abreu <joabreu@synopsys.com>
Cc: Carlos Palminha <palminha@synopsys.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Brian Starkey <brian.starkey@arm.com>
Cc: David Airlie <airlied@linux.ie>
---
 drivers/gpu/drm/arm/malidp_crtc.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/arm/malidp_crtc.c b/drivers/gpu/drm/arm/malidp_crtc.c
index 9446a67..4bb38a2 100644
--- a/drivers/gpu/drm/arm/malidp_crtc.c
+++ b/drivers/gpu/drm/arm/malidp_crtc.c
@@ -22,9 +22,8 @@
 #include "malidp_drv.h"
 #include "malidp_hw.h"
 
-static bool malidp_crtc_mode_fixup(struct drm_crtc *crtc,
-				   const struct drm_display_mode *mode,
-				   struct drm_display_mode *adjusted_mode)
+static enum drm_mode_status malidp_crtc_mode_valid(struct drm_crtc *crtc,
+						   const struct drm_display_mode *mode)
 {
 	struct malidp_drm *malidp = crtc_to_malidp_device(crtc);
 	struct malidp_hw_device *hwdev = malidp->dev;
@@ -40,11 +39,11 @@ static bool malidp_crtc_mode_fixup(struct drm_crtc *crtc,
 		if (rate != req_rate) {
 			DRM_DEBUG_DRIVER("pxlclk doesn't support %ld Hz\n",
 					 req_rate);
-			return false;
+			return MODE_NOCLOCK;
 		}
 	}
 
-	return true;
+	return MODE_OK;
 }
 
 static void malidp_crtc_enable(struct drm_crtc *crtc)
@@ -408,7 +407,7 @@ static int malidp_crtc_atomic_check(struct drm_crtc *crtc,
 }
 
 static const struct drm_crtc_helper_funcs malidp_crtc_helper_funcs = {
-	.mode_fixup = malidp_crtc_mode_fixup,
+	.mode_valid = malidp_crtc_mode_valid,
 	.enable = malidp_crtc_enable,
 	.disable = malidp_crtc_disable,
 	.atomic_check = malidp_crtc_atomic_check,
-- 
1.9.1

  parent reply	other threads:[~2017-05-25 14:21 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-25 14:19 [PATCH v5 00/10] Introduce new mode validation callbacks Jose Abreu
2017-05-25 14:19 ` [PATCH v5 01/10] drm: Add drm_{crtc/encoder/connector}_mode_valid() Jose Abreu
2017-05-30  6:38   ` Daniel Vetter
2017-05-30  6:38     ` Daniel Vetter
2017-05-30  7:26   ` Neil Armstrong
2017-05-30  7:26     ` Neil Armstrong
2017-05-25 14:19 ` [PATCH v5 02/10] drm: Introduce drm_bridge_mode_valid() Jose Abreu
2017-05-26  4:25   ` Archit Taneja
2017-05-26  4:25     ` Archit Taneja
2017-05-30  7:27   ` Neil Armstrong
2017-05-30  7:27     ` Neil Armstrong
2017-05-25 14:19 ` [PATCH v5 03/10] drm: Use new mode_valid() helpers in connector probe helper Jose Abreu
2017-05-30  7:27   ` Neil Armstrong
2017-05-30  7:27     ` Neil Armstrong
2017-05-25 14:19 ` [PATCH v5 04/10] drm: Use mode_valid() in atomic modeset Jose Abreu
2017-05-29 19:38   ` Daniel Vetter
2017-05-29 19:38     ` Daniel Vetter
2017-05-30  7:27   ` Neil Armstrong
2017-05-30  7:27     ` Neil Armstrong
2017-05-25 14:19 ` [PATCH v5 05/10] drm: arcpgu: Use crtc->mode_valid() callback Jose Abreu
2017-05-30  7:28   ` Neil Armstrong
2017-05-30  7:28     ` Neil Armstrong
2017-06-21  9:38   ` Jose Abreu
2017-06-21  9:38     ` Jose Abreu
2017-06-22  8:46     ` Daniel Vetter
2017-06-22  8:46       ` Daniel Vetter
2017-05-25 14:19 ` [PATCH v5 06/10] drm/bridge: analogix-anx78xx: Use bridge->mode_valid() callback Jose Abreu
2017-05-26  4:27   ` Archit Taneja
2017-05-26  4:27     ` Archit Taneja
2017-05-30  7:28   ` Neil Armstrong
2017-05-30 10:35     ` Archit Taneja
2017-05-30 10:35       ` Archit Taneja
2017-05-25 14:19 ` [PATCH v5 07/10] drm/bridge/synopsys: dw-hdmi: " Jose Abreu
2017-05-29  9:45   ` Neil Armstrong
2017-05-29  9:45     ` Neil Armstrong
2017-05-30 10:24   ` Archit Taneja
2017-05-30 10:24     ` Archit Taneja
2017-05-30 10:29     ` Philipp Zabel
2017-05-30 10:29       ` Philipp Zabel
2017-06-05  7:53       ` Archit Taneja
2017-06-05  7:53         ` Archit Taneja
2017-05-25 14:19 ` Jose Abreu [this message]
2017-05-30  7:29   ` [PATCH v5 08/10] drm/arm: malidp: Use crtc->mode_valid() callback Neil Armstrong
2017-05-30  7:29     ` Neil Armstrong
2017-05-30  9:37     ` Liviu Dudau
2017-05-30  9:37       ` Liviu Dudau
2017-05-31  8:20       ` Daniel Vetter
2017-05-31  8:20         ` Daniel Vetter
2017-05-31 10:48         ` Liviu Dudau
2017-05-31 10:56           ` Daniel Vetter
2017-05-31 11:09             ` Liviu Dudau
2017-05-25 14:19 ` [PATCH v5 09/10] drm/atmel-hlcdc: " Jose Abreu
2017-05-30  7:30   ` Neil Armstrong
2017-05-30  7:30     ` Neil Armstrong
2017-06-02  9:35   ` Boris Brezillon
2017-06-02  9:35     ` Boris Brezillon
2017-05-25 14:19 ` [PATCH v5 10/10] drm: vc4: Use crtc->mode_valid() and encoder->mode_valid() callbacks Jose Abreu
2017-05-30  7:30   ` Neil Armstrong
2017-05-30  7:30     ` Neil Armstrong
2017-06-02 20:10   ` Eric Anholt
2017-06-02 20:10     ` Eric Anholt
2017-06-20  8:47     ` Daniel Vetter
2017-06-20  8:47       ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ced0d5f5f5b2660e28eed6cf22e8120a0959af90.1495720737.git.joabreu@synopsys.com \
    --to=jose.abreu@synopsys.com \
    --cc=CARLOS.PALMINHA@synopsys.com \
    --cc=airlied@linux.ie \
    --cc=brian.starkey@arm.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.