All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dale B Stimson <dale.b.stimson@intel.com>
To: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: [PATCH i-g-t v4 0/1] gem_ctx_isolation.c - Gen11 enabling for context isolation test
Date: Mon,  4 Mar 2019 17:03:06 -0800	[thread overview]
Message-ID: <cover.1551746698.git.dale.b.stimson@intel.com> (raw)

V4:

I have tested these changes on both SKL and ICL with no regressions
detected.

I will note that both SKL and ICL seem to currently have (at least for
my environment) suspend/resume issues which occur with or without these
changes (and also for gem_exec_suspend).  Therefore, the S3/S4 tests
were not done.

Testing on ICL shows that Gen11 requires BB_OFFSET .ignore_bits =
0x7 instead of 0x4.  I presume that the preferred way to do this is to
change the existing table entry for BB_OFFSET instead of splitting it
into separate entries for GEN8-10 and GEN11.

For those registers that are force_nonpriv for some Gen levels and
not for others, I have chosen to show the two states as separate table
entries to make this clear.  In particular, this applies as shown below.
Any objections to doing it that way?

+       { "CTX_PREEMPT", NOCTX /* GEN10 */, RCS0, 0x2248 },
+       { "CS_CHICKEN1", GEN11, RCS0, 0x2580, .masked = true },
+       { "HDC_CHICKEN1", GEN_RANGE(10, 10), RCS0, 0x7304, .masked = true },
+
        /* Privileged (enabled by w/a + FORCE_TO_NONPRIV) */
-       { "CTX_PREEMPT", NOCTX /* GEN_RANGE(9, 10) */, RCS0, 0x2248 },
+       { "CTX_PREEMPT", NOCTX /* GEN9 */, RCS0, 0x2248 },
        { "CS_CHICKEN1", GEN_RANGE(9, 10), RCS0, 0x2580, .masked = true },
-       { "HDC_CHICKEN1", GEN_RANGE(9, 10), RCS0, 0x7304, .masked = true },
+       { "HDC_CHICKEN1", GEN_RANGE(9, 9), RCS0, 0x7304, .masked = true },

Dale B Stimson (1):
  gem_ctx_isolation.c - Gen11 enabling for context isolation test

 tests/i915/gem_ctx_isolation.c | 47 +++++++++++++++++++++++++---------
 1 file changed, 35 insertions(+), 12 deletions(-)

-- 
2.21.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Dale B Stimson <dale.b.stimson@intel.com>
To: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: tvrtko.ursulin@intel.com
Subject: [igt-dev] [PATCH i-g-t v4 0/1] gem_ctx_isolation.c - Gen11 enabling for context isolation test
Date: Mon,  4 Mar 2019 17:03:06 -0800	[thread overview]
Message-ID: <cover.1551746698.git.dale.b.stimson@intel.com> (raw)

V4:

I have tested these changes on both SKL and ICL with no regressions
detected.

I will note that both SKL and ICL seem to currently have (at least for
my environment) suspend/resume issues which occur with or without these
changes (and also for gem_exec_suspend).  Therefore, the S3/S4 tests
were not done.

Testing on ICL shows that Gen11 requires BB_OFFSET .ignore_bits =
0x7 instead of 0x4.  I presume that the preferred way to do this is to
change the existing table entry for BB_OFFSET instead of splitting it
into separate entries for GEN8-10 and GEN11.

For those registers that are force_nonpriv for some Gen levels and
not for others, I have chosen to show the two states as separate table
entries to make this clear.  In particular, this applies as shown below.
Any objections to doing it that way?

+       { "CTX_PREEMPT", NOCTX /* GEN10 */, RCS0, 0x2248 },
+       { "CS_CHICKEN1", GEN11, RCS0, 0x2580, .masked = true },
+       { "HDC_CHICKEN1", GEN_RANGE(10, 10), RCS0, 0x7304, .masked = true },
+
        /* Privileged (enabled by w/a + FORCE_TO_NONPRIV) */
-       { "CTX_PREEMPT", NOCTX /* GEN_RANGE(9, 10) */, RCS0, 0x2248 },
+       { "CTX_PREEMPT", NOCTX /* GEN9 */, RCS0, 0x2248 },
        { "CS_CHICKEN1", GEN_RANGE(9, 10), RCS0, 0x2580, .masked = true },
-       { "HDC_CHICKEN1", GEN_RANGE(9, 10), RCS0, 0x7304, .masked = true },
+       { "HDC_CHICKEN1", GEN_RANGE(9, 9), RCS0, 0x7304, .masked = true },

Dale B Stimson (1):
  gem_ctx_isolation.c - Gen11 enabling for context isolation test

 tests/i915/gem_ctx_isolation.c | 47 +++++++++++++++++++++++++---------
 1 file changed, 35 insertions(+), 12 deletions(-)

-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2019-03-05  1:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-05  1:03 Dale B Stimson [this message]
2019-03-05  1:03 ` [igt-dev] [PATCH i-g-t v4 0/1] gem_ctx_isolation.c - Gen11 enabling for context isolation test Dale B Stimson
2019-03-05  1:03 ` [PATCH i-g-t v4 1/1] " Dale B Stimson
2019-03-05  1:03   ` [igt-dev] " Dale B Stimson
2019-03-05 19:00   ` Chris Wilson
2019-03-05 19:00     ` [igt-dev] " Chris Wilson
2019-03-05 20:46     ` Dale B Stimson
2019-03-05 20:46       ` [igt-dev] " Dale B Stimson
2019-03-05 20:56       ` Chris Wilson
2019-03-05 20:56         ` [igt-dev] " Chris Wilson
2019-03-05  2:13 ` [igt-dev] ✓ Fi.CI.BAT: success for gem_ctx_isolation.c - Gen11 enabling for context isolation test (rev5) Patchwork
2019-03-05  6:35 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-03-05 15:31 ` [PATCH i-g-t v4 0/1] gem_ctx_isolation.c - Gen11 enabling for context isolation test Chris Wilson
2019-03-05 15:31   ` [igt-dev] " Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1551746698.git.dale.b.stimson@intel.com \
    --to=dale.b.stimson@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.