From: Leonard Crestez <leonard.crestez@nxp.com> To: Alexandre Bailon <abailon@baylibre.com>, Georgi Djakov <georgi.djakov@linaro.org>, Stephen Boyd <sboyd@kernel.org>, Michael Turquette <mturquette@baylibre.com>, Viresh Kumar <viresh.kumar@linaro.org> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>, Kyungmin Park <kyungmin.park@samsung.com>, Shawn Guo <shawnguo@kernel.org>, Dong Aisheng <aisheng.dong@nxp.com>, Fabio Estevam <fabio.estevam@nxp.com>, "Rafael J. Wysocki" <rafael@kernel.org>, Jacky Bai <ping.bai@nxp.com>, Anson Huang <Anson.Huang@nxp.com>, Abel Vesa <abel.vesa@nxp.com>, Krzysztof Kozlowski <krzk@kernel.org>, Ulf Hansson <ulf.hansson@linaro.org>, Saravana Kannan <saravanak@google.com>, kernel@pengutronix.de, linux-imx@nxp.com, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [RFCv2 0/8] Add imx8mm bus frequency switching Date: Fri, 28 Jun 2019 10:39:48 +0300 [thread overview] Message-ID: <cover.1561707104.git.leonard.crestez@nxp.com> (raw) This series attempts to add upstream DVFS support for imx8mm, covering dynamic scaling of internal buses and dram. It uses the interconnect framework for proactive scaling (in response to explicit bandwidth requests from devices) and devfreq in order expose the buses and eventually implement reactive scaling (in response to measuredtraffic). Actual scaling is performed through the clk framework: The NOC and main NICs are driven by composite clks and a new 'imx8m-dram' clk is included for scaling dram using firmware calls. The interconnect and devfreq parts do not communicate explicitly: they both just call clk_set_min_rate and the clk core picks the minimum value that can satisfy both. They are thus completely independent. This is easily extensible to more members of the imx8m family, some of which expose more detailed controls over interconnect fabric frequencies. TODO: * Clarify DT bindings * Clarify interconnect OPP picking logic * Implement devfreq_event for imx8m ddrc * Expose more dram frequencies The clk_set_min_rate approach does not mesh very well with the OPP framework. Some of interconnect nodes on imx8m can run at different voltages: OPP can handle this well but not in response to a clk_set_min_rate from an unrelated subsystem. Maybe set voltage on a clk notifier? Vendor tree does not support voltage switching, independent freqs for different parts of the fabric or any reactive scaling. I think it's important to pick an upstreaming approach which can support as much as possible. Feedback welcome. Some objections were apparently raised to doing DRAM switch inside CLK: perhaps ICC should make min_freq requests to devfreq instead? Link to v1 (multiple chunks): * https://patchwork.kernel.org/patch/10976897/ * https://patchwork.kernel.org/patch/10968303/ * https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=91251 Also as a github branch (with few other changes): https://github.com/cdleonard/linux/tree/next_imx8mm_busfreq Alexandre Bailon (2): interconnect: Add generic driver for imx interconnect: imx: Add platform driver for imx8mm Leonard Crestez (6): clk: imx8mm: Add dram freq switch support clk: imx8m-composite: Switch to determine_rate arm64: dts: imx8mm: Add dram dvfs irqs to ccm node devfreq: Add imx-devfreq driver arm64: dts: imx8mm: Add interconnect node arm64: dts: imx8mm: Add devfreq-imx nodes arch/arm64/boot/dts/freescale/imx8mm.dtsi | 73 +++ drivers/clk/imx/Makefile | 1 + drivers/clk/imx/clk-composite-8m.c | 34 +- drivers/clk/imx/clk-imx8m-dram.c | 357 ++++++++++++ drivers/clk/imx/clk-imx8mm.c | 12 + drivers/clk/imx/clk.h | 13 + drivers/devfreq/Kconfig | 10 + drivers/devfreq/Makefile | 1 + drivers/devfreq/imx-devfreq.c | 142 +++++ drivers/interconnect/Kconfig | 1 + drivers/interconnect/Makefile | 1 + drivers/interconnect/imx/Kconfig | 17 + drivers/interconnect/imx/Makefile | 2 + drivers/interconnect/imx/busfreq-imx8mm.c | 151 ++++++ drivers/interconnect/imx/busfreq.c | 628 ++++++++++++++++++++++ drivers/interconnect/imx/busfreq.h | 123 +++++ include/dt-bindings/clock/imx8mm-clock.h | 4 +- include/dt-bindings/interconnect/imx8mm.h | 49 ++ 18 files changed, 1606 insertions(+), 13 deletions(-) create mode 100644 drivers/clk/imx/clk-imx8m-dram.c create mode 100644 drivers/devfreq/imx-devfreq.c create mode 100644 drivers/interconnect/imx/Kconfig create mode 100644 drivers/interconnect/imx/Makefile create mode 100644 drivers/interconnect/imx/busfreq-imx8mm.c create mode 100644 drivers/interconnect/imx/busfreq.c create mode 100644 drivers/interconnect/imx/busfreq.h create mode 100644 include/dt-bindings/interconnect/imx8mm.h -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Leonard Crestez <leonard.crestez@nxp.com> To: Alexandre Bailon <abailon@baylibre.com>, Georgi Djakov <georgi.djakov@linaro.org>, Stephen Boyd <sboyd@kernel.org>, Michael Turquette <mturquette@baylibre.com>, Viresh Kumar <viresh.kumar@linaro.org> Cc: Dong Aisheng <aisheng.dong@nxp.com>, Ulf Hansson <ulf.hansson@linaro.org>, Jacky Bai <ping.bai@nxp.com>, Anson Huang <Anson.Huang@nxp.com>, "Rafael J. Wysocki" <rafael@kernel.org>, linux-pm@vger.kernel.org, Krzysztof Kozlowski <krzk@kernel.org>, Saravana Kannan <saravanak@google.com>, Kyungmin Park <kyungmin.park@samsung.com>, MyungJoo Ham <myungjoo.ham@samsung.com>, linux-imx@nxp.com, kernel@pengutronix.de, Fabio Estevam <fabio.estevam@nxp.com>, Shawn Guo <shawnguo@kernel.org>, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Abel Vesa <abel.vesa@nxp.com> Subject: [RFCv2 0/8] Add imx8mm bus frequency switching Date: Fri, 28 Jun 2019 10:39:48 +0300 [thread overview] Message-ID: <cover.1561707104.git.leonard.crestez@nxp.com> (raw) This series attempts to add upstream DVFS support for imx8mm, covering dynamic scaling of internal buses and dram. It uses the interconnect framework for proactive scaling (in response to explicit bandwidth requests from devices) and devfreq in order expose the buses and eventually implement reactive scaling (in response to measuredtraffic). Actual scaling is performed through the clk framework: The NOC and main NICs are driven by composite clks and a new 'imx8m-dram' clk is included for scaling dram using firmware calls. The interconnect and devfreq parts do not communicate explicitly: they both just call clk_set_min_rate and the clk core picks the minimum value that can satisfy both. They are thus completely independent. This is easily extensible to more members of the imx8m family, some of which expose more detailed controls over interconnect fabric frequencies. TODO: * Clarify DT bindings * Clarify interconnect OPP picking logic * Implement devfreq_event for imx8m ddrc * Expose more dram frequencies The clk_set_min_rate approach does not mesh very well with the OPP framework. Some of interconnect nodes on imx8m can run at different voltages: OPP can handle this well but not in response to a clk_set_min_rate from an unrelated subsystem. Maybe set voltage on a clk notifier? Vendor tree does not support voltage switching, independent freqs for different parts of the fabric or any reactive scaling. I think it's important to pick an upstreaming approach which can support as much as possible. Feedback welcome. Some objections were apparently raised to doing DRAM switch inside CLK: perhaps ICC should make min_freq requests to devfreq instead? Link to v1 (multiple chunks): * https://patchwork.kernel.org/patch/10976897/ * https://patchwork.kernel.org/patch/10968303/ * https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=91251 Also as a github branch (with few other changes): https://github.com/cdleonard/linux/tree/next_imx8mm_busfreq Alexandre Bailon (2): interconnect: Add generic driver for imx interconnect: imx: Add platform driver for imx8mm Leonard Crestez (6): clk: imx8mm: Add dram freq switch support clk: imx8m-composite: Switch to determine_rate arm64: dts: imx8mm: Add dram dvfs irqs to ccm node devfreq: Add imx-devfreq driver arm64: dts: imx8mm: Add interconnect node arm64: dts: imx8mm: Add devfreq-imx nodes arch/arm64/boot/dts/freescale/imx8mm.dtsi | 73 +++ drivers/clk/imx/Makefile | 1 + drivers/clk/imx/clk-composite-8m.c | 34 +- drivers/clk/imx/clk-imx8m-dram.c | 357 ++++++++++++ drivers/clk/imx/clk-imx8mm.c | 12 + drivers/clk/imx/clk.h | 13 + drivers/devfreq/Kconfig | 10 + drivers/devfreq/Makefile | 1 + drivers/devfreq/imx-devfreq.c | 142 +++++ drivers/interconnect/Kconfig | 1 + drivers/interconnect/Makefile | 1 + drivers/interconnect/imx/Kconfig | 17 + drivers/interconnect/imx/Makefile | 2 + drivers/interconnect/imx/busfreq-imx8mm.c | 151 ++++++ drivers/interconnect/imx/busfreq.c | 628 ++++++++++++++++++++++ drivers/interconnect/imx/busfreq.h | 123 +++++ include/dt-bindings/clock/imx8mm-clock.h | 4 +- include/dt-bindings/interconnect/imx8mm.h | 49 ++ 18 files changed, 1606 insertions(+), 13 deletions(-) create mode 100644 drivers/clk/imx/clk-imx8m-dram.c create mode 100644 drivers/devfreq/imx-devfreq.c create mode 100644 drivers/interconnect/imx/Kconfig create mode 100644 drivers/interconnect/imx/Makefile create mode 100644 drivers/interconnect/imx/busfreq-imx8mm.c create mode 100644 drivers/interconnect/imx/busfreq.c create mode 100644 drivers/interconnect/imx/busfreq.h create mode 100644 include/dt-bindings/interconnect/imx8mm.h -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-06-28 7:40 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-28 7:39 Leonard Crestez [this message] 2019-06-28 7:39 ` [RFCv2 0/8] Add imx8mm bus frequency switching Leonard Crestez 2019-06-28 7:39 ` [RFCv2 1/8] clk: imx8mm: Add dram freq switch support Leonard Crestez 2019-06-28 7:39 ` Leonard Crestez 2019-06-28 7:39 ` [RFCv2 2/8] clk: imx8m-composite: Switch to determine_rate Leonard Crestez 2019-06-28 7:39 ` Leonard Crestez 2019-06-28 8:45 ` Abel Vesa 2019-06-28 8:45 ` Abel Vesa 2019-06-28 8:56 ` Leonard Crestez 2019-06-28 8:56 ` Leonard Crestez 2019-07-02 7:13 ` Abel Vesa 2019-07-02 7:13 ` Abel Vesa 2019-06-28 7:39 ` [RFCv2 3/8] arm64: dts: imx8mm: Add dram dvfs irqs to ccm node Leonard Crestez 2019-06-28 7:39 ` Leonard Crestez 2019-06-28 7:39 ` [RFCv2 4/8] interconnect: Add generic driver for imx Leonard Crestez 2019-06-28 7:39 ` Leonard Crestez 2019-06-28 7:39 ` [RFCv2 5/8] interconnect: imx: Add platform driver for imx8mm Leonard Crestez 2019-06-28 7:39 ` Leonard Crestez 2019-06-28 7:39 ` [RFCv2 6/8] devfreq: Add imx-devfreq driver Leonard Crestez 2019-06-28 7:39 ` Leonard Crestez 2019-07-03 1:31 ` Chanwoo Choi 2019-07-03 1:31 ` Chanwoo Choi 2019-06-28 7:39 ` [RFCv2 7/8] arm64: dts: imx8mm: Add interconnect node Leonard Crestez 2019-06-28 7:39 ` Leonard Crestez 2019-06-28 7:39 ` [RFCv2 8/8] arm64: dts: imx8mm: Add devfreq-imx nodes Leonard Crestez 2019-06-28 7:39 ` Leonard Crestez 2019-07-03 22:19 ` [RFCv2 0/8] Add imx8mm bus frequency switching Saravana Kannan 2019-07-03 22:19 ` Saravana Kannan 2019-07-03 23:30 ` Leonard Crestez 2019-07-03 23:30 ` Leonard Crestez 2019-07-04 3:02 ` Saravana Kannan 2019-07-04 3:02 ` Saravana Kannan 2019-07-04 8:32 ` Leonard Crestez 2019-07-04 8:32 ` Leonard Crestez
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1561707104.git.leonard.crestez@nxp.com \ --to=leonard.crestez@nxp.com \ --cc=Anson.Huang@nxp.com \ --cc=abailon@baylibre.com \ --cc=abel.vesa@nxp.com \ --cc=aisheng.dong@nxp.com \ --cc=fabio.estevam@nxp.com \ --cc=georgi.djakov@linaro.org \ --cc=kernel@pengutronix.de \ --cc=krzk@kernel.org \ --cc=kyungmin.park@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-imx@nxp.com \ --cc=linux-pm@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=myungjoo.ham@samsung.com \ --cc=ping.bai@nxp.com \ --cc=rafael@kernel.org \ --cc=saravanak@google.com \ --cc=sboyd@kernel.org \ --cc=shawnguo@kernel.org \ --cc=ulf.hansson@linaro.org \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.