From: Leonard Crestez <leonard.crestez@nxp.com> To: Chanwoo Choi <cw00.choi@samsung.com>, MyungJoo Ham <myungjoo.ham@samsung.com> Cc: "Kyungmin Park" <kyungmin.park@samsung.com>, "Artur Świgoń" <a.swigon@partner.samsung.com>, "Saravana Kannan" <saravanak@google.com>, "Krzysztof Kozlowski" <krzk@kernel.org>, "Alexandre Bailon" <abailon@baylibre.com>, "Georgi Djakov" <georgi.djakov@linaro.org>, "Abel Vesa" <abel.vesa@nxp.com>, "Jacky Bai" <ping.bai@nxp.com>, "Viresh Kumar" <viresh.kumar@linaro.org>, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 0/6] PM / devfreq: Add dev_pm_qos support Date: Mon, 26 Aug 2019 16:44:27 +0300 [thread overview] Message-ID: <cover.1566826075.git.leonard.crestez@nxp.com> (raw) Add dev_pm_qos notifies to devfreq core in order to support frequency limits via the dev_pm_qos_add_request. Unlike the rest of devfreq the dev_pm_qos frequency is measured in Khz, this is consistent with current dev_pm_qos usage for cpufreq and allows frequencies above 2Ghz (pm_qos expresses limits as s32). Like with cpufreq the handling of min_freq/max_freq is moved to the dev_pm_qos mechanism. Patches 1/2 are technically bugfixes; as far as I can tell the paths that "goto err_devfreq" in devfreq_add_device never worked correctly. Constraints from userspace are no longer clamped on store, instead all values are allowed and we only check against OPPs in a new devfreq_get_freq_range function. This is consistent with the design of dev_pm_qos design. Changes since v3: * Cleanup locking and error-handling in devfreq_add_device * Register notifiers after device registration but before governor start * Keep the initialization of min_req/max_req ahead of device_register because it's used for sysfs handling * Use HZ_PER_KHZ instead of 1000 * Add kernel-doc comments * Move OPP notifier to core Link to v3: https://patchwork.kernel.org/cover/11104061/ Changes since v2: * Handle sysfs via dev_pm_qos (in separate patch) * Add locking to {min,max}_freq_show * Fix checkpatch issues (long lines etc) Link to v2: https://patchwork.kernel.org/patch/11084279/ Changes since v1: * Add doxygen comments for min_nb/max_nb * Remove notifiers on error/cleanup paths. Keep gotos simple by relying on dev_pm_qos_remove_notifier ignoring notifiers which were not added. Link to v1: https://patchwork.kernel.org/patch/11078475/ Leonard Crestez (6): PM / devfreq: Don't take lock in devfreq_add_device PM / devfreq: Add to devfreq_list immediately after registration PM / devfreq: Introduce devfreq_get_freq_range PM / devfreq: Add dev_pm_qos support PM / devfreq: Use dev_pm_qos for sysfs min/max_freq PM / devfreq: Move opp notifier registration to core drivers/devfreq/devfreq.c | 313 +++++++++++++++++++---------------- drivers/devfreq/exynos-bus.c | 7 - drivers/devfreq/rk3399_dmc.c | 6 - include/linux/devfreq.h | 22 ++- 4 files changed, 177 insertions(+), 171 deletions(-) -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Leonard Crestez <leonard.crestez@nxp.com> To: Chanwoo Choi <cw00.choi@samsung.com>, MyungJoo Ham <myungjoo.ham@samsung.com> Cc: "Artur Świgoń" <a.swigon@partner.samsung.com>, "Abel Vesa" <abel.vesa@nxp.com>, "Saravana Kannan" <saravanak@google.com>, linux-pm@vger.kernel.org, "Viresh Kumar" <viresh.kumar@linaro.org>, "Krzysztof Kozlowski" <krzk@kernel.org>, "Kyungmin Park" <kyungmin.park@samsung.com>, "Alexandre Bailon" <abailon@baylibre.com>, "Georgi Djakov" <georgi.djakov@linaro.org>, linux-arm-kernel@lists.infradead.org, "Jacky Bai" <ping.bai@nxp.com> Subject: [PATCH v4 0/6] PM / devfreq: Add dev_pm_qos support Date: Mon, 26 Aug 2019 16:44:27 +0300 [thread overview] Message-ID: <cover.1566826075.git.leonard.crestez@nxp.com> (raw) Add dev_pm_qos notifies to devfreq core in order to support frequency limits via the dev_pm_qos_add_request. Unlike the rest of devfreq the dev_pm_qos frequency is measured in Khz, this is consistent with current dev_pm_qos usage for cpufreq and allows frequencies above 2Ghz (pm_qos expresses limits as s32). Like with cpufreq the handling of min_freq/max_freq is moved to the dev_pm_qos mechanism. Patches 1/2 are technically bugfixes; as far as I can tell the paths that "goto err_devfreq" in devfreq_add_device never worked correctly. Constraints from userspace are no longer clamped on store, instead all values are allowed and we only check against OPPs in a new devfreq_get_freq_range function. This is consistent with the design of dev_pm_qos design. Changes since v3: * Cleanup locking and error-handling in devfreq_add_device * Register notifiers after device registration but before governor start * Keep the initialization of min_req/max_req ahead of device_register because it's used for sysfs handling * Use HZ_PER_KHZ instead of 1000 * Add kernel-doc comments * Move OPP notifier to core Link to v3: https://patchwork.kernel.org/cover/11104061/ Changes since v2: * Handle sysfs via dev_pm_qos (in separate patch) * Add locking to {min,max}_freq_show * Fix checkpatch issues (long lines etc) Link to v2: https://patchwork.kernel.org/patch/11084279/ Changes since v1: * Add doxygen comments for min_nb/max_nb * Remove notifiers on error/cleanup paths. Keep gotos simple by relying on dev_pm_qos_remove_notifier ignoring notifiers which were not added. Link to v1: https://patchwork.kernel.org/patch/11078475/ Leonard Crestez (6): PM / devfreq: Don't take lock in devfreq_add_device PM / devfreq: Add to devfreq_list immediately after registration PM / devfreq: Introduce devfreq_get_freq_range PM / devfreq: Add dev_pm_qos support PM / devfreq: Use dev_pm_qos for sysfs min/max_freq PM / devfreq: Move opp notifier registration to core drivers/devfreq/devfreq.c | 313 +++++++++++++++++++---------------- drivers/devfreq/exynos-bus.c | 7 - drivers/devfreq/rk3399_dmc.c | 6 - include/linux/devfreq.h | 22 ++- 4 files changed, 177 insertions(+), 171 deletions(-) -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-08-26 13:44 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-26 13:44 Leonard Crestez [this message] 2019-08-26 13:44 ` [PATCH v4 0/6] PM / devfreq: Add dev_pm_qos support Leonard Crestez 2019-08-26 13:44 ` [PATCH v4 1/6] PM / devfreq: Don't take lock in devfreq_add_device Leonard Crestez 2019-08-26 13:44 ` Leonard Crestez 2019-08-26 13:44 ` [PATCH v4 2/6] PM / devfreq: Add to devfreq_list immediately after registration Leonard Crestez 2019-08-26 13:44 ` Leonard Crestez 2019-08-26 13:44 ` [PATCH v4 3/6] PM / devfreq: Introduce devfreq_get_freq_range Leonard Crestez 2019-08-26 13:44 ` Leonard Crestez 2019-08-26 13:44 ` [PATCH v4 4/6] PM / devfreq: Add dev_pm_qos support Leonard Crestez 2019-08-26 13:44 ` Leonard Crestez 2019-08-26 13:44 ` [PATCH v4 5/6] PM / devfreq: Use dev_pm_qos for sysfs min/max_freq Leonard Crestez 2019-08-26 13:44 ` Leonard Crestez 2019-08-26 13:44 ` [PATCH v4 6/6] PM / devfreq: Move opp notifier registration to core Leonard Crestez 2019-08-26 13:44 ` Leonard Crestez
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1566826075.git.leonard.crestez@nxp.com \ --to=leonard.crestez@nxp.com \ --cc=a.swigon@partner.samsung.com \ --cc=abailon@baylibre.com \ --cc=abel.vesa@nxp.com \ --cc=cw00.choi@samsung.com \ --cc=georgi.djakov@linaro.org \ --cc=krzk@kernel.org \ --cc=kyungmin.park@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=myungjoo.ham@samsung.com \ --cc=ping.bai@nxp.com \ --cc=saravanak@google.com \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.