From: Denton Liu <liu.denton@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Cc: Elijah Newren <newren@gmail.com>,
Eric Sunshine <sunshine@sunshineco.com>,
Philip Oakley <philipoakley@iee.email>
Subject: [PATCH 0/2] dl/format-patch-notes-config-fixup: clean up some leftoverbits
Date: Wed, 11 Dec 2019 16:49:44 -0800 [thread overview]
Message-ID: <cover.1576111643.git.liu.denton@gmail.com> (raw)
This series gives 'dl/format-patch-notes-config-fixup' a few polishing
touches. First of all, we document the behaviour of multiple
`format.notes` configuration variables so that end-users are aware of
the change.
Also, Eric Sunshine suggested some cleanup in the previous round, like
breaking the monolithic set_display_notes() into multiple smaller
functions and not using the return value of the function to assign to
`show_notes`.
Denton Liu (2):
config/format.txt: clarify behavior of multiple format.notes
notes: break set_display_notes() into smaller functions
Documentation/config/format.txt | 18 +++++++++++++-
builtin/log.c | 7 +++++-
notes.c | 43 ++++++++++++++++++---------------
notes.h | 19 +++++++++------
revision.c | 6 ++---
revision.h | 2 +-
6 files changed, 62 insertions(+), 33 deletions(-)
--
2.24.0.627.geba02921db
next reply other threads:[~2019-12-12 0:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 0:49 Denton Liu [this message]
2019-12-12 0:49 ` [PATCH 1/2] config/format.txt: clarify behavior of multiple format.notes Denton Liu
2019-12-12 0:49 ` [PATCH 2/2] notes: break set_display_notes() into smaller functions Denton Liu
2019-12-18 16:18 ` Eric Sunshine
2019-12-18 18:17 ` [PATCH] notes.h: fix typos in comment Denton Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1576111643.git.liu.denton@gmail.com \
--to=liu.denton@gmail.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
--cc=philipoakley@iee.email \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.