From: Viresh Kumar <viresh.kumar@linaro.org> To: Rafael Wysocki <rjw@rjwysocki.net>, Arnd Bergmann <arnd@arndb.de>, Ben Segall <bsegall@google.com>, Dietmar Eggemann <dietmar.eggemann@arm.com>, Ingo Molnar <mingo@redhat.com>, Jonathan Corbet <corbet@lwn.net>, Juri Lelli <juri.lelli@redhat.com>, Mel Gorman <mgorman@suse.de>, Peter Zijlstra <peterz@infradead.org>, Steven Rostedt <rostedt@goodmis.org>, Vincent Guittot <vincent.guittot@linaro.org>, Viresh Kumar <viresh.kumar@linaro.org> Cc: linux-pm@vger.kernel.org, kernel-team@android.com, tkjos@google.com, adharmap@codeaurora.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Quentin Perret <qperret@google.com> Subject: [PATCH V4 0/3] cpufreq: Allow default governor on cmdline and fix locking issues Date: Mon, 29 Jun 2020 13:54:57 +0530 [thread overview] Message-ID: <cover.1593418662.git.viresh.kumar@linaro.org> (raw) Hi, I have picked Quentin's series over my patch, modified both and tested. V3->V4: - Do __module_get() for cpufreq_default_governor() case as well and get rid of an extra variable. - Use a single character array, default_governor, instead of two of them. V2->V3: - default_governor is a string now and we don't set it on governor registration or unregistration anymore. - Fixed locking issues in cpufreq_init_policy(). -- Viresh Original cover letter fro Quentin: This series enables users of prebuilt kernels (e.g. distro kernels) to specify their CPUfreq governor of choice using the kernel command line, instead of having to wait for the system to fully boot to userspace to switch using the sysfs interface. This is helpful for 2 reasons: 1. users get to choose the governor that runs during the actual boot; 2. it simplifies the userspace boot procedure a bit (one less thing to worry about). To enable this, the first patch moves all governor init calls to core_initcall, to make sure they are registered by the time the drivers probe. This should be relatively low impact as registering a governor is a simple procedure (it gets added to a llist), and all governors already load at core_initcall anyway when they're set as the default in Kconfig. This also allows to clean-up the governors' init/exit code, and reduces boilerplate. The second patch introduces the new command line parameter, inspired by its cpuidle counterpart. More details can be found in the respective patch headers. Changes in v2: - added Viresh's ack to patch 01 - moved the assignment of 'default_governor' in patch 02 to the governor registration path instead of the driver registration (Viresh) Quentin Perret (2): cpufreq: Register governors at core_initcall cpufreq: Specify default governor on command line Viresh Kumar (1): cpufreq: Fix locking issues with governors .../admin-guide/kernel-parameters.txt | 5 ++ Documentation/admin-guide/pm/cpufreq.rst | 6 +- .../platforms/cell/cpufreq_spudemand.c | 26 +----- drivers/cpufreq/cpufreq.c | 87 ++++++++++++------- drivers/cpufreq/cpufreq_conservative.c | 22 ++--- drivers/cpufreq/cpufreq_ondemand.c | 24 ++--- drivers/cpufreq/cpufreq_performance.c | 14 +-- drivers/cpufreq/cpufreq_powersave.c | 18 +--- drivers/cpufreq/cpufreq_userspace.c | 18 +--- include/linux/cpufreq.h | 14 +++ kernel/sched/cpufreq_schedutil.c | 6 +- 11 files changed, 100 insertions(+), 140 deletions(-) -- 2.25.0.rc1.19.g042ed3e048af
WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar@linaro.org> To: Rafael Wysocki <rjw@rjwysocki.net>, Arnd Bergmann <arnd@arndb.de>, Ben Segall <bsegall@google.com>, Dietmar Eggemann <dietmar.eggemann@arm.com>, Ingo Molnar <mingo@redhat.com>, Jonathan Corbet <corbet@lwn.net>, Juri Lelli <juri.lelli@redhat.com>, Mel Gorman <mgorman@suse.de>, Peter Zijlstra <peterz@infradead.org>, Steven Rostedt <rostedt@goodmis.org>, Vincent Guittot <vincent.guittot@linaro.org>, Viresh Kumar <viresh.kumar@linaro.org> Cc: linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, adharmap@codeaurora.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Quentin Perret <qperret@google.com>, kernel-team@android.com, tkjos@google.com Subject: [PATCH V4 0/3] cpufreq: Allow default governor on cmdline and fix locking issues Date: Mon, 29 Jun 2020 13:54:57 +0530 [thread overview] Message-ID: <cover.1593418662.git.viresh.kumar@linaro.org> (raw) Hi, I have picked Quentin's series over my patch, modified both and tested. V3->V4: - Do __module_get() for cpufreq_default_governor() case as well and get rid of an extra variable. - Use a single character array, default_governor, instead of two of them. V2->V3: - default_governor is a string now and we don't set it on governor registration or unregistration anymore. - Fixed locking issues in cpufreq_init_policy(). -- Viresh Original cover letter fro Quentin: This series enables users of prebuilt kernels (e.g. distro kernels) to specify their CPUfreq governor of choice using the kernel command line, instead of having to wait for the system to fully boot to userspace to switch using the sysfs interface. This is helpful for 2 reasons: 1. users get to choose the governor that runs during the actual boot; 2. it simplifies the userspace boot procedure a bit (one less thing to worry about). To enable this, the first patch moves all governor init calls to core_initcall, to make sure they are registered by the time the drivers probe. This should be relatively low impact as registering a governor is a simple procedure (it gets added to a llist), and all governors already load at core_initcall anyway when they're set as the default in Kconfig. This also allows to clean-up the governors' init/exit code, and reduces boilerplate. The second patch introduces the new command line parameter, inspired by its cpuidle counterpart. More details can be found in the respective patch headers. Changes in v2: - added Viresh's ack to patch 01 - moved the assignment of 'default_governor' in patch 02 to the governor registration path instead of the driver registration (Viresh) Quentin Perret (2): cpufreq: Register governors at core_initcall cpufreq: Specify default governor on command line Viresh Kumar (1): cpufreq: Fix locking issues with governors .../admin-guide/kernel-parameters.txt | 5 ++ Documentation/admin-guide/pm/cpufreq.rst | 6 +- .../platforms/cell/cpufreq_spudemand.c | 26 +----- drivers/cpufreq/cpufreq.c | 87 ++++++++++++------- drivers/cpufreq/cpufreq_conservative.c | 22 ++--- drivers/cpufreq/cpufreq_ondemand.c | 24 ++--- drivers/cpufreq/cpufreq_performance.c | 14 +-- drivers/cpufreq/cpufreq_powersave.c | 18 +--- drivers/cpufreq/cpufreq_userspace.c | 18 +--- include/linux/cpufreq.h | 14 +++ kernel/sched/cpufreq_schedutil.c | 6 +- 11 files changed, 100 insertions(+), 140 deletions(-) -- 2.25.0.rc1.19.g042ed3e048af
next reply other threads:[~2020-06-29 19:16 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-29 8:24 Viresh Kumar [this message] 2020-06-29 8:24 ` [PATCH V4 0/3] cpufreq: Allow default governor on cmdline and fix locking issues Viresh Kumar 2020-06-29 8:24 ` [PATCH V4 1/3] cpufreq: Fix locking issues with governors Viresh Kumar 2020-06-29 9:37 ` Quentin Perret 2020-06-29 8:24 ` [PATCH V4 2/3] cpufreq: Register governors at core_initcall Viresh Kumar 2020-06-29 8:24 ` Viresh Kumar 2020-06-29 8:25 ` [PATCH V4 3/3] cpufreq: Specify default governor on command line Viresh Kumar 2020-06-29 9:44 ` Quentin Perret 2020-06-29 9:46 ` Viresh Kumar 2020-06-29 9:48 ` Quentin Perret 2020-06-29 9:49 ` Viresh Kumar 2020-06-29 9:50 ` Quentin Perret 2020-06-29 9:54 ` Viresh Kumar 2020-06-29 9:55 ` Quentin Perret 2020-06-30 18:38 ` [PATCH V4 0/3] cpufreq: Allow default governor on cmdline and fix locking issues Rafael J. Wysocki 2020-06-30 18:38 ` Rafael J. Wysocki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1593418662.git.viresh.kumar@linaro.org \ --to=viresh.kumar@linaro.org \ --cc=adharmap@codeaurora.org \ --cc=arnd@arndb.de \ --cc=bsegall@google.com \ --cc=corbet@lwn.net \ --cc=dietmar.eggemann@arm.com \ --cc=juri.lelli@redhat.com \ --cc=kernel-team@android.com \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mgorman@suse.de \ --cc=mingo@redhat.com \ --cc=peterz@infradead.org \ --cc=qperret@google.com \ --cc=rjw@rjwysocki.net \ --cc=rostedt@goodmis.org \ --cc=tkjos@google.com \ --cc=vincent.guittot@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.