From: Melissa Wen <melissa.srw@gmail.com> To: dri-devel@lists.freedesktop.org Cc: Haneen Mohammed <hamohammed.sa@gmail.com>, Sumera Priyadarsini <sylphrenadin@gmail.com>, Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>, David Airlie <airlied@linux.ie> Subject: [PATCH v3 0/4] drm/vkms: add overlay plane support Date: Tue, 13 Apr 2021 04:48:29 -0300 [thread overview] Message-ID: <cover.1618299945.git.melissa.srw@gmail.com> (raw) Adding support to overlay type in addition to primary and cursor plane. The planes composition relies on the z order of the active planes and only occurs if there is a primary plane (as in the current behavior). The first patch switches the function of initializing planes from drm_universal_plane_init to drmm_universal_plane_alloc. It aims to improve aspects of allocation and cleanup operations, leaving it to the DRM infrastructure. The second patch generalizes variables and functions names to refer to any kind of plane, not only cursor. The goal is to reuse them for blending overlay and cursor planes to primary. The third patch enables the plane composition to selct the correct pixel blending operation according to the plane format (XRGB8888 or ARGB8888). The last patch creates a module option to enable overlay, and includes overlay to supported types of plane. When the overlay option is enabled, one overlay plane is initialized (plus primary and cursor) and it is included in the planes composition. This work preserves the current results of IGT tests: kms_cursor_crc; kms_flip and kms_writeback. In addition, subtests related to overlay in kms_atomic and kms_plane_cursor start to pass (pointed out in the commit message). --- v2: - Drop unnecessary changes that init crtc without cursor (Daniel) - Replace function to initialize planes (Daniel) - Add proper pixel blending op according to the plane format (Daniel) v3: - Proper use of the variable funcs (kernel bot) - Adjust the patch series format Melissa Wen (4): drm/vkms: init plane using drmm_universal_plane_alloc drm/vkms: rename cursor to plane on ops of planes composition drm/vkms: add XRGB planes composition drm/vkms: add overlay support drivers/gpu/drm/vkms/vkms_composer.c | 67 ++++++++++++++++++---------- drivers/gpu/drm/vkms/vkms_drv.c | 5 +++ drivers/gpu/drm/vkms/vkms_drv.h | 9 +++- drivers/gpu/drm/vkms/vkms_output.c | 28 ++++++------ drivers/gpu/drm/vkms/vkms_plane.c | 50 +++++++++++---------- 5 files changed, 96 insertions(+), 63 deletions(-) -- 2.30.2 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Melissa Wen <melissa.srw@gmail.com> To: dri-devel@lists.freedesktop.org Cc: Haneen Mohammed <hamohammed.sa@gmail.com>, Sumera Priyadarsini <sylphrenadin@gmail.com>, Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>, David Airlie <airlied@linux.ie> Subject: [PATCH v3 0/4] drm/vkms: add overlay plane support Date: Tue, 13 Apr 2021 04:51:55 -0300 [thread overview] Message-ID: <cover.1618299945.git.melissa.srw@gmail.com> (raw) Message-ID: <20210413075155.Tw7jcXq3kT4hccRUSibYgFE1qUg2D8Ij13F82TU-xkU@z> (raw) Adding support to overlay type in addition to primary and cursor plane. The planes composition relies on the z order of the active planes and only occurs if there is a primary plane (as in the current behavior). The first patch switches the function of initializing planes from drm_universal_plane_init to drmm_universal_plane_alloc. It aims to improve aspects of allocation and cleanup operations, leaving it to the DRM infrastructure. The second patch generalizes variables and functions names to refer to any kind of plane, not only cursor. The goal is to reuse them for blending overlay and cursor planes to primary. The third patch enables the plane composition to selct the correct pixel blending operation according to the plane format (XRGB8888 or ARGB8888). The last patch creates a module option to enable overlay, and includes overlay to supported types of plane. When the overlay option is enabled, one overlay plane is initialized (plus primary and cursor) and it is included in the planes composition. This work preserves the current results of IGT tests: kms_cursor_crc; kms_flip and kms_writeback. In addition, subtests related to overlay in kms_atomic and kms_plane_cursor start to pass (pointed out in the commit message). --- v2: - Drop unnecessary changes that init crtc without cursor (Daniel) - Replace function to initialize planes (Daniel) - Add proper pixel blending op according to the plane format (Daniel) v3: - Proper use of the variable funcs (kernel bot) - Adjust the patch series format Melissa Wen (4): drm/vkms: init plane using drmm_universal_plane_alloc drm/vkms: rename cursor to plane on ops of planes composition drm/vkms: add XRGB planes composition drm/vkms: add overlay support drivers/gpu/drm/vkms/vkms_composer.c | 67 ++++++++++++++++++---------- drivers/gpu/drm/vkms/vkms_drv.c | 5 +++ drivers/gpu/drm/vkms/vkms_drv.h | 9 +++- drivers/gpu/drm/vkms/vkms_output.c | 28 ++++++------ drivers/gpu/drm/vkms/vkms_plane.c | 50 +++++++++++---------- 5 files changed, 96 insertions(+), 63 deletions(-) -- 2.30.2 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2021-04-13 7:48 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-13 7:48 Melissa Wen [this message] 2021-04-13 7:51 ` [PATCH v3 0/4] drm/vkms: add overlay plane support Melissa Wen 2021-04-13 7:50 ` [PATCH v3 1/4] drm/vkms: init plane using drmm_universal_plane_alloc Melissa Wen 2021-04-14 9:43 ` Daniel Vetter 2021-04-13 7:53 ` [PATCH v3 2/4] drm/vkms: rename cursor to plane on ops of planes composition Melissa Wen 2021-04-14 9:44 ` Daniel Vetter 2021-04-13 7:54 ` [PATCH v3 3/4] drm/vkms: add XRGB " Melissa Wen 2021-04-14 9:51 ` Daniel Vetter 2021-04-13 7:56 ` [PATCH v3 4/4] drm/vkms: add overlay support Melissa Wen 2021-04-14 9:57 ` Daniel Vetter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1618299945.git.melissa.srw@gmail.com \ --to=melissa.srw@gmail.com \ --cc=airlied@linux.ie \ --cc=dri-devel@lists.freedesktop.org \ --cc=hamohammed.sa@gmail.com \ --cc=rodrigosiqueiramelo@gmail.com \ --cc=sylphrenadin@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.