All of lore.kernel.org
 help / color / mirror / Atom feed
From: alison.schofield@intel.com
To: Ben Widawsky <ben.widawsky@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Ira Weiny <ira.weiny@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>
Cc: Alison Schofield <alison.schofield@intel.com>,
	nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org
Subject: [ndctl PATCH 0/7] Add partitioning support for CXL memdevs
Date: Mon,  3 Jan 2022 12:16:11 -0800	[thread overview]
Message-ID: <cover.1641233076.git.alison.schofield@intel.com> (raw)

From: Alison Schofield <alison.schofield@intel.com>

To support changing partitions on CXL memdevs, first provide access
to device partitioning info. The first 4 patches add accessors to all
the partition info a CXL command parser needs in order to validate
the command. This info is added to cxl list to assist the user in
creating valid partition requests.

# cxl list -MP
[
  {
    "memdev":"mem0",
    "pmem_size":0,
    "ram_size":273535729664,
    "partition":{
      "active_volatile_capacity":273535729664,
      "active_persistent_capacity":0,
      "next_volatile_capacity":268435456,
      "next_persistent_capacity":273267294208,
      "total_capacity":273535729664,
      "volatile_only_capacity":0,
      "persistent_only_capacity":0,
      "partition_alignment":268435456
    }
  }
]

Next introduce libcxl ioctl() interfaces for the SET_PARTITION_INFO
mailbox command and the new CXL command. cxl-cli does the constraints
checking. It does not offer the IMMEDIATE mode option since we do not
have driver support for that yet.

# cxl set-partition-info
 usage: cxl set-partition-info <mem0> [<mem1>..<memN>] [<options>]

    -v, --verbose         turn on debug
    -s, --volatile_size <n>
                          next volatile partition size in bytes

Guessing that a libcxl user could send the SET_PARTITION_INFO mailbox
command outside of cxl-cli tool, so a kernel patch that disables the
immediate bit, on the receiving end of the ioctl, follows.

It may be simpler to block the immediate bit in the libcxl API today,
(and as I write this cover letter I'm wondering just how far this goes
astray ;)) However, the kernel patch to peek in the payload sets us on
the path of inspecting set-partition-info mailbox commands in the future,
when immediate mode support is required.

Testing - so far I've only tested w one memdev in a Simics env. So,
next will be growing that Simics config, using cxl_test env, and 
adding a unit test.

Alison Schofield (7):
  libcxl: add GET_PARTITION_INFO mailbox command and accessors
  libcxl: add accessors for capacity fields of the IDENTIFY command
  libcxl: apply CXL_CAPACITY_MULTIPLIER to partition alignment field
  cxl: add memdev partition information to cxl-list
  libcxl: add interfaces for SET_PARTITION_INFO mailbox command
  ndctl, util: use 'unsigned long long' type in OPT_U64 define
  cxl: add command set-partition-info

 Documentation/cxl/cxl-list.txt               |  23 ++++
 Documentation/cxl/cxl-set-partition-info.txt |  27 +++++
 Documentation/cxl/partition-description.txt  |  15 +++
 Documentation/cxl/partition-options.txt      |  19 +++
 Documentation/cxl/Makefile.am                |   3 +-
 cxl/builtin.h                                |   1 +
 cxl/lib/private.h                            |  19 +++
 cxl/libcxl.h                                 |  12 ++
 util/json.h                                  |   1 +
 util/parse-options.h                         |   2 +-
 util/size.h                                  |   1 +
 cxl/cxl.c                                    |   1 +
 cxl/lib/libcxl.c                             | 117 ++++++++++++++++++-
 cxl/lib/libcxl.sym                           |  11 ++
 cxl/list.c                                   |   5 +
 cxl/memdev.c                                 |  89 ++++++++++++++
 util/json.c                                  | 112 ++++++++++++++++++
 17 files changed, 455 insertions(+), 3 deletions(-)
 create mode 100644 Documentation/cxl/cxl-set-partition-info.txt
 create mode 100644 Documentation/cxl/partition-description.txt
 create mode 100644 Documentation/cxl/partition-options.txt

-- 
2.31.1


             reply	other threads:[~2022-01-03 20:11 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-03 20:16 alison.schofield [this message]
2022-01-03 20:16 ` [ndctl PATCH 1/7] libcxl: add GET_PARTITION_INFO mailbox command and accessors alison.schofield
2022-01-06 20:19   ` Ira Weiny
2022-01-06 21:21     ` Dan Williams
2022-01-06 21:30       ` Ira Weiny
2022-01-06 21:57       ` Verma, Vishal L
2022-01-07 20:27         ` Alison Schofield
2022-01-07 19:56     ` Alison Schofield
2022-01-03 20:16 ` [ndctl PATCH 2/7] libcxl: add accessors for capacity fields of the IDENTIFY command alison.schofield
2022-01-06 20:36   ` Ira Weiny
2022-01-07 20:25     ` Alison Schofield
2022-01-03 20:16 ` [ndctl PATCH 3/7] libcxl: apply CXL_CAPACITY_MULTIPLIER to partition alignment field alison.schofield
2022-01-06 20:40   ` Ira Weiny
2022-01-07 20:01     ` Verma, Vishal L
2022-01-03 20:16 ` [ndctl PATCH 4/7] cxl: add memdev partition information to cxl-list alison.schofield
2022-01-06 20:49   ` Ira Weiny
2022-01-07 20:52     ` Alison Schofield
2022-01-06 21:51   ` Dan Williams
2022-01-07 20:32     ` Alison Schofield
2022-01-03 20:16 ` [ndctl PATCH 5/7] libcxl: add interfaces for SET_PARTITION_INFO mailbox command alison.schofield
2022-01-06 20:53   ` Ira Weiny
2022-01-08  1:51     ` Alison Schofield
2022-01-08  2:27       ` Dan Williams
2022-01-10  2:13         ` Alison Schofield
2022-01-03 20:16 ` [ndctl PATCH 6/7] ndctl, util: use 'unsigned long long' type in OPT_U64 define alison.schofield
2022-01-06 20:54   ` Ira Weiny
2022-01-07 20:59     ` Alison Schofield
2022-01-03 20:16 ` [ndctl PATCH 7/7] cxl: add command set-partition-info alison.schofield
2022-01-06 21:05   ` Ira Weiny
2022-01-07 22:51     ` Alison Schofield
2022-01-06 21:35   ` Dan Williams
2022-01-07 22:46     ` Alison Schofield
2022-01-06 22:19   ` Dan Williams
2022-01-07 22:45     ` Alison Schofield
2022-01-10 21:37       ` Alison Schofield
2022-01-06 20:32 ` [ndctl PATCH 0/7] Add partitioning support for CXL memdevs Ira Weiny
2022-01-07 19:44   ` Alison Schofield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1641233076.git.alison.schofield@intel.com \
    --to=alison.schofield@intel.com \
    --cc=ben.widawsky@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=ira.weiny@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.