All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Coddington <bcodding@redhat.com>
To: trond.myklebust@hammerspace.com, anna@kernel.org
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH v2 0/2] NFSv4 READDIR d_type fixup
Date: Thu, 19 Oct 2023 09:33:59 -0400	[thread overview]
Message-ID: <cover.1697722160.git.bcodding@redhat.com> (raw)

This is a combined posting of two previously posted patches.  The first
unconditionally adds the type attribute to the list of requested attributes
for v4 READDIR.  The second patch enables a per-mount modification via sysfs
of any of the attributes the client will currently decode for v4 READDIR.

The first patch solves a real problem but may cause a performance regression
for some servers that require extra processing to return inode information
along with the namespace.  We performed an informal survey of most of the
major NFSv4 server vendors and although we did not learn of any that may be
impacted, the potential remains.

The second patch gives us a way to disable this new READDIR behavior should
we find a serious impact in an existing setup.  I would appreciate serious
consideration of this patch in light of the number of claimed performance
regressions that have been reported almost every time we touch this
sensitive operation on the client.

For example:

echo 0x800 0x800000 0x0 > /sys/fs/nfs/0\:57/v4_readdir_attrs

.. will revert the behavior change from patch 1.

Changes on v2:
	- fix patch 2/2 to compile without CONFIG_NFS_4

Benjamin Coddington (2):
  NFSv4: Always ask for type with READDIR
  NFSv4: Allow per-mount tuning of READDIR attrs

 fs/nfs/client.c           |  4 ++
 fs/nfs/nfs4client.c       |  4 ++
 fs/nfs/nfs4proc.c         |  1 +
 fs/nfs/nfs4xdr.c          |  9 ++--
 fs/nfs/sysfs.c            | 86 +++++++++++++++++++++++++++++++++++++++
 include/linux/nfs_fs_sb.h |  1 +
 include/linux/nfs_xdr.h   |  1 +
 7 files changed, 101 insertions(+), 5 deletions(-)


base-commit: 401644852d0b2a278811de38081be23f74b5bb04
-- 
2.41.0


             reply	other threads:[~2023-10-19 13:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-19 13:33 Benjamin Coddington [this message]
2023-10-19 13:34 ` [PATCH v2 1/2] NFSv4: Always ask for type with READDIR Benjamin Coddington
2023-10-19 13:34 ` [PATCH v2 2/2] NFSv4: Allow per-mount tuning of READDIR attrs Benjamin Coddington
2023-10-19 15:01   ` kernel test robot
2023-10-19 16:55   ` Jeff Layton
2023-10-19 17:31     ` Benjamin Coddington

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1697722160.git.bcodding@redhat.com \
    --to=bcodding@redhat.com \
    --cc=anna@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.