From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>,
"Julien Grall" <julien@xen.org>
Subject: [PATCH 4/4] x86/ACPI: don't invalidate S5 data when S3 wakeup vector cannot be determined
Date: Mon, 23 Nov 2020 13:41:06 +0100 [thread overview]
Message-ID: <d2b9d231-8a05-6164-66f8-74d7bfe4b40f@suse.com> (raw)
In-Reply-To: <7f895b0e-f46f-8fe2-b0ac-e0503ef06a1f@suse.com>
We can be more tolerant as long as the data collected from FACS is only
needed to enter S3. A prior change already added suitable checking to
acpi_enter_sleep().
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/acpi/boot.c
+++ b/xen/arch/x86/acpi/boot.c
@@ -420,22 +420,22 @@ acpi_fadt_parse_sleep_info(struct acpi_t
facs_pa = (uint64_t)fadt->facs;
}
if (!facs_pa)
- goto bad;
+ return;
facs = acpi_os_map_memory(facs_pa, sizeof(*facs));
if (!facs)
- goto bad;
+ return;
if (strncmp(facs->signature, "FACS", 4)) {
printk(KERN_ERR PREFIX "Invalid FACS signature %.4s\n",
facs->signature);
- goto bad;
+ goto done;
}
if (facs->length < 24) {
printk(KERN_ERR PREFIX "Invalid FACS table length: %#x",
facs->length);
- goto bad;
+ goto done;
}
if (facs->length < 64)
@@ -452,6 +452,7 @@ acpi_fadt_parse_sleep_info(struct acpi_t
offsetof(struct acpi_table_facs, firmware_waking_vector);
acpi_sinfo.vector_width = 32;
+ done:
acpi_os_unmap_memory(facs, sizeof(*facs));
printk(KERN_INFO PREFIX
next prev parent reply other threads:[~2020-11-23 12:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 12:38 [PATCH 0/4] x86: ACPI and DMI table mapping fixes Jan Beulich
2020-11-23 12:39 ` [PATCH 1/4] x86/ACPI: fix mapping of FACS Jan Beulich
2020-11-23 14:30 ` Roger Pau Monné
2020-12-29 10:56 ` Roger Pau Monné
2021-01-04 13:18 ` Jan Beulich
2020-11-23 12:40 ` [PATCH 2/4] x86/ACPI: fix S3 wakeup vector mapping Jan Beulich
2020-11-23 15:24 ` Roger Pau Monné
2020-11-23 15:30 ` Jan Beulich
2020-11-23 16:07 ` Roger Pau Monné
2020-11-23 16:14 ` Andrew Cooper
2020-11-24 11:04 ` Jan Beulich
2020-11-30 13:02 ` Jan Beulich
2020-12-23 15:09 ` Ping: " Jan Beulich
2020-12-29 10:54 ` Roger Pau Monné
2021-01-04 14:03 ` Jan Beulich
2021-01-04 15:13 ` Roger Pau Monné
2020-12-29 10:51 ` Roger Pau Monné
2021-01-04 14:10 ` Jan Beulich
2020-11-23 12:40 ` [PATCH 3/4] x86/DMI: fix table mapping when one lives above 1Mb Jan Beulich
2020-11-23 15:41 ` Roger Pau Monné
2020-11-23 12:41 ` Jan Beulich [this message]
2020-11-23 15:44 ` [PATCH 4/4] x86/ACPI: don't invalidate S5 data when S3 wakeup vector cannot be determined Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2b9d231-8a05-6164-66f8-74d7bfe4b40f@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien@xen.org \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.