From: Nicola Vetrini <nicola.vetrini@bugseng.com>
To: nicola.vetrini@bugseng.com, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, michal.orzel@amd.com,
xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com,
consulting@bugseng.com, "Julien Grall" <julien@xen.org>,
"Bertrand Marquis" <bertrand.marquis@arm.com>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Jan Beulich" <jbeulich@suse.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>
Subject: [XEN PATCH 07/10] xen/efi: efibind: address violations of MISRA C Rule 20.7
Date: Mon, 18 Mar 2024 12:53:50 +0100 [thread overview]
Message-ID: <d2bc16c1b2d00b85f4b1a96bd855bbfe38861e87.1710762555.git.nicola.vetrini@bugseng.com> (raw)
In-Reply-To: <cover.1710762555.git.nicola.vetrini@bugseng.com>
MISRA C Rule 20.7 states: "Expressions resulting from the expansion
of macro parameters shall be enclosed in parentheses". Therefore, some
macro definitions should gain additional parentheses to ensure that all
current and future users will be safe with respect to expansions that
can possibly alter the semantics of the passed-in macro parameter.
No functional change.
Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
---
This file is matched by exclude-list.json, but the fix is rather trivial
and impacts code that in under the scope of MISRA compliance.
---
xen/arch/arm/include/asm/arm64/efibind.h | 4 ++--
xen/arch/x86/include/asm/x86_64/efibind.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/xen/arch/arm/include/asm/arm64/efibind.h b/xen/arch/arm/include/asm/arm64/efibind.h
index f13eadd4f0ab..a1323d452e2e 100644
--- a/xen/arch/arm/include/asm/arm64/efibind.h
+++ b/xen/arch/arm/include/asm/arm64/efibind.h
@@ -22,9 +22,9 @@ Revision History
#pragma pack()
#endif
-#define EFIERR(a) (0x8000000000000000ULL | a)
+#define EFIERR(a) (0x8000000000000000ULL | (a))
#define EFI_ERROR_MASK 0x8000000000000000ULL
-#define EFIERR_OEM(a) (0xc000000000000000ULL | a)
+#define EFIERR_OEM(a) (0xc000000000000000ULL | (a))
#define BAD_POINTER 0xFBFBFBFBFBFBFBFBULL
#define MAX_ADDRESS 0xFFFFFFFFFFFFFFFFULL
diff --git a/xen/arch/x86/include/asm/x86_64/efibind.h b/xen/arch/x86/include/asm/x86_64/efibind.h
index e23cd16cb6a0..28bc18c24bb3 100644
--- a/xen/arch/x86/include/asm/x86_64/efibind.h
+++ b/xen/arch/x86/include/asm/x86_64/efibind.h
@@ -117,9 +117,9 @@ typedef uint64_t UINTN;
#endif
#endif
-#define EFIERR(a) (0x8000000000000000 | a)
+#define EFIERR(a) (0x8000000000000000 | (a))
#define EFI_ERROR_MASK 0x8000000000000000
-#define EFIERR_OEM(a) (0xc000000000000000 | a)
+#define EFIERR_OEM(a) (0xc000000000000000 | (a))
#define BAD_POINTER 0xFBFBFBFBFBFBFBFB
--
2.34.1
next prev parent reply other threads:[~2024-03-18 11:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 11:53 [XEN PATCH 00/10] address some violations of MISRA C Rule 20.7 Nicola Vetrini
2024-03-18 11:53 ` [XEN PATCH 01/10] x86/cpufeature: add parentheses to comply with " Nicola Vetrini
2024-03-18 16:42 ` Jan Beulich
2024-03-18 11:53 ` [XEN PATCH 02/10] AMD/IOMMU: guest: address violations of MISRA C " Nicola Vetrini
2024-03-18 16:43 ` Jan Beulich
2024-03-18 11:53 ` [XEN PATCH 03/10] xen/xsm: add parentheses to comply with " Nicola Vetrini
2024-03-19 3:32 ` Stefano Stabellini
2024-03-18 11:53 ` [XEN PATCH 04/10] xen/device_tree: address violations of " Nicola Vetrini
2024-03-19 3:33 ` Stefano Stabellini
2024-03-18 11:53 ` [XEN PATCH 05/10] EFI: " Nicola Vetrini
2024-03-18 16:47 ` Jan Beulich
2024-03-18 11:53 ` [XEN PATCH 06/10] xen/arm: smmu: " Nicola Vetrini
2024-03-19 3:32 ` Stefano Stabellini
2024-03-18 11:53 ` Nicola Vetrini [this message]
2024-03-18 16:49 ` [XEN PATCH 07/10] xen/efi: efibind: " Jan Beulich
2024-03-18 17:03 ` Nicola Vetrini
2024-03-18 11:53 ` [XEN PATCH 08/10] xen/notifier: " Nicola Vetrini
2024-03-18 16:50 ` Jan Beulich
2024-03-18 11:53 ` [XEN PATCH 09/10] xen/wait: " Nicola Vetrini
2024-03-18 16:51 ` Jan Beulich
2024-03-18 11:53 ` [XEN PATCH 10/10] xen/sched: " Nicola Vetrini
2024-03-18 12:00 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2bc16c1b2d00b85f4b1a96bd855bbfe38861e87.1710762555.git.nicola.vetrini@bugseng.com \
--to=nicola.vetrini@bugseng.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=ayan.kumar.halder@amd.com \
--cc=bertrand.marquis@arm.com \
--cc=consulting@bugseng.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xenia.ragiadakou@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.