From: Omar Sandoval <osandov@osandov.com>
To: linux-btrfs@vger.kernel.org
Cc: kernel-team@fb.com, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>
Subject: [PATCH 01/10] Btrfs: remove stale comment referencing vmtruncate()
Date: Wed, 9 May 2018 23:21:02 -0700 [thread overview]
Message-ID: <d50e22690bdea060f485ac1dc19a54fa4d6e4411.1525932796.git.osandov@fb.com> (raw)
In-Reply-To: <cover.1525932796.git.osandov@fb.com>
In-Reply-To: <cover.1525932796.git.osandov@fb.com>
From: Omar Sandoval <osandov@fb.com>
Commit a41ad394a03b ("Btrfs: convert to the new truncate sequence")
changed vmtruncate() to truncate_setsize() but didn't update the comment
above it. truncate_setsize() never fails (the IS_SWAPFILE() check
happens elsewhere), so remove the comment.
Signed-off-by: Omar Sandoval <osandov@fb.com>
---
fs/btrfs/inode.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index d241285a0d2a..fef8dbb6a93f 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -5106,7 +5106,6 @@ static int btrfs_setsize(struct inode *inode, struct iattr *attr)
if (ret)
return ret;
- /* we don't support swapfiles, so vmtruncate shouldn't fail */
truncate_setsize(inode, newsize);
/* Disable nonlocked read DIO to avoid the end less truncate */
--
2.17.0
next prev parent reply other threads:[~2018-05-10 6:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 6:21 [PATCH 00/10] Btrfs: orphan and truncate fixes Omar Sandoval
2018-05-10 6:21 ` Omar Sandoval [this message]
2018-05-10 6:21 ` [PATCH 02/10] Btrfs: fix error handling in btrfs_truncate_inode_items() Omar Sandoval
2018-05-10 8:09 ` Nikolay Borisov
2018-05-10 6:21 ` [PATCH 03/10] Btrfs: don't BUG_ON() " Omar Sandoval
2018-05-10 8:10 ` Nikolay Borisov
2018-05-10 6:21 ` [PATCH 04/10] Btrfs: stop creating orphan items for truncate Omar Sandoval
2018-05-10 6:21 ` [PATCH 05/10] Btrfs: don't release reserve or decrement orphan count if orphan item already existed Omar Sandoval
2018-05-10 8:23 ` Nikolay Borisov
2018-05-10 6:21 ` [PATCH 06/10] Btrfs: don't return ino if inode item removal fails Omar Sandoval
2018-05-10 8:29 ` Nikolay Borisov
2018-05-10 21:44 ` Omar Sandoval
2018-05-10 6:21 ` [PATCH 07/10] Btrfs: refactor btrfs_evict_inode() reserve refill dance Omar Sandoval
2018-05-10 8:35 ` Nikolay Borisov
2018-05-10 6:21 ` [PATCH 08/10] Btrfs: fix ENOSPC caused by orphan items reservations Omar Sandoval
2018-05-10 8:50 ` Nikolay Borisov
2018-05-10 23:25 ` Omar Sandoval
2018-05-10 6:21 ` [PATCH 09/10] Btrfs: get rid of unused orphan infrastructure Omar Sandoval
2018-05-10 6:21 ` [PATCH 10/10] Btrfs: reserve space for O_TMPFILE orphan item deletion Omar Sandoval
2018-05-10 15:25 ` Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d50e22690bdea060f485ac1dc19a54fa4d6e4411.1525932796.git.osandov@fb.com \
--to=osandov@osandov.com \
--cc=clm@fb.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.