From: Arvind Yadav <arvind.yadav.cs@gmail.com> To: dmitry.torokhov@gmail.com, maxime.ripard@free-electrons.com, wens@csie.org, mcuos.com@gmail.com, linux@roeck-us.net, linux@armlinux.org.uk, lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 03/10 v3] Input: twl4030_keypad: Fix platform_get_irq's error checking Date: Sat, 18 Nov 2017 16:25:10 +0530 [thread overview] Message-ID: <d5ca46d63a41f47411b94c6035d3b8c46bbe8503.1510999558.git.arvind.yadav.cs@gmail.com> (raw) In-Reply-To: <a9a25cd5775ba4c76d47e8b66934e470f58d9e72.1510999558.git.arvind.yadav.cs@gmail.com> In-Reply-To: <a9a25cd5775ba4c76d47e8b66934e470f58d9e72.1510999558.git.arvind.yadav.cs@gmail.com> The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- changes in v2 : kp->irq is unsigned. use temporary int variable irq. changes in v3 : Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid. drivers/input/keyboard/twl4030_keypad.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/input/keyboard/twl4030_keypad.c b/drivers/input/keyboard/twl4030_keypad.c index f9f98ef..d921238 100644 --- a/drivers/input/keyboard/twl4030_keypad.c +++ b/drivers/input/keyboard/twl4030_keypad.c @@ -341,6 +341,7 @@ static int twl4030_kp_probe(struct platform_device *pdev) struct input_dev *input; u8 reg; int error; + int irq; kp = devm_kzalloc(&pdev->dev, sizeof(*kp), GFP_KERNEL); if (!kp) @@ -388,11 +389,12 @@ static int twl4030_kp_probe(struct platform_device *pdev) return -EINVAL; } - kp->irq = platform_get_irq(pdev, 0); - if (!kp->irq) { + irq = platform_get_irq(pdev, 0); + if (irq <= 0) { dev_err(&pdev->dev, "no keyboard irq assigned\n"); - return -EINVAL; + return irq; } + kp->irq = irq; error = matrix_keypad_build_keymap(keymap_data, NULL, TWL4030_MAX_ROWS, -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: arvind.yadav.cs@gmail.com (Arvind Yadav) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 03/10 v3] Input: twl4030_keypad: Fix platform_get_irq's error checking Date: Sat, 18 Nov 2017 16:25:10 +0530 [thread overview] Message-ID: <d5ca46d63a41f47411b94c6035d3b8c46bbe8503.1510999558.git.arvind.yadav.cs@gmail.com> (raw) In-Reply-To: <a9a25cd5775ba4c76d47e8b66934e470f58d9e72.1510999558.git.arvind.yadav.cs@gmail.com> The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- changes in v2 : kp->irq is unsigned. use temporary int variable irq. changes in v3 : Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid. drivers/input/keyboard/twl4030_keypad.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/input/keyboard/twl4030_keypad.c b/drivers/input/keyboard/twl4030_keypad.c index f9f98ef..d921238 100644 --- a/drivers/input/keyboard/twl4030_keypad.c +++ b/drivers/input/keyboard/twl4030_keypad.c @@ -341,6 +341,7 @@ static int twl4030_kp_probe(struct platform_device *pdev) struct input_dev *input; u8 reg; int error; + int irq; kp = devm_kzalloc(&pdev->dev, sizeof(*kp), GFP_KERNEL); if (!kp) @@ -388,11 +389,12 @@ static int twl4030_kp_probe(struct platform_device *pdev) return -EINVAL; } - kp->irq = platform_get_irq(pdev, 0); - if (!kp->irq) { + irq = platform_get_irq(pdev, 0); + if (irq <= 0) { dev_err(&pdev->dev, "no keyboard irq assigned\n"); - return -EINVAL; + return irq; } + kp->irq = irq; error = matrix_keypad_build_keymap(keymap_data, NULL, TWL4030_MAX_ROWS, -- 2.7.4
next prev parent reply other threads:[~2017-11-18 10:56 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-18 10:55 [PATCH 01/10 v3] Input: ep93xx_keypad: Fix platform_get_irq's error checking Arvind Yadav 2017-11-18 10:55 ` Arvind Yadav 2017-11-18 10:55 ` [PATCH 02/10 v3] Input: omap4-keypad: " Arvind Yadav 2017-11-18 10:55 ` Arvind Yadav 2017-11-18 10:55 ` Arvind Yadav [this message] 2017-11-18 10:55 ` [PATCH 03/10 v3] Input: twl4030_keypad: " Arvind Yadav 2017-11-18 10:55 ` [PATCH 04/10 v3] Input: serio: " Arvind Yadav 2017-11-18 10:55 ` Arvind Yadav 2017-11-18 10:55 ` [PATCH 05/10 v3] Input: cpcap-pwrbutton: Handle return value of platform_get_irq Arvind Yadav 2017-11-18 10:55 ` Arvind Yadav [not found] ` <76d6a73ba51e1a8a86d8d9a1d0bbbf7723d5153a.1510999334.git.arvind.yadav.cs@gmail.com> 2017-11-18 10:55 ` [PATCH 06/10 v2] Input: w90p910_ts: " Arvind Yadav 2017-11-18 10:55 ` Arvind Yadav 2017-11-18 10:55 ` [PATCH 08/10 v3] Input: twl4030-pwrbutton: " Arvind Yadav 2017-11-18 10:55 ` Arvind Yadav 2017-11-18 10:55 ` [PATCH 09/10 v2] Input: sirfsoc-onkey: " Arvind Yadav 2017-11-18 10:55 ` Arvind Yadav 2017-11-18 10:55 ` [PATCH 10/10 v2] Input: palmas-pwrbutton: " Arvind Yadav 2017-11-18 10:55 ` Arvind Yadav 2017-11-18 10:55 ` [PATCH 07/10 v3] Input: sun4i-ts: " Arvind Yadav 2017-11-18 10:55 ` Arvind Yadav 2017-11-18 18:30 ` [PATCH 01/10 v3] Input: ep93xx_keypad: Fix platform_get_irq's error checking Dmitry Torokhov 2017-11-18 18:30 ` Dmitry Torokhov 2017-11-20 16:24 ` arvindY 2017-11-20 16:24 ` arvindY
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d5ca46d63a41f47411b94c6035d3b8c46bbe8503.1510999558.git.arvind.yadav.cs@gmail.com \ --to=arvind.yadav.cs@gmail.com \ --cc=dmitry.torokhov@gmail.com \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=linux@roeck-us.net \ --cc=maxime.ripard@free-electrons.com \ --cc=mcuos.com@gmail.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.