All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Coddington <bcodding@redhat.com>
To: linux-nfs@vger.kernel.org
Subject: [PATCH 2/2] nfsd4: fix xdr4 count of server in fs_location4
Date: Sun,  7 Dec 2014 16:05:48 -0500	[thread overview]
Message-ID: <d602d4a37d02801659ddf5e6f012453b89169f70.1417985975.git.bcodding@redhat.com> (raw)
In-Reply-To: <cover.1417985975.git.bcodding@redhat.com>
In-Reply-To: <cover.1417985975.git.bcodding@redhat.com>

Fix a bug where nfsd4_encode_components_esc() incorrectly calculates the
length of server array in fs_location4.

Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
---
 fs/nfsd/nfs4xdr.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index 6c92a53..2a77603 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -1800,7 +1800,7 @@ static __be32 nfsd4_encode_components_esc(struct xdr_stream *xdr, char sep,
 
 		str = end;
 	}
-	pathlen = htonl(xdr->buf->len - pathlen_offset);
+	pathlen = htonl(count);
 	write_bytes_to_xdr_buf(xdr->buf, pathlen_offset, &pathlen, 4);
 	return 0;
 }
-- 
1.7.1


  parent reply	other threads:[~2014-12-07 21:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-07 21:05 [PATCH 0/2] Two nfsd referral xdr encoding bugs Benjamin Coddington
2014-12-07 21:05 ` [PATCH 1/2] nfsd4: fix xdr4 inclusion of escaped char Benjamin Coddington
2014-12-09 19:24   ` J. Bruce Fields
2014-12-09 19:57     ` Benjamin Coddington
2014-12-07 21:05 ` Benjamin Coddington [this message]
2014-12-09 17:37   ` [PATCH 2/2] nfsd4: fix xdr4 count of server in fs_location4 J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d602d4a37d02801659ddf5e6f012453b89169f70.1417985975.git.bcodding@redhat.com \
    --to=bcodding@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.