From: Lukas Wunner <lukas@wunner.de> To: linux-acpi@vger.kernel.org, devel@acpica.org Cc: platform-driver-x86@vger.kernel.org, Darren Hart <dvhart@infradead.org>, Corentin Chary <corentin.chary@gmail.com>, "Lee, Chun-Yi" <jlee@suse.com>, alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>, Hui Wang <hui.wang@canonical.com>, Mark Brown <broonie@kernel.org> Subject: [PATCH 1/5] ACPICA: Add acpi_dev_present Date: Mon, 23 Nov 2015 15:34:55 +0100 [thread overview] Message-ID: <d66501819cfa8f3d3b07708d3f20e3e20d07e4f8.1448282995.git.lukas@wunner.de> (raw) In-Reply-To: <cover.1448282995.git.lukas@wunner.de> There are 7 drivers which call acpi_get_devices to check for the presence of a particular ACPI HID, each defining its own copy of a mostly identical callback. Add acpi_dev_present, the ACPI equivalent to pci_dev_present, allowing us to deduplicate all that boilerplate in the drivers. Signed-off-by: Lukas Wunner <lukas@wunner.de> --- drivers/acpi/acpica/nsxfeval.c | 46 ++++++++++++++++++++++++++++++++++++++++++ include/acpi/acpixf.h | 7 +++++++ 2 files changed, 53 insertions(+) diff --git a/drivers/acpi/acpica/nsxfeval.c b/drivers/acpi/acpica/nsxfeval.c index 6ee1e52..19293fa 100644 --- a/drivers/acpi/acpica/nsxfeval.c +++ b/drivers/acpi/acpica/nsxfeval.c @@ -828,6 +828,52 @@ ACPI_EXPORT_SYMBOL(acpi_get_devices) /******************************************************************************* * + * FUNCTION: acpi_ns_dev_present_callback + * + * PARAMETERS: Callback from acpi_get_devices + * + * RETURN: Status + * + * DESCRIPTION: Minimal callback to be passed to acpi_get_devices which + * performs no further filtering and terminates the search + * immediately. + * + ******************************************************************************/ +static acpi_status acpi_ns_dev_present_callback(acpi_handle handle, u32 level, + void *context, void **retval) +{ + *(bool *)context = true; + return AE_CTRL_TERMINATE; +} + +/******************************************************************************* + * + * FUNCTION: acpi_dev_present + * + * PARAMETERS: HID - HID to search for. + * + * RETURNS True if a matching object of type Device was found. + * + * DESCRIPTION: Performs a walk of the namespace tree. When a matching object + * of type Device is found, the search is terminated immediately. + * + ******************************************************************************/ + +bool +acpi_dev_present(const char *HID) +{ + acpi_status status; + bool found = false; + + status = acpi_get_devices(HID, acpi_ns_dev_present_callback, &found, + NULL); + return ACPI_SUCCESS(status) && found; +} + +ACPI_EXPORT_SYMBOL(acpi_dev_present) + +/******************************************************************************* + * * FUNCTION: acpi_attach_data * * PARAMETERS: obj_handle - Namespace node diff --git a/include/acpi/acpixf.h b/include/acpi/acpixf.h index 3aaaa86..f299347 100644 --- a/include/acpi/acpixf.h +++ b/include/acpi/acpixf.h @@ -115,6 +115,11 @@ prototype; #endif +#ifndef ACPI_EXTERNAL_RETURN_BOOL +#define ACPI_EXTERNAL_RETURN_BOOL(prototype) \ + prototype; +#endif + /***************************************************************************** * * Public globals and runtime configuration options @@ -483,6 +488,8 @@ ACPI_EXTERNAL_RETURN_STATUS(acpi_status acpi_walk_callback user_function, void *context, void **return_value)) +ACPI_EXTERNAL_RETURN_BOOL(bool + acpi_dev_present(const char *HID)) ACPI_EXTERNAL_RETURN_STATUS(acpi_status acpi_get_name(acpi_handle object, u32 name_type, struct acpi_buffer *ret_path_ptr)) -- 1.8.5.2 (Apple Git-48)
WARNING: multiple messages have this Message-ID (diff)
From: Lukas Wunner <lukas at wunner.de> To: devel@acpica.org Subject: [Devel] [PATCH 1/5] ACPICA: Add acpi_dev_present Date: Mon, 23 Nov 2015 14:35:32 +0000 [thread overview] Message-ID: <d66501819cfa8f3d3b07708d3f20e3e20d07e4f8.1448282995.git.lukas@wunner.de> (raw) In-Reply-To: cover.1448282995.git.lukas@wunner.de [-- Attachment #1: Type: text/plain, Size: 3287 bytes --] There are 7 drivers which call acpi_get_devices to check for the presence of a particular ACPI HID, each defining its own copy of a mostly identical callback. Add acpi_dev_present, the ACPI equivalent to pci_dev_present, allowing us to deduplicate all that boilerplate in the drivers. Signed-off-by: Lukas Wunner <lukas(a)wunner.de> --- drivers/acpi/acpica/nsxfeval.c | 46 ++++++++++++++++++++++++++++++++++++++++++ include/acpi/acpixf.h | 7 +++++++ 2 files changed, 53 insertions(+) diff --git a/drivers/acpi/acpica/nsxfeval.c b/drivers/acpi/acpica/nsxfeval.c index 6ee1e52..19293fa 100644 --- a/drivers/acpi/acpica/nsxfeval.c +++ b/drivers/acpi/acpica/nsxfeval.c @@ -828,6 +828,52 @@ ACPI_EXPORT_SYMBOL(acpi_get_devices) /******************************************************************************* * + * FUNCTION: acpi_ns_dev_present_callback + * + * PARAMETERS: Callback from acpi_get_devices + * + * RETURN: Status + * + * DESCRIPTION: Minimal callback to be passed to acpi_get_devices which + * performs no further filtering and terminates the search + * immediately. + * + ******************************************************************************/ +static acpi_status acpi_ns_dev_present_callback(acpi_handle handle, u32 level, + void *context, void **retval) +{ + *(bool *)context = true; + return AE_CTRL_TERMINATE; +} + +/******************************************************************************* + * + * FUNCTION: acpi_dev_present + * + * PARAMETERS: HID - HID to search for. + * + * RETURNS True if a matching object of type Device was found. + * + * DESCRIPTION: Performs a walk of the namespace tree. When a matching object + * of type Device is found, the search is terminated immediately. + * + ******************************************************************************/ + +bool +acpi_dev_present(const char *HID) +{ + acpi_status status; + bool found = false; + + status = acpi_get_devices(HID, acpi_ns_dev_present_callback, &found, + NULL); + return ACPI_SUCCESS(status) && found; +} + +ACPI_EXPORT_SYMBOL(acpi_dev_present) + +/******************************************************************************* + * * FUNCTION: acpi_attach_data * * PARAMETERS: obj_handle - Namespace node diff --git a/include/acpi/acpixf.h b/include/acpi/acpixf.h index 3aaaa86..f299347 100644 --- a/include/acpi/acpixf.h +++ b/include/acpi/acpixf.h @@ -115,6 +115,11 @@ prototype; #endif +#ifndef ACPI_EXTERNAL_RETURN_BOOL +#define ACPI_EXTERNAL_RETURN_BOOL(prototype) \ + prototype; +#endif + /***************************************************************************** * * Public globals and runtime configuration options @@ -483,6 +488,8 @@ ACPI_EXTERNAL_RETURN_STATUS(acpi_status acpi_walk_callback user_function, void *context, void **return_value)) +ACPI_EXTERNAL_RETURN_BOOL(bool + acpi_dev_present(const char *HID)) ACPI_EXTERNAL_RETURN_STATUS(acpi_status acpi_get_name(acpi_handle object, u32 name_type, struct acpi_buffer *ret_path_ptr)) -- 1.8.5.2 (Apple Git-48)
next prev parent reply other threads:[~2015-11-23 14:34 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-11-23 14:34 [PATCH 0/5] Add acpi_dev_present Lukas Wunner 2015-11-23 14:35 ` [Devel] " Lukas Wunner 2015-11-23 14:34 ` Lukas Wunner [this message] 2015-11-23 14:35 ` [Devel] [PATCH 1/5] ACPICA: " Lukas Wunner 2015-11-23 22:34 ` Rafael J. Wysocki 2015-11-23 22:22 ` Moore, Robert 2015-11-23 22:22 ` [Devel] " Moore, Robert 2015-11-23 23:32 ` Lukas Wunner 2015-11-23 23:32 ` [Devel] " Lukas Wunner 2015-11-24 4:40 ` Hanjun Guo 2015-11-24 14:15 ` Moore, Robert 2015-11-24 14:15 ` [Devel] " Moore, Robert 2015-11-24 14:22 ` Rafael J. Wysocki 2015-11-24 14:54 ` Hanjun Guo 2015-11-24 14:54 ` [Devel] " Hanjun Guo 2015-11-23 14:34 ` [PATCH 3/5] acer-wmi: Use acpi_dev_present Lukas Wunner 2015-11-23 14:34 ` [Devel] " Lukas Wunner 2015-11-23 19:06 ` Darren Hart 2015-11-23 14:34 ` [PATCH 5/5] ASoC: Intel: " Lukas Wunner 2015-11-23 14:34 ` [Devel] " Lukas Wunner 2015-11-23 14:48 ` Mark Brown 2015-11-23 22:37 ` Rafael J. Wysocki 2015-11-23 14:34 ` [PATCH 4/5] ALSA: hda - " Lukas Wunner 2015-11-23 14:34 ` [Devel] " Lukas Wunner 2015-11-24 1:51 ` [alsa-devel] " Hui Wang 2015-11-23 14:34 ` [PATCH 2/5] eeepc-wmi: " Lukas Wunner 2015-11-23 14:34 ` [Devel] " Lukas Wunner 2015-11-23 19:04 ` Darren Hart 2015-11-23 19:55 ` Lukas Wunner 2015-11-23 19:55 ` [Devel] " Lukas Wunner 2015-11-23 21:00 ` Darren Hart 2015-11-23 22:35 ` Rafael J. Wysocki 2015-11-24 17:08 ` Darren Hart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d66501819cfa8f3d3b07708d3f20e3e20d07e4f8.1448282995.git.lukas@wunner.de \ --to=lukas@wunner.de \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=corentin.chary@gmail.com \ --cc=devel@acpica.org \ --cc=dvhart@infradead.org \ --cc=hui.wang@canonical.com \ --cc=jlee@suse.com \ --cc=linux-acpi@vger.kernel.org \ --cc=platform-driver-x86@vger.kernel.org \ --cc=tiwai@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.