All of lore.kernel.org
 help / color / mirror / Atom feed
From: Federico Serafini <federico.serafini@bugseng.com>
To: xen-devel@lists.xenproject.org
Cc: consulting@bugseng.com,
	Federico Serafini <federico.serafini@bugseng.com>,
	Tamas K Lengyel <tamas@tklengyel.com>,
	Alexandru Isaila <aisaila@bitdefender.com>,
	Petre Pircalabu <ppircalabu@bitdefender.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Michal Orzel <michal.orzel@amd.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [XEN PATCH 4/7] xen/arm: mem_access: address violations of MISRA C:2012 Rule 16.3
Date: Wed, 20 Dec 2023 12:03:04 +0100	[thread overview]
Message-ID: <d7a015aaa54fb4722d4970f0f40789efe4d994f9.1703066935.git.federico.serafini@bugseng.com> (raw)
In-Reply-To: <cover.1703066935.git.federico.serafini@bugseng.com>

Refactor of the code to have a break statement at the end of the
switch-clause. This addresses violations of Rule 16.3
("An unconditional `break' statement shall terminate every
switch-clause").
No functional change.

Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
---
 xen/arch/arm/mem_access.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/xen/arch/arm/mem_access.c b/xen/arch/arm/mem_access.c
index 31db846354..fbcb5471f7 100644
--- a/xen/arch/arm/mem_access.c
+++ b/xen/arch/arm/mem_access.c
@@ -168,10 +168,10 @@ p2m_mem_access_check_and_get_page(vaddr_t gva, unsigned long flag,
          * If this was a read then it was because of mem_access, but if it was
          * a write then the original get_page_from_gva fault was correct.
          */
-        if ( flag == GV2M_READ )
-            break;
-        else
+        if ( flag != GV2M_READ )
             goto err;
+
+        break;
     case XENMEM_access_rx2rw:
     case XENMEM_access_rx:
     case XENMEM_access_r:
@@ -179,10 +179,10 @@ p2m_mem_access_check_and_get_page(vaddr_t gva, unsigned long flag,
          * If this was a write then it was because of mem_access, but if it was
          * a read then the original get_page_from_gva fault was correct.
          */
-        if ( flag == GV2M_WRITE )
-            break;
-        else
+        if ( flag != GV2M_WRITE )
             goto err;
+
+        break;
     }
 
     /*
-- 
2.34.1



  parent reply	other threads:[~2023-12-20 11:03 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-20 11:03 [XEN PATCH 0/7] xen/arm: address violations of MISRA C:2012 Rule 16.3 Federico Serafini
2023-12-20 11:03 ` [XEN PATCH 1/7] xen/arm: gic-v3: " Federico Serafini
2023-12-20 11:09   ` Julien Grall
2023-12-20 11:03 ` [XEN PATCH 2/7] xen/arm: traps: " Federico Serafini
2023-12-20 11:44   ` Julien Grall
2023-12-20 11:03 ` [XEN PATCH 3/7] xen/arm: guest_walk: " Federico Serafini
2023-12-20 11:45   ` Julien Grall
2023-12-20 11:03 ` Federico Serafini [this message]
2023-12-20 11:53   ` [XEN PATCH 4/7] xen/arm: mem_access: " Julien Grall
2023-12-20 15:36     ` Tamas K Lengyel
2023-12-20 11:03 ` [XEN PATCH 5/7] xen/arm: v{cp,sys}reg: " Federico Serafini
2023-12-20 11:48   ` Julien Grall
2023-12-20 11:55     ` Jan Beulich
2023-12-20 12:15       ` Federico Serafini
2023-12-20 18:24         ` Stefano Stabellini
2023-12-20 21:23           ` Andrew Cooper
2023-12-21 10:29             ` Federico Serafini
2023-12-21 10:49               ` Andrew Cooper
2023-12-21 23:49                 ` Stefano Stabellini
2023-12-21  8:04         ` Jan Beulich
2023-12-21 23:49           ` Stefano Stabellini
2023-12-20 11:03 ` [XEN PATCH 6/7] xen/arm: mmu: address a " Federico Serafini
2023-12-20 11:49   ` Julien Grall
2023-12-20 11:03 ` [XEN PATCH 7/7] xen/arm: smmu-v3: address " Federico Serafini
2023-12-20 11:49   ` Julien Grall
2024-01-05 15:04     ` Federico Serafini
2024-01-05 15:09       ` Julien Grall
2024-01-05 15:14   ` Bertrand Marquis
2023-12-20 21:35 ` [XEN PATCH 0/7] xen/arm: " Andrew Cooper
2023-12-21  8:08   ` Jan Beulich
2023-12-21 10:50     ` Andrew Cooper
2023-12-21 10:34   ` Federico Serafini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7a015aaa54fb4722d4970f0f40789efe4d994f9.1703066935.git.federico.serafini@bugseng.com \
    --to=federico.serafini@bugseng.com \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=aisaila@bitdefender.com \
    --cc=bertrand.marquis@arm.com \
    --cc=consulting@bugseng.com \
    --cc=julien@xen.org \
    --cc=michal.orzel@amd.com \
    --cc=ppircalabu@bitdefender.com \
    --cc=sstabellini@kernel.org \
    --cc=tamas@tklengyel.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.