All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lourdes Pedrajas <lu@pplo.net>
To: outreachy-kernel@googlegroups.com
Cc: forest@alittletooquiet.net, gregkh@linuxfoundation.org
Subject: [PATCH 1/2] staging: vt6655: power.c: Remove setting ATIM Window in PSvEnablePowerSaving()
Date: Tue, 10 Mar 2020 15:09:07 +0100	[thread overview]
Message-ID: <d9b8e434e09cb8885026a71441bf3a6919dba3da.1583848946.git.lu@pplo.net> (raw)
In-Reply-To: <cover.1583848946.git.lu@pplo.net>
In-Reply-To: <cover.1583848946.git.lu@pplo.net>

Every time priv->op_mode is not NL80211_IFTYPE_ADHOC it sets ATIM Window, but
this feature it is marked TODO in 2014 and did go untouched since 2015.

Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
---
 drivers/staging/vt6655/power.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/staging/vt6655/power.c b/drivers/staging/vt6655/power.c
index bfd598a93b04..a68ec527679a 100644
--- a/drivers/staging/vt6655/power.c
+++ b/drivers/staging/vt6655/power.c
@@ -58,11 +58,6 @@ void PSvEnablePowerSaving(struct vnt_private *priv,
 	if (priv->op_mode != NL80211_IFTYPE_ADHOC) {
 		/* set AID */
 		VNSvOutPortW(priv->PortOffset + MAC_REG_AIDATIM, wAID);
-	} else {
-		/* set ATIM Window */
-#if 0 /* TODO atim window */
-		MACvWriteATIMW(priv->PortOffset, pMgmt->wCurrATIMWindow);
-#endif
 	}
 	/* Set AutoSleep */
 	MACvRegBitsOn(priv->PortOffset, MAC_REG_PSCFG, PSCFG_AUTOSLEEP);
-- 
2.17.1



  reply	other threads:[~2020-03-10 14:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-10 14:09 [PATCH 0/2] staging: vt6655: power.c: remove unused code and improve readability Lourdes Pedrajas
2020-03-10 14:09 ` Lourdes Pedrajas [this message]
2020-03-10 14:09 ` [PATCH 2/2] staging: vt6655: power.c: code reformatting for improved readability Lourdes Pedrajas
2020-03-10 17:08 ` [Outreachy kernel] [PATCH 0/2] staging: vt6655: power.c: remove unused code and improve readability Stefano Brivio
  -- strict thread matches above, loose matches on Subject: below --
2020-03-10 13:33 [PATCH 0/2] staging: exfat: exfat_super.c: " Lourdes Pedrajas
2020-03-10 13:33 ` [PATCH 1/2] staging: vt6655: power.c: Remove setting ATIM Window in PSvEnablePowerSaving() Lourdes Pedrajas
2020-03-10 13:28 remove unused code and improve readability Lourdes Pedrajas
2020-03-10 13:28 ` [PATCH 1/2] staging: vt6655: power.c: Remove setting ATIM Window in PSvEnablePowerSaving() Lourdes Pedrajas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9b8e434e09cb8885026a71441bf3a6919dba3da.1583848946.git.lu@pplo.net \
    --to=lu@pplo.net \
    --cc=forest@alittletooquiet.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.