All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Coddington <bcodding@redhat.com>
To: Trond Myklebust <trond.myklebust@primarydata.com>,
	Anna Schumaker <anna.schumaker@netapp.com>,
	Jeff Layton <jlayton@poochiereds.net>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	Christoph Hellwig <hch@infradead.org>
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH v4 04/10] NFSv4: Pass nfs_open_context instead of nfs4_state to nfs4_proc_unlck()
Date: Wed, 30 Dec 2015 08:14:00 -0500	[thread overview]
Message-ID: <de00367cffb871e754a3bd122e66b6fc4bfaa1b4.1451480826.git.bcodding@redhat.com> (raw)
In-Reply-To: <cover.1451480826.git.bcodding@redhat.com>
In-Reply-To: <cover.1451480826.git.bcodding@redhat.com>

nfs4_proc_unlk() acquires the nfs_open_context from the file_lock's
fl_file->private, but we will not always have a referenced fl_file in this
path.  Instead, pass along the nfs_open_context from the call to
nfs4_proc_lock().  This allows us to use nfs4_proc_unlck() without a
valid reference in fl_file.

Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
Reviewed-by: Jeff Layton <jeff.layton@primarydata.com>
---
 fs/nfs/nfs4proc.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 784ba4e..279c8b3 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -5656,8 +5656,10 @@ static struct rpc_task *nfs4_do_unlck(struct file_lock *fl,
 	return rpc_run_task(&task_setup_data);
 }
 
-static int nfs4_proc_unlck(struct nfs4_state *state, int cmd, struct file_lock *request)
+static int nfs4_proc_unlck(struct nfs_open_context *ctx,
+		int cmd, struct file_lock *request)
 {
+	struct nfs4_state *state = ctx->state;
 	struct inode *inode = state->inode;
 	struct nfs4_state_owner *sp = state->owner;
 	struct nfs_inode *nfsi = NFS_I(inode);
@@ -5693,7 +5695,7 @@ static int nfs4_proc_unlck(struct nfs4_state *state, int cmd, struct file_lock *
 	status = -ENOMEM;
 	if (IS_ERR(seqid))
 		goto out;
-	task = nfs4_do_unlck(request, nfs_file_open_context(request->fl_file), lsp, seqid);
+	task = nfs4_do_unlck(request, ctx, lsp, seqid);
 	status = PTR_ERR(task);
 	if (IS_ERR(task))
 		goto out;
@@ -6117,7 +6119,7 @@ nfs4_proc_lock(struct nfs_open_context *ctx, int cmd, struct file_lock *request)
 
 	if (request->fl_type == F_UNLCK) {
 		if (state != NULL)
-			return nfs4_proc_unlck(state, cmd, request);
+			return nfs4_proc_unlck(ctx, cmd, request);
 		return 0;
 	}
 
-- 
1.7.1


  parent reply	other threads:[~2015-12-30 13:14 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-30 13:13 [PATCH v4 00/10] locking fixups for NFS Benjamin Coddington
2015-12-30 13:13 ` [PATCH v4 01/10] NFS4: remove a redundant lock range check Benjamin Coddington
2016-01-03 12:00   ` Christoph Hellwig
2015-12-30 13:13 ` [PATCH v4 02/10] NFS: Move the flock open mode check into nfs_flock() Benjamin Coddington
2016-01-03 12:01   ` Christoph Hellwig
2015-12-30 13:13 ` [PATCH v4 03/10] NFS: Pass nfs_open_context instead of file to the lock procs Benjamin Coddington
2016-01-03 12:02   ` Christoph Hellwig
2015-12-30 13:14 ` Benjamin Coddington [this message]
2016-01-03 12:02   ` [PATCH v4 04/10] NFSv4: Pass nfs_open_context instead of nfs4_state to nfs4_proc_unlck() Christoph Hellwig
2015-12-30 13:14 ` [PATCH v4 05/10] lockd: Plumb nfs_open_context into nlm client unlock Benjamin Coddington
2016-01-03 12:03   ` Christoph Hellwig
2015-12-30 13:14 ` [PATCH v4 06/10] lockd: Send the inode to nlmclnt_setlockargs() Benjamin Coddington
2016-01-03 12:04   ` Christoph Hellwig
2015-12-30 13:14 ` [PATCH v4 07/10] lockd: do_vfs_lock() only needs the inode Benjamin Coddington
2016-01-03 12:04   ` Christoph Hellwig
2015-12-30 13:14 ` [PATCH v4 08/10] locks: Set FL_CLOSE when removing flock locks on close() Benjamin Coddington
2016-01-03 12:05   ` Christoph Hellwig
2015-12-30 13:14 ` [PATCH v4 09/10] NFS: Deferred unlocks - always unlock on FL_CLOSE Benjamin Coddington
2016-01-05  3:30   ` Trond Myklebust
2016-01-05 13:48     ` Benjamin Coddington
2015-12-30 13:14 ` [PATCH v4 10/10] NFS: cleanup do_vfs_lock() Benjamin Coddington
2016-01-03 12:06   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de00367cffb871e754a3bd122e66b6fc4bfaa1b4.1451480826.git.bcodding@redhat.com \
    --to=bcodding@redhat.com \
    --cc=anna.schumaker@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=hch@infradead.org \
    --cc=jlayton@poochiereds.net \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.