From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "George Dunlap" <George.Dunlap@eu.citrix.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH v3 3/8] x86/mce: bring hypercall subop compat checking in sync again
Date: Thu, 23 Jul 2020 17:49:16 +0200 [thread overview]
Message-ID: <dfad8cb1-e8a2-11ca-70f3-2342f9a04c12@suse.com> (raw)
In-Reply-To: <adb0fe93-c251-b84a-a357-936029af0e9c@suse.com>
Use a typedef in struct xen_mc also for the two subops "manually"
translated in the handler, just for consistency. No functional
change.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
--- a/xen/arch/x86/cpu/mcheck/mce.c
+++ b/xen/arch/x86/cpu/mcheck/mce.c
@@ -1307,16 +1307,16 @@ CHECK_mcinfo_common;
CHECK_FIELD_(struct, mc_fetch, flags);
CHECK_FIELD_(struct, mc_fetch, fetch_id);
-# define CHECK_compat_mc_fetch struct mc_fetch
+# define CHECK_mc_fetch struct mc_fetch
CHECK_FIELD_(struct, mc_physcpuinfo, ncpus);
-# define CHECK_compat_mc_physcpuinfo struct mc_physcpuinfo
+# define CHECK_mc_physcpuinfo struct mc_physcpuinfo
# define xen_ctl_bitmap xenctl_bitmap
CHECK_mc;
-# undef CHECK_compat_mc_fetch
-# undef CHECK_compat_mc_physcpuinfo
+# undef CHECK_mc_fetch
+# undef CHECK_mc_physcpuinfo
# undef xen_ctl_bitmap
# define xen_mc_info mc_info
--- a/xen/include/public/arch-x86/xen-mca.h
+++ b/xen/include/public/arch-x86/xen-mca.h
@@ -391,6 +391,7 @@ struct xen_mc_physcpuinfo {
/* OUT */
XEN_GUEST_HANDLE(xen_mc_logical_cpu_t) info;
};
+typedef struct xen_mc_physcpuinfo xen_mc_physcpuinfo_t;
#define XEN_MC_msrinject 4
#define MC_MSRINJ_MAXMSRS 8
@@ -436,9 +437,9 @@ struct xen_mc {
uint32_t cmd;
uint32_t interface_version; /* XEN_MCA_INTERFACE_VERSION */
union {
- struct xen_mc_fetch mc_fetch;
+ xen_mc_fetch_t mc_fetch;
xen_mc_notifydomain_t mc_notifydomain;
- struct xen_mc_physcpuinfo mc_physcpuinfo;
+ xen_mc_physcpuinfo_t mc_physcpuinfo;
xen_mc_msrinject_t mc_msrinject;
xen_mc_mceinject_t mc_mceinject;
#if defined(__XEN__) || defined(__XEN_TOOLS__)
next prev parent reply other threads:[~2020-07-23 15:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 15:45 [PATCH v3 0/8] x86: compat header generation and checking adjustments Jan Beulich
2020-07-23 15:48 ` [PATCH v3 1/8] x86: fix compat header generation Jan Beulich
2020-08-31 13:07 ` Jan Beulich
2020-09-02 21:23 ` Don Slutz
2020-09-03 6:25 ` Jan Beulich
2020-07-23 15:48 ` [PATCH v3 2/8] x86/mce: add compat struct checking for XEN_MC_inject_v2 Jan Beulich
2020-07-23 15:49 ` Jan Beulich [this message]
2020-07-23 15:49 ` [PATCH v3 4/8] x86/dmop: add compat struct checking for XEN_DMOP_map_mem_type_to_ioreq_server Jan Beulich
2020-07-23 15:50 ` [PATCH v3 5/8] evtchn: add compat struct checking for newer sub-ops Jan Beulich
2020-08-31 7:44 ` Ping: " Jan Beulich
2020-08-31 14:03 ` Roger Pau Monné
2020-07-23 15:50 ` [PATCH v3 6/8] x86: generalize padding field handling Jan Beulich
2020-07-23 15:51 ` [PATCH v3 7/8] flask: drop dead compat translation code Jan Beulich
2020-07-23 15:52 ` [PATCH v3 8/8] x86: only generate compat headers actually needed Jan Beulich
2020-07-24 4:33 ` [PATCH v3 0/8] x86: compat header generation and checking adjustments Jürgen Groß
2020-07-24 6:27 ` Jan Beulich
2020-09-02 6:12 ` [PATCH v3.1 1/8] x86: fix compat header generation Jan Beulich
2020-09-03 13:07 ` [PATCH v3.2 " Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfad8cb1-e8a2-11ca-70f3-2342f9a04c12@suse.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.