All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Ruderich <simon@ruderich.org>
To: qemu-devel@nongnu.org
Cc: Eric Blake <eblake@redhat.com>, Simon Ruderich <simon@ruderich.org>
Subject: [Qemu-devel] [PATCH v3 4/5] hmp: don't truncate size in hmp_memsave/hmp_pmemsave
Date: Mon, 21 May 2018 17:36:43 +0200	[thread overview]
Message-ID: <e07162bfefe8e4f376d52318c9ab53f7ad916176.1526916378.git.simon@ruderich.org> (raw)
In-Reply-To: <cover.1526916378.git.simon@ruderich.org>
In-Reply-To: <cover.1526916378.git.simon@ruderich.org>

The called function takes an uint64_t as size parameter and
qdict_get_int() returns an uint64_t. Don't truncate it needlessly to an
uint32_t.

Signed-off-by: Simon Ruderich <simon@ruderich.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
 hmp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hmp.c b/hmp.c
index ef93f4878b..a4d28913bb 100644
--- a/hmp.c
+++ b/hmp.c
@@ -1079,7 +1079,7 @@ void hmp_cpu(Monitor *mon, const QDict *qdict)
 
 void hmp_memsave(Monitor *mon, const QDict *qdict)
 {
-    uint32_t size = qdict_get_int(qdict, "size");
+    uint64_t size = qdict_get_int(qdict, "size");
     const char *filename = qdict_get_str(qdict, "filename");
     uint64_t addr = qdict_get_int(qdict, "val");
     Error *err = NULL;
@@ -1096,7 +1096,7 @@ void hmp_memsave(Monitor *mon, const QDict *qdict)
 
 void hmp_pmemsave(Monitor *mon, const QDict *qdict)
 {
-    uint32_t size = qdict_get_int(qdict, "size");
+    uint64_t size = qdict_get_int(qdict, "size");
     const char *filename = qdict_get_str(qdict, "filename");
     uint64_t addr = qdict_get_int(qdict, "val");
     Error *err = NULL;
-- 
2.15.0

  parent reply	other threads:[~2018-05-21 15:36 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-10 21:24 [Qemu-devel] [PATCH] qmp: add pmemload command Simon Ruderich
2018-04-10 21:27 ` no-reply
2018-04-10 21:33 ` Eric Blake
2018-04-11  7:36   ` Simon Ruderich
2018-04-11 13:02     ` Eric Blake
2018-04-12 12:48       ` Simon Ruderich
2018-04-12 12:50         ` [Qemu-devel] [PATCH v2 1/5] cpus: correct coding style in qmp_memsave/qmp_pmemsave Simon Ruderich
2018-04-12 12:50           ` [Qemu-devel] [PATCH v2 2/5] cpus: convert qmp_memsave/qmp_pmemsave to use qemu_open Simon Ruderich
2018-04-17 20:58             ` Eric Blake
2018-04-12 12:50           ` [Qemu-devel] [PATCH v2 3/5] cpus: use size_t in qmp_memsave/qmp_pmemsave Simon Ruderich
2018-04-17 20:58             ` Eric Blake
2018-04-12 12:50           ` [Qemu-devel] [PATCH v2 4/5] hmp: don't truncate size in hmp_memsave/hmp_pmemsave Simon Ruderich
2018-04-17 20:59             ` Eric Blake
2018-04-12 12:50           ` [Qemu-devel] [PATCH v2 5/5] qmp: add pmemload command Simon Ruderich
2018-04-17 21:18             ` Eric Blake
2018-04-22  9:47               ` Simon Ruderich
2018-04-23 19:46                 ` Eric Blake
2018-04-24 14:50                   ` Simon Ruderich
2018-04-17 20:56           ` [Qemu-devel] [PATCH v2 1/5] cpus: correct coding style in qmp_memsave/qmp_pmemsave Eric Blake
2018-04-22  9:19             ` Simon Ruderich
2018-05-21 15:36 ` [Qemu-devel] [PATCH v3 0/5] qmp: add pmemload command Simon Ruderich
2018-05-21 15:36   ` [Qemu-devel] [PATCH v3 1/5] cpus: correct coding style in qmp_memsave/qmp_pmemsave Simon Ruderich
2018-05-21 15:36   ` [Qemu-devel] [PATCH v3 2/5] cpus: convert qmp_memsave/qmp_pmemsave to use qemu_open Simon Ruderich
2018-05-21 15:36   ` [Qemu-devel] [PATCH v3 3/5] cpus: use size_t in qmp_memsave/qmp_pmemsave Simon Ruderich
2018-05-21 15:36   ` Simon Ruderich [this message]
2018-05-21 15:36   ` [Qemu-devel] [PATCH v3 5/5] qmp: add pmemload command Simon Ruderich
2018-08-09 16:46     ` Eric Blake
2018-08-14 14:16       ` Simon Ruderich
2018-08-10 10:36     ` Dr. David Alan Gilbert
2018-08-14 14:18       ` Simon Ruderich
2018-08-14 15:49         ` Markus Armbruster
2018-08-14 19:03           ` Simon Ruderich
2018-08-15  4:22             ` Markus Armbruster
2018-08-15 12:41               ` Simon Ruderich
2018-08-15 14:29                 ` Markus Armbruster
2018-08-15 15:46                   ` Simon Ruderich
2018-08-16  5:43                     ` Markus Armbruster
2018-08-16  8:13                       ` Simon Ruderich
2018-08-16  8:26                         ` Markus Armbruster
2018-08-16  8:38                           ` Simon Ruderich
2018-08-14 19:30         ` Dr. David Alan Gilbert
2018-08-09 14:43   ` [Qemu-devel] [PATCH v3 0/5] " Simon Ruderich
2018-08-10  6:06     ` Markus Armbruster
2018-08-14 14:16       ` Simon Ruderich
2018-08-14 15:27         ` Markus Armbruster
2018-08-16  9:01 ` [Qemu-devel] [PATCH v4 0/7] qmp/hmp: " Simon Ruderich
2018-08-16  9:01   ` [Qemu-devel] [PATCH v4 1/7] cpus: correct coding style in qmp_memsave/qmp_pmemsave Simon Ruderich
2018-08-16 19:56     ` Eric Blake
2018-08-16  9:01   ` [Qemu-devel] [PATCH v4 2/7] cpus: convert qmp_memsave/qmp_pmemsave to use qemu_open Simon Ruderich
2018-08-16 19:58     ` Eric Blake
2018-08-16  9:01   ` [Qemu-devel] [PATCH v4 3/7] cpus: use size_t in qmp_memsave/qmp_pmemsave Simon Ruderich
2018-08-16 19:58     ` Eric Blake
2018-08-16  9:01   ` [Qemu-devel] [PATCH v4 4/7] hmp: use l for size argument in memsave/pmemsave Simon Ruderich
2018-08-16 18:51     ` Dr. David Alan Gilbert
2018-08-16  9:01   ` [Qemu-devel] [PATCH v4 5/7] hmp: use F for filename arguments " Simon Ruderich
2018-08-16 18:53     ` Dr. David Alan Gilbert
2018-08-16  9:01   ` [Qemu-devel] [PATCH v4 6/7] qmp: add pmemload command Simon Ruderich
2018-08-16 20:01     ` Eric Blake
2018-08-17  7:50       ` Simon Ruderich
2018-08-21 12:38       ` [Qemu-devel] [PATCH v5 5/6] " Simon Ruderich
     [not found]         ` <20180921110205.GA904@ruderich.org>
2018-10-09 12:14           ` Simon Ruderich
2018-08-16  9:01   ` [Qemu-devel] [PATCH v4 7/7] hmp: " Simon Ruderich
2018-08-16 18:57     ` Dr. David Alan Gilbert
2018-11-15 13:01 ` [Qemu-devel] [PATCH v6 0/6] qmp: " Simon Ruderich
2018-11-15 13:01   ` [Qemu-devel] [PATCH v6 1/6] cpus: convert qmp_memsave/qmp_pmemsave to use qemu_open Simon Ruderich
2018-11-15 13:01   ` [Qemu-devel] [PATCH v6 2/6] cpus: use size_t in qmp_memsave/qmp_pmemsave Simon Ruderich
2018-11-15 13:01   ` [Qemu-devel] [PATCH v6 3/6] hmp: use l for size argument in memsave/pmemsave Simon Ruderich
2018-11-15 13:01   ` [Qemu-devel] [PATCH v6 4/6] hmp: use F for filename arguments " Simon Ruderich
2018-11-15 13:01   ` [Qemu-devel] [PATCH v6 5/6] qmp: add pmemload command Simon Ruderich
2018-11-15 13:01   ` [Qemu-devel] [PATCH v6 6/6] hmp: " Simon Ruderich
2018-11-15 13:22 ` [Qemu-devel] [PATCH v7 0/7] qmp: " Simon Ruderich
2018-11-15 13:22   ` [Qemu-devel] [PATCH v7 1/7] cpus: correct coding style in qmp_memsave/qmp_pmemsave Simon Ruderich
2018-11-15 13:46     ` Eric Blake
2018-11-15 13:22   ` [Qemu-devel] [PATCH v7 2/7] cpus: convert qmp_memsave/qmp_pmemsave to use qemu_open Simon Ruderich
2018-11-15 13:49     ` Eric Blake
2018-11-15 13:22   ` [Qemu-devel] [PATCH v7 3/7] cpus: use size_t in qmp_memsave/qmp_pmemsave Simon Ruderich
2018-11-15 13:22   ` [Qemu-devel] [PATCH v7 4/7] hmp: use l for size argument in memsave/pmemsave Simon Ruderich
2018-11-15 13:22   ` [Qemu-devel] [PATCH v7 5/7] hmp: use F for filename arguments " Simon Ruderich
2018-11-15 13:22   ` [Qemu-devel] [PATCH v7 6/7] qmp: add pmemload command Simon Ruderich
2018-11-15 13:22   ` [Qemu-devel] [PATCH v7 7/7] hmp: " Simon Ruderich
2018-11-15 13:45   ` [Qemu-devel] [PATCH v7 0/7] qmp: " Eric Blake
2018-11-15 14:09     ` Simon Ruderich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e07162bfefe8e4f376d52318c9ab53f7ad916176.1526916378.git.simon@ruderich.org \
    --to=simon@ruderich.org \
    --cc=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.